HBase
  1. HBase
  2. HBASE-9993

0.94: HBASE-9865 breaks coprocessor compatibility with WALEdit.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.14
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

        public List<KeyValue> getKeyValues() {
      

      Was changed to

        public ArrayList<KeyValue> getKeyValues() {
      

      This break existing coprocessors (such as those used in Phoenix).
      It's fine to change in 0.96+, but in 0.94 it should remain backwards compatible.

      James Taylor, FYI.

      1. 9993.txt
        1 kB
        Lars Hofhansl

        Issue Links

          Activity

          Lars Hofhansl created issue -
          Lars Hofhansl made changes -
          Field Original Value New Value
          Description {code}
            public List<KeyValue> getKeyValues() {
          {code}
          Was changed to
          {code}
            public ArrayList<KeyValue> getKeyValues() {
          {code}

          This break existing coprocessors (such as those used in Phoenix).
          It's fine to change in 0.96+, but in 0.94 it should remain backwards compatible.

          [~giacomotaylor], FYI.
          Lars Hofhansl made changes -
          Fix Version/s 0.94.14 [ 12325047 ]
          Hide
          Lars Hofhansl added a comment -

          Simple fix. Not as pretty, but OK I think.
          If WALEdit ever changes in a way where this would not work, the replication tests would catch it.

          If there are no objections I will commit this soon and roll a new RC.

          Show
          Lars Hofhansl added a comment - Simple fix. Not as pretty, but OK I think. If WALEdit ever changes in a way where this would not work, the replication tests would catch it. If there are no objections I will commit this soon and roll a new RC.
          Lars Hofhansl made changes -
          Attachment 9993.txt [ 12614504 ]
          Lars Hofhansl made changes -
          Priority Major [ 3 ] Blocker [ 1 ]
          Lars Hofhansl made changes -
          Link This issue is related to HBASE-9865 [ HBASE-9865 ]
          Hide
          Jesse Yates added a comment -

          +0.75 Would be little better to have a comment in there as to why you are doing the casting, so reading the code is a little clearer. Fine if you want to commit without it though too.

          Show
          Jesse Yates added a comment - +0.75 Would be little better to have a comment in there as to why you are doing the casting, so reading the code is a little clearer. Fine if you want to commit without it though too.
          Hide
          Lars Hofhansl added a comment -

          Committed to 0.94

          Show
          Lars Hofhansl added a comment - Committed to 0.94
          Lars Hofhansl made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.94-security #341 (See https://builds.apache.org/job/HBase-0.94-security/341/)
          HBASE-9993 0.94: HBASE-9865 breaks coprocessor compatibility with WALEdit. (larsh: rev 1543220)

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #341 (See https://builds.apache.org/job/HBase-0.94-security/341/ ) HBASE-9993 0.94: HBASE-9865 breaks coprocessor compatibility with WALEdit. (larsh: rev 1543220) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.94 #1207 (See https://builds.apache.org/job/HBase-0.94/1207/)
          HBASE-9993 0.94: HBASE-9865 breaks coprocessor compatibility with WALEdit. (larsh: rev 1543220)

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.94 #1207 (See https://builds.apache.org/job/HBase-0.94/1207/ ) HBASE-9993 0.94: HBASE-9865 breaks coprocessor compatibility with WALEdit. (larsh: rev 1543220) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Lars Hofhansl made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          12m 10s 1 Lars Hofhansl 18/Nov/13 23:02
          Resolved Resolved Closed Closed
          7d 6h 50m 1 Lars Hofhansl 26/Nov/13 05:53

            People

            • Assignee:
              Lars Hofhansl
              Reporter:
              Lars Hofhansl
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development