Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-9985

Add HBase shell command to start/stop tracing

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.96.1
    • Component/s: shell
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Adds new trace 'start', trace 'status', and trace 'stop' commands to shell.

      Description

      Adding utility command to HBase shell for starting/stopping tracing span of HTrace. This command also initializes SpanReceiverHost on client side.

      1. HBASE-9985-0.patch
        3 kB
        stack
      2. HBASE-9985-0.patch
        3 kB
        Masatake Iwasaki

        Issue Links

          Activity

          Hide
          iwasakims Masatake Iwasaki added a comment -

          attaching patch for adding simple tracing utility command.

          Show
          iwasakims Masatake Iwasaki added a comment - attaching patch for adding simple tracing utility command.
          Hide
          stack stack added a comment -

          This looks very nice. +1 Elliott Clark What you think honey?

          Show
          stack stack added a comment - This looks very nice. +1 Elliott Clark What you think honey?
          Hide
          eclark Elliott Clark added a comment -

          +1

          Show
          eclark Elliott Clark added a comment - +1
          Hide
          ndimiduk Nick Dimiduk added a comment -

          submitting for buildbot.

          Show
          ndimiduk Nick Dimiduk added a comment - submitting for buildbot.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12614267/HBASE-9985-0.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 10 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.master.TestRestartCluster

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614267/HBASE-9985-0.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 10 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestRestartCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7905//console This message is automatically generated.
          Hide
          stack stack added a comment -

          Retry buildbot (seems radically unrelated but retrying just in case)

          Show
          stack stack added a comment - Retry buildbot (seems radically unrelated but retrying just in case)
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12614307/HBASE-9985-0.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 10 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614307/HBASE-9985-0.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 10 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7906//console This message is automatically generated.
          Hide
          stack stack added a comment -

          Committed to trunk and 0.96. Thanks you for the patch Masatake Iwasaki

          Show
          stack stack added a comment - Committed to trunk and 0.96. Thanks you for the patch Masatake Iwasaki
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks for your comments and committing stack! This is my first patch for HBase

          Show
          iwasakims Masatake Iwasaki added a comment - Thanks for your comments and committing stack ! This is my first patch for HBase
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in hbase-0.96 #194 (See https://builds.apache.org/job/hbase-0.96/194/)
          HBASE-9985 Add HBase shell command to start/stop tracing (stack: rev 1542895)

          • /hbase/branches/0.96/hbase-shell/src/main/ruby/shell.rb
          • /hbase/branches/0.96/hbase-shell/src/main/ruby/shell/commands/trace.rb
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #194 (See https://builds.apache.org/job/hbase-0.96/194/ ) HBASE-9985 Add HBase shell command to start/stop tracing (stack: rev 1542895) /hbase/branches/0.96/hbase-shell/src/main/ruby/shell.rb /hbase/branches/0.96/hbase-shell/src/main/ruby/shell/commands/trace.rb
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #4685 (See https://builds.apache.org/job/HBase-TRUNK/4685/)
          HBASE-9985 Add HBase shell command to start/stop tracing (stack: rev 1542894)

          • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/trace.rb
            HBASE-9985 Add HBase shell command to start/stop tracing (stack: rev 1542893)
          • /hbase/trunk/hbase-shell/src/main/ruby/shell.rb
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4685 (See https://builds.apache.org/job/HBase-TRUNK/4685/ ) HBASE-9985 Add HBase shell command to start/stop tracing (stack: rev 1542894) /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/trace.rb HBASE-9985 Add HBase shell command to start/stop tracing (stack: rev 1542893) /hbase/trunk/hbase-shell/src/main/ruby/shell.rb
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in hbase-0.96-hadoop2 #123 (See https://builds.apache.org/job/hbase-0.96-hadoop2/123/)
          HBASE-9985 Add HBase shell command to start/stop tracing (stack: rev 1542895)

          • /hbase/branches/0.96/hbase-shell/src/main/ruby/shell.rb
          • /hbase/branches/0.96/hbase-shell/src/main/ruby/shell/commands/trace.rb
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in hbase-0.96-hadoop2 #123 (See https://builds.apache.org/job/hbase-0.96-hadoop2/123/ ) HBASE-9985 Add HBase shell command to start/stop tracing (stack: rev 1542895) /hbase/branches/0.96/hbase-shell/src/main/ruby/shell.rb /hbase/branches/0.96/hbase-shell/src/main/ruby/shell/commands/trace.rb
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #842 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/842/)
          HBASE-9985 Add HBase shell command to start/stop tracing (stack: rev 1542894)

          • /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/trace.rb
            HBASE-9985 Add HBase shell command to start/stop tracing (stack: rev 1542893)
          • /hbase/trunk/hbase-shell/src/main/ruby/shell.rb
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #842 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/842/ ) HBASE-9985 Add HBase shell command to start/stop tracing (stack: rev 1542894) /hbase/trunk/hbase-shell/src/main/ruby/shell/commands/trace.rb HBASE-9985 Add HBase shell command to start/stop tracing (stack: rev 1542893) /hbase/trunk/hbase-shell/src/main/ruby/shell.rb
          Hide
          stack stack added a comment -

          Released in 0.96.1. Issue closed.

          Show
          stack stack added a comment - Released in 0.96.1. Issue closed.

            People

            • Assignee:
              Unassigned
              Reporter:
              iwasakims Masatake Iwasaki
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development