-1 for --size instead of --rows
+1 for --size in addition of --rows

I think the 2 can (and need to) leave together so we can still easily compare previous release to new release.

Yes, my intention isn't to remove existing functionality, at least not right away. Let's prove a new idea useful first.

Hi Nick Dimiduk any update on this one?

Yes, but not on the tool itself. I ended up writing a driver script that does the calculation for me. Nothing complicated. Let me throw together a patch.

Attached patch is post-refactor.

2 comments.

1) You might want to update printUsage too to provide usage.
2) If both (opts.size == DEFAULT_OPTS.size) and (opts.perClientRunRows == DEFAULT_OPTS.perClientRunRows) then opts.totalRows is never set?

Refreshing patch after a short hiatus. Added description for new --size command to help text.

Jean-Marc Spaggiari

2) If both (opts.size == DEFAULT_OPTS.size) and (opts.perClientRunRows == DEFAULT_OPTS.perClientRunRows) then opts.totalRows is never set?

Yes, that's fine; in this case the default totalRows value of 1024 * 1024 is used.

ping Nicolas Liochon, stack.

+1 Commit and I'll try it. Let me explain over in the modulo issue how it does similar but I like your take better (After trying this, may back out the modulo arg)

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12641941/HBASE-9953.01.patch
against trunk revision .
ATTACHMENT ID: 12641941

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

-1 javadoc. The javadoc tool appears to have generated 8 warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 lineLengths. The patch does not introduce lines longer than 100

+1 site. The mvn site goal succeeds with this patch.

+1 core tests. The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9401//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9401//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9401//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9401//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9401//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9401//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9401//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9401//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9401//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9401//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9401//console

This message is automatically generated.

Committed to trunk.

SUCCESS: Integrated in HBase-TRUNK #5120 (See https://builds.apache.org/job/HBase-TRUNK/5120/)
HBASE-9953 PerformanceEvaluation: Decouple data size from client concurrency (ndimiduk: rev 1590216)

• /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java

This seems to work nicely for me. Funny how when the block cache is 4G, if you set the size to get to 4G, you fall out of BC. If you set it to 3G, you still do. 2.8G gets the BC 100% used w/ no misses. We've lots of overhead it seems (smile). Let me remove my modulo malarky.

Yes, I've observed our population doesn't quite match the space available. Something is lying, or at least off by some small amount that's repeated many times over, but I don't yet know what.

Closing this issue after 0.99.0 release.