Hey Ted Yu commented on Friday or Thursday that I'm concerned about this infrastructure creeping in throughout the code. Specifically the in the main comment i mentioned that "This was not addressed" and then you committed without addressing the concern I had with the code in the review and there were no +1's in review board. (Though sergey had a conditional +1 in jira).
I'm assuming this was a an oversight.
To be clear, I'm basically fine with the fix – I'm mostly concerned about the new framework.
It seems like yet another infrastructure and it is one that I'm not particularly fond of because of it seems cumbersome and has the potential to perf impact in other areas if extended. This will take more work but it can be done in a way that makes the code more readable and maintainable and I'd rather we move in that direction instead of adding yet more one of infrastructures. Can we instead make use a factories patterns + mocks to do this injection? Happy to move this discussion to the mailing list.