HBase
  1. HBase
  2. HBASE-9892

Add info port to ServerName to support multi instances in a node

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.99.0
    • Component/s: None
    • Labels:
      None

      Description

      The full GC time of regionserver with big heap(> 30G ) usually can not be controlled in 30s. At the same time, the servers with 64G memory are normal. So we try to deploy multi rs instances(2-3 ) in a single node and the heap of each rs is about 20G ~ 24G.

      Most of the things works fine, except the hbase web ui. The master get the RS info port from conf, which is suitable for this situation of multi rs instances in a node. So we add info port to ServerName.
      a. at the startup, rs report it's info port to Hmaster.
      b, For root region, rs write the servername with info port ro the zookeeper root-region-server node.
      c, For meta regions, rs write the servername with info port to root region
      d. For user regions, rs write the servername with info port to meta regions

      So hmaster and client can get info port from the servername.
      To test this feature, I change the rs num from 1 to 3 in standalone mode, so we can test it in standalone mode,

      I think Hoya(hbase on yarn) will encounter the same problem. Anyone knows how Hoya handle this problem?

      PS: There are different formats for servername in zk node and meta table, i think we need to unify it and refactor the code.

      1. HBASE-9892-0.94-v1.diff
        28 kB
        Liu Shaohui
      2. HBASE-9892-0.94-v2.diff
        14 kB
        Liu Shaohui
      3. HBASE-9892-0.94-v3.diff
        17 kB
        Liu Shaohui
      4. HBASE-9892-0.94-v4.diff
        34 kB
        Liu Shaohui
      5. HBASE-9892-0.94-v5.diff
        35 kB
        Liu Shaohui
      6. HBASE-9892-0.94-v6.diff
        34 kB
        Liu Shaohui
      7. HBASE-9892-trunk-v1.diff
        38 kB
        Liu Shaohui
      8. HBASE-9892-trunk-v1.patch
        38 kB
        stack
      9. HBASE-9892-trunk-v1.patch
        38 kB
        stack
      10. HBASE-9892-trunk-v2.patch
        37 kB
        Liu Shaohui
      11. HBASE-9892-trunk-v3.diff
        37 kB
        Liu Shaohui
      12. HBASE-9892-v5.txt
        37 kB
        stack

        Issue Links

          Activity

          Hide
          Liu Shaohui added a comment -

          Patch for hbase 0.94

          Show
          Liu Shaohui added a comment - Patch for hbase 0.94
          Hide
          Enis Soztutar added a comment -

          We don't have to hold the info port as a part of ServerName I think. ServerName is for unique identifying the RS process. We can keep the info port as reported by the RS in ServerManager, and the web UI can get the port by ServerName from there.
          Hoya, right now, does not start multiple region servers of the same host for the same cluster I believe.

          Show
          Enis Soztutar added a comment - We don't have to hold the info port as a part of ServerName I think. ServerName is for unique identifying the RS process. We can keep the info port as reported by the RS in ServerManager, and the web UI can get the port by ServerName from there. Hoya, right now, does not start multiple region servers of the same host for the same cluster I believe.
          Hide
          stack added a comment -

          Liu Shaohui I commented similar to Enis over in RB.

          The issue w/ RS reporting its info port only when it registers is that should the master fail, how does the new master figure what the info port for all running RSs are?

          Is the info port availble in jmx server attributes? If not, could add there? Or RS could write static attributes like info port into the body of its ephemeral znode?

          There are different formats in trunk for SN in znode and meta?

          Show
          stack added a comment - Liu Shaohui I commented similar to Enis over in RB. The issue w/ RS reporting its info port only when it registers is that should the master fail, how does the new master figure what the info port for all running RSs are? Is the info port availble in jmx server attributes? If not, could add there? Or RS could write static attributes like info port into the body of its ephemeral znode? There are different formats in trunk for SN in znode and meta?
          Hide
          Liu Shaohui added a comment -

          Enis Soztutar Good idea.

          I will try to add an api : getRegionServerInfoPort(ServerName) in HMaster for get the port by ServerName from ServerManager.

          Show
          Liu Shaohui added a comment - Enis Soztutar Good idea. I will try to add an api : getRegionServerInfoPort(ServerName) in HMaster for get the port by ServerName from ServerManager.
          Hide
          Liu Shaohui added a comment -

          stack

          The issue w/ RS reporting its info port only when it registers is that should the master fail, how does the new master figure what the info port for all running RSs are?
          Is the info port availble in jmx server attributes? If not, could add there? Or RS could write static attributes like info port into the body of its ephemeral znode?

          Thanks stack. I did not notice this problem.
          Now, there is no data in regionserver's ephemeral node. It's a good idea to write static attributes like info port there.
          What do you think? Enis Soztutar

          There are different formats in trunk for SN in znode and meta?

          For meta, there are two columns: server(ip:port) and serverstartcode for SN.
          For root-region-server zk node, the format is "ip,port,serverstartcode"

          Show
          Liu Shaohui added a comment - stack The issue w/ RS reporting its info port only when it registers is that should the master fail, how does the new master figure what the info port for all running RSs are? Is the info port availble in jmx server attributes? If not, could add there? Or RS could write static attributes like info port into the body of its ephemeral znode? Thanks stack . I did not notice this problem. Now, there is no data in regionserver's ephemeral node. It's a good idea to write static attributes like info port there. What do you think? Enis Soztutar There are different formats in trunk for SN in znode and meta? For meta, there are two columns: server(ip:port) and serverstartcode for SN. For root-region-server zk node, the format is "ip,port,serverstartcode"
          Hide
          stack added a comment -

          Now, there is no data in regionserver's ephemeral node. It's a good idea to write static attributes like info port there.

          It is a suggestion.

          Could be tricky setting this value then triggering watches. Will have to reset them.

          Maybe znode is not the right place? It is too awkward and if only this one attribute, its a bit of work adding it there.

          It could be added to the server JMX bean but you'd have to do rmi to find it which requires a port.... (IIRC)

          There is the RS heartbeat. Currently we send load. Seems a bit silly sending over constant attributes on each heartbeat but might be easy to do.

          Show
          stack added a comment - Now, there is no data in regionserver's ephemeral node. It's a good idea to write static attributes like info port there. It is a suggestion. Could be tricky setting this value then triggering watches. Will have to reset them. Maybe znode is not the right place? It is too awkward and if only this one attribute, its a bit of work adding it there. It could be added to the server JMX bean but you'd have to do rmi to find it which requires a port.... (IIRC) There is the RS heartbeat. Currently we send load. Seems a bit silly sending over constant attributes on each heartbeat but might be easy to do.
          Hide
          Liu Shaohui added a comment -

          New patch for hbase 0.94

          a. Write rs info port to it's ephemeral node
          b. RegionServerTracker in HMaster watch regionservers node and keep a map: servername-> infoport
          c, web ui in hmaster gets rs's info port from RegionServerTracker through hmaster.

          Show
          Liu Shaohui added a comment - New patch for hbase 0.94 a. Write rs info port to it's ephemeral node b. RegionServerTracker in HMaster watch regionservers node and keep a map: servername-> infoport c, web ui in hmaster gets rs's info port from RegionServerTracker through hmaster.
          Hide
          Liu Shaohui added a comment -

          Could be tricky setting this value then triggering watches. Will have to reset them.

          No need to reset them. RegionServerTracker only get data from zk once.

          It could be added to the server JMX bean but you'd have to do rmi to find it which requires a port.... (IIRC)
          There is the RS heartbeat. Currently we send load. Seems a bit silly sending over constant attributes on each heartbeat but might be easy to do.

          I think the info port of a rs will not change after it starts up, so no need to send over constant attributes on each heartbeat.

          Show
          Liu Shaohui added a comment - Could be tricky setting this value then triggering watches. Will have to reset them. No need to reset them. RegionServerTracker only get data from zk once. It could be added to the server JMX bean but you'd have to do rmi to find it which requires a port.... (IIRC) There is the RS heartbeat. Currently we send load. Seems a bit silly sending over constant attributes on each heartbeat but might be easy to do. I think the info port of a rs will not change after it starts up, so no need to send over constant attributes on each heartbeat.
          Hide
          stack added a comment -

          Patch looks fine.

          Did you intend to include this in the patch?

          Index: src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java

          ... and this?

          Index: src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java

          Should this be public? Can it be package protected?

          getRegionServerInfoPort

          Can we write the znode content as protobuf? Will make it easier adding new attributes and in trunk, all znodes are pb:

          + String nodePath = ZKUtil.joinZNode(watcher.rsZNode, n);
          + infoPort = Bytes.toInt(ZKUtil.getData(watcher, nodePath));

          If you need help, I can help do the trunk patch np.

          Good stuff.

          Show
          stack added a comment - Patch looks fine. Did you intend to include this in the patch? Index: src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java ... and this? Index: src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java Should this be public? Can it be package protected? getRegionServerInfoPort Can we write the znode content as protobuf? Will make it easier adding new attributes and in trunk, all znodes are pb: + String nodePath = ZKUtil.joinZNode(watcher.rsZNode, n); + infoPort = Bytes.toInt(ZKUtil.getData(watcher, nodePath)); If you need help, I can help do the trunk patch np. Good stuff.
          Hide
          Enis Soztutar added a comment -

          Great. Left some comments at RB.

          Show
          Enis Soztutar added a comment - Great. Left some comments at RB.
          Hide
          Liu Shaohui added a comment -

          stack

          Did you intend to include this in the patch?
          Index: src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java
          ... and this?
          Index: src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
          Should this be public? Can it be package protected?

          I did not get your meaning. All these http Servlets are public. I think no need to change it to package protected.

          Can we write the znode content as protobuf? Will make it easier adding new attributes and in trunk, all znodes are pb:
          + String nodePath = ZKUtil.joinZNode(watcher.rsZNode, n);
          + infoPort = Bytes.toInt(ZKUtil.getData(watcher, nodePath));

          Yes. I will write a writable class: RegionServerInfo for 0.94 and pb for trunk. Enis Soztutar

          Show
          Liu Shaohui added a comment - stack Did you intend to include this in the patch? Index: src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java ... and this? Index: src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java Should this be public? Can it be package protected? I did not get your meaning. All these http Servlets are public. I think no need to change it to package protected. Can we write the znode content as protobuf? Will make it easier adding new attributes and in trunk, all znodes are pb: + String nodePath = ZKUtil.joinZNode(watcher.rsZNode, n); + infoPort = Bytes.toInt(ZKUtil.getData(watcher, nodePath)); Yes. I will write a writable class: RegionServerInfo for 0.94 and pb for trunk. Enis Soztutar
          Hide
          Liu Shaohui added a comment -

          Upload a new patch for Enis Soztutar's review.
          If this patch is ok, i will start to make a trunk patch.

          Show
          Liu Shaohui added a comment - Upload a new patch for Enis Soztutar 's review. If this patch is ok, i will start to make a trunk patch.
          Hide
          Liu Shaohui added a comment -

          Update for Enis Soztutar's review. Please review it in RB. thx

          Show
          Liu Shaohui added a comment - Update for Enis Soztutar 's review. Please review it in RB. thx
          Hide
          Steve Loughran added a comment -

          As Enis says, currently we know the problem is there but don't try to fix it.

          The issue we have there is not just if YARN assigns >1 region server to the same node (it doesn't currently support anti-affinity in allocation requests), but that someone else may be running their own application, HBase or otherwise, on the same machine. If you hard code a port it can fail -any port. The sole advantage we have is that will trigger a new container request/review

          Because this also affects the masters, we have to leave that UI at port 0 too -which is the worst issue. I would really like to get hold of that via ZK, from where we can bootstrap the rest of the cluster information

          Show
          Steve Loughran added a comment - As Enis says, currently we know the problem is there but don't try to fix it. The issue we have there is not just if YARN assigns >1 region server to the same node (it doesn't currently support anti-affinity in allocation requests), but that someone else may be running their own application, HBase or otherwise, on the same machine. If you hard code a port it can fail -any port. The sole advantage we have is that will trigger a new container request/review Because this also affects the masters, we have to leave that UI at port 0 too -which is the worst issue. I would really like to get hold of that via ZK, from where we can bootstrap the rest of the cluster information
          Hide
          Nick Dimiduk added a comment -

          Hi Liu Shaohui

          I cannot reproduce the problem you describe on 0.96 or trunk. There it appears the info port comes from ServerName or ServerLoad objects for live server link or dead server list, respectively. Could we not backport an existing fix rather than add all this new plumbing?

          For context, I have multiple RS processes deployed on each RS host. Their RPC and info ports are set explicitly for each process. Perhaps your configuration is different?

          Show
          Nick Dimiduk added a comment - Hi Liu Shaohui I cannot reproduce the problem you describe on 0.96 or trunk. There it appears the info port comes from ServerName or ServerLoad objects for live server link or dead server list, respectively. Could we not backport an existing fix rather than add all this new plumbing? For context, I have multiple RS processes deployed on each RS host. Their RPC and info ports are set explicitly for each process. Perhaps your configuration is different?
          Hide
          Enis Soztutar added a comment -

          If we do not have the problem in 0.96, I would be -0 for fixing it in 0.94.

          Show
          Enis Soztutar added a comment - If we do not have the problem in 0.96, I would be -0 for fixing it in 0.94.
          Hide
          Liu Shaohui added a comment -

          Thanks Nick DimidukEnis Soztutar
          HBASE-7027 partly have fixed the problem by report the info port to hmaster via serverLoad indead.

          But the infoPort in table.jps still be got from config.

            // HARDCODED FOR NOW TODO: FIX GET FROM ZK
            // This port might be wrong if RS actually ended up using something else.
            int infoPort = conf.getInt("hbase.regionserver.info.port", 60030);
          

          What about backporting HBASE-7027 to 0.94 and fixing the issue in table.jsp?

          Show
          Liu Shaohui added a comment - Thanks Nick Dimiduk Enis Soztutar HBASE-7027 partly have fixed the problem by report the info port to hmaster via serverLoad indead. But the infoPort in table.jps still be got from config. // HARDCODED FOR NOW TODO: FIX GET FROM ZK // This port might be wrong if RS actually ended up using something else . int infoPort = conf.getInt( "hbase.regionserver.info.port" , 60030); What about backporting HBASE-7027 to 0.94 and fixing the issue in table.jsp?
          Hide
          Enis Soztutar added a comment -

          What about backporting HBASE-7027 to 0.94 and fixing the issue in table.jsp?

          It makes sense, but the challenge is that we cannot easily backport HBASE-7027 without breaking BC. HServerLoad does not have extra fields we can use i fear.

          Your patch at RB is actually better than 7027, if we do this for trunk, we should undo 7027.

          Show
          Enis Soztutar added a comment - What about backporting HBASE-7027 to 0.94 and fixing the issue in table.jsp? It makes sense, but the challenge is that we cannot easily backport HBASE-7027 without breaking BC. HServerLoad does not have extra fields we can use i fear. Your patch at RB is actually better than 7027, if we do this for trunk, we should undo 7027.
          Hide
          stack added a comment -

          HBASE-7027 is an admitted hack; would be good to do it better.

          Show
          stack added a comment - HBASE-7027 is an admitted hack; would be good to do it better.
          Hide
          Liu Shaohui added a comment -

          Enis Soztutar

          What about backporting HBASE-7027 to 0.94 and fixing the issue in table.jsp?

          It makes sense, but the challenge is that we cannot easily backport HBASE-7027 without breaking BC. HServerLoad does not have extra fields we can use i fear.

          Since HServerLoad have verison field, I think we can add a info port field and keep the compatibility.

          stack Enis Soztutar Could you give a suggestion? Which method is acceptable?
          This patch or backporting 7027 and fixing the small issues left.

          Show
          Liu Shaohui added a comment - Enis Soztutar What about backporting HBASE-7027 to 0.94 and fixing the issue in table.jsp? It makes sense, but the challenge is that we cannot easily backport HBASE-7027 without breaking BC. HServerLoad does not have extra fields we can use i fear. Since HServerLoad have verison field, I think we can add a info port field and keep the compatibility. stack Enis Soztutar Could you give a suggestion? Which method is acceptable? This patch or backporting 7027 and fixing the small issues left.
          Hide
          stack added a comment -

          Liu Shaohui For trunk, removal of HBASE-7027 and replacing it with a pb'd and trunk version of the attached patch would be best going forward. For 0.94, yes, ServerLoad is versioned but changing it you will be into a thorny area for you will have to be able to demonstrate you have not for sure broken rolling updates. Thanks for working on this ugly issue.

          Show
          stack added a comment - Liu Shaohui For trunk, removal of HBASE-7027 and replacing it with a pb'd and trunk version of the attached patch would be best going forward. For 0.94, yes, ServerLoad is versioned but changing it you will be into a thorny area for you will have to be able to demonstrate you have not for sure broken rolling updates. Thanks for working on this ugly issue.
          Hide
          Enis Soztutar added a comment -

          Since HServerLoad have verison field, I think we can add a info port field and keep the compatibility.

          The problem with the versioned writables is that, on the serializing front, you have to know the version of the deserializing side. For example, in a rolling restart scenario, even if you version the HServerLoad, the master will throw exceptions if it has not updated yet because it will not know about the new version number.

          For trunk, removal of HBASE-7027 and replacing it with a pb'd and trunk version of the attached patch would be best going forward.

          Agreed. Let's forward port this patch to trunk and go with it. We have to PB the RegionServerInfo object in the RB patch. Undoing HBASE-7027 can be done in a subtask after this is committed.

          Show
          Enis Soztutar added a comment - Since HServerLoad have verison field, I think we can add a info port field and keep the compatibility. The problem with the versioned writables is that, on the serializing front, you have to know the version of the deserializing side. For example, in a rolling restart scenario, even if you version the HServerLoad, the master will throw exceptions if it has not updated yet because it will not know about the new version number. For trunk, removal of HBASE-7027 and replacing it with a pb'd and trunk version of the attached patch would be best going forward. Agreed. Let's forward port this patch to trunk and go with it. We have to PB the RegionServerInfo object in the RB patch. Undoing HBASE-7027 can be done in a subtask after this is committed.
          Hide
          Liu Shaohui added a comment -

          Thanks. stack Artem Orobets
          Please help to review patch for 0.94 in RB again.
          If there is no problems, I will start to make it to trunk.

          Show
          Liu Shaohui added a comment - Thanks. stack Artem Orobets Please help to review patch for 0.94 in RB again. If there is no problems, I will start to make it to trunk.
          Hide
          stack added a comment -

          Liu Shaohui What do you think of the Enis Soztutar comment above regards patch for 0.94?

          Show
          stack added a comment - Liu Shaohui What do you think of the Enis Soztutar comment above regards patch for 0.94?
          Hide
          Liu Shaohui added a comment -

          Sorry for so late reply.

          Update the patch and reviewboard for Enis Soztutar's review.

          Thanks a lot for Enis Soztutar's suggestions

          Show
          Liu Shaohui added a comment - Sorry for so late reply. Update the patch and reviewboard for Enis Soztutar 's review. Thanks a lot for Enis Soztutar 's suggestions
          Hide
          Steve Loughran added a comment -

          I had a quick look and while the intricacies of HBase code escape me , it looks like the Masters get the port info via ZK. Does this propagate as far as the hbase status data you get with HBaseAdmin.getClusterStatus()? That's where I need to pick it up from -along with the infoserver port of the master itself

          -steve

          Show
          Steve Loughran added a comment - I had a quick look and while the intricacies of HBase code escape me , it looks like the Masters get the port info via ZK. Does this propagate as far as the hbase status data you get with HBaseAdmin.getClusterStatus() ? That's where I need to pick it up from -along with the infoserver port of the master itself -steve
          Hide
          Liu Shaohui added a comment -

          Steve Loughran

          After checking the code of HBaseAdmin.getClusterStatus(), it seems that it does not return the info ports of regionservers.

          Show
          Liu Shaohui added a comment - Steve Loughran After checking the code of HBaseAdmin.getClusterStatus(), it seems that it does not return the info ports of regionservers.
          Hide
          stack added a comment -

          info port is an attribute that does not vary while server is up and running. It does not belong in the cluster status set. Can you not get it from zk Steve Loughran? Or failing that, you want us to write you a script that will read it out of zk for you – this and stuff like current master?

          Show
          stack added a comment - info port is an attribute that does not vary while server is up and running. It does not belong in the cluster status set. Can you not get it from zk Steve Loughran ? Or failing that, you want us to write you a script that will read it out of zk for you – this and stuff like current master?
          Hide
          Liu Shaohui added a comment -

          stack Enis Soztutar
          Please help to review the patch for 0.94 again?

          If there is no other problem, I will start to do the patch for trunk. Happy Thanksgiving!

          Show
          Liu Shaohui added a comment - stack Enis Soztutar Please help to review the patch for 0.94 again? If there is no other problem, I will start to do the patch for trunk. Happy Thanksgiving!
          Hide
          Enis Soztutar added a comment -

          info port is an attribute that does not vary while server is up and running. It does not belong in the cluster status set. Can you not get it from zk Steve Loughran? Or failing that, you want us to write you a script that will read it out of zk for you – this and stuff like current master?

          We still need to make the info ports and maybe other static attributes for the cluster to the clients as an API I think. It belongs together with liveServers data, since for each live server, the client may need the info port.

          Show
          Enis Soztutar added a comment - info port is an attribute that does not vary while server is up and running. It does not belong in the cluster status set. Can you not get it from zk Steve Loughran? Or failing that, you want us to write you a script that will read it out of zk for you – this and stuff like current master? We still need to make the info ports and maybe other static attributes for the cluster to the clients as an API I think. It belongs together with liveServers data, since for each live server, the client may need the info port.
          Hide
          Liu Shaohui added a comment -

          stack

          Update for stack's review: remove unused imports.

          Later for the trunk patch.

          Show
          Liu Shaohui added a comment - stack Update for stack's review: remove unused imports. Later for the trunk patch.
          Hide
          stack added a comment -

          First cut at a trunk patch

          (I just saw Liu Shaohui sleeping at his desk; obviously a man who is working too hard – smile).

          Liu wants this patch so he can run two hbases on single node.

          Show
          stack added a comment - First cut at a trunk patch (I just saw Liu Shaohui sleeping at his desk; obviously a man who is working too hard – smile). Liu wants this patch so he can run two hbases on single node.
          Hide
          Liu Shaohui added a comment -
          Show
          Liu Shaohui added a comment - stack Enis Soztutar Patch for trunk See RB: https://reviews.apache.org/r/16075
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12617325/HBASE-9892-trunk-v1.diff
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceImpl

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12617325/HBASE-9892-trunk-v1.diff against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceImpl Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8071//console This message is automatically generated.
          Hide
          stack added a comment -

          Retry

          Show
          stack added a comment - Retry
          Hide
          stack added a comment -

          Enis Soztutar You good w/ patch as is? I am. Wouldn't mind getting it into 0.96.1.

          Show
          stack added a comment - Enis Soztutar You good w/ patch as is? I am. Wouldn't mind getting it into 0.96.1.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12617503/HBASE-9892-trunk-v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceImpl

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12617503/HBASE-9892-trunk-v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceImpl Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8080//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12617512/HBASE-9892-trunk-v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceImpl

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12617512/HBASE-9892-trunk-v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceImpl Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8082//console This message is automatically generated.
          Hide
          Liu Shaohui added a comment -

          stack

          Sorry for the trunk patch makes the test TestMetricsRegionServerSourceImpl fail.

          I will find the reason and update the trunk patch later.

          Show
          Liu Shaohui added a comment - stack Sorry for the trunk patch makes the test TestMetricsRegionServerSourceImpl fail. I will find the reason and update the trunk patch later.
          Hide
          Enis Soztutar added a comment -

          Left some minor comments to address. Sorry that this is taking so long. Thanks Liu for pushing this.

          Show
          Enis Soztutar added a comment - Left some minor comments to address. Sorry that this is taking so long. Thanks Liu for pushing this.
          Hide
          Liu Shaohui added a comment -

          Update for Enis Soztutar's review and fix the test bug.

          Show
          Liu Shaohui added a comment - Update for Enis Soztutar 's review and fix the test bug.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12618593/HBASE-9892-trunk-v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618593/HBASE-9892-trunk-v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8156//console This message is automatically generated.
          Hide
          stack added a comment -

          +1 from me. Ok by you Enis Soztutar?

          Show
          stack added a comment - +1 from me. Ok by you Enis Soztutar ?
          Hide
          Enis Soztutar added a comment -

          Go for it!

          Show
          Enis Soztutar added a comment - Go for it!
          Hide
          stack added a comment -

          Liu Shaohui One thought I had before commit is what happens for say the case where it is an existing cluster and the znode has empty data? Will we use the info port from the configuration? What if we do a rolling restart when the znode has no data in it? Who writes the znode data? Will new servers be able to work if the znode has no data in it? Thanks.

          Show
          stack added a comment - Liu Shaohui One thought I had before commit is what happens for say the case where it is an existing cluster and the znode has empty data? Will we use the info port from the configuration? What if we do a rolling restart when the znode has no data in it? Who writes the znode data? Will new servers be able to work if the znode has no data in it? Thanks.
          Hide
          Liu Shaohui added a comment -

          update infoPort in RegionServerInfo to optional field

          Show
          Liu Shaohui added a comment - update infoPort in RegionServerInfo to optional field
          Hide
          Liu Shaohui added a comment -

          @stack

          One thought I had before commit is what happens for say the case where it is an existing cluster and the znode has empty data? Will we use the info port from the configuration?

          Yes. See the code in RegionServerTracker. if the znode has empty data or invalid data, default infoPort will be 0, and getRegionServerInfoPort in HMaster will return the REGIONSERVER_INFO_PORT from config.

          What if we do a rolling restart when the znode has no data in it? Who writes the znode data? Will new servers be able to work if the znode has no data in it?

          RegionServerTracker will handle this situation.
          For rs with old version, its znode has no data and hmaster will use info port from config. When new region servers start up, it will write the RSinfo data to it's znode and RegionServerTracker will watch this and use the data from znode.

          Show
          Liu Shaohui added a comment - @stack One thought I had before commit is what happens for say the case where it is an existing cluster and the znode has empty data? Will we use the info port from the configuration? Yes. See the code in RegionServerTracker. if the znode has empty data or invalid data, default infoPort will be 0, and getRegionServerInfoPort in HMaster will return the REGIONSERVER_INFO_PORT from config. What if we do a rolling restart when the znode has no data in it? Who writes the znode data? Will new servers be able to work if the znode has no data in it? RegionServerTracker will handle this situation. For rs with old version, its znode has no data and hmaster will use info port from config. When new region servers start up, it will write the RSinfo data to it's znode and RegionServerTracker will watch this and use the data from znode.
          Hide
          stack added a comment -

          Committed to trunk.

          Andrew Purtell You want this? Good for operators. Liu Shaohui needs it to run multiple RS on the one node. I will take it in 0.96 if you take it in 0.98.

          Show
          stack added a comment - Committed to trunk. Andrew Purtell You want this? Good for operators. Liu Shaohui needs it to run multiple RS on the one node. I will take it in 0.96 if you take it in 0.98.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619023/HBASE-9892-trunk-v3.diff
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619023/HBASE-9892-trunk-v3.diff against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8197//console This message is automatically generated.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #4730 (See https://builds.apache.org/job/HBase-TRUNK/4730/)
          HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1551458)

          • /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
          • /hbase/trunk/hbase-protocol/src/main/protobuf/HBase.proto
          • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
          • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
          • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java
          • /hbase/trunk/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4730 (See https://builds.apache.org/job/HBase-TRUNK/4730/ ) HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1551458) /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java /hbase/trunk/hbase-protocol/src/main/protobuf/HBase.proto /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java /hbase/trunk/hbase-server/src/main/resources/hbase-webapps/master/table.jsp /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #9 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/9/)
          HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1551458)

          • /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
          • /hbase/trunk/hbase-protocol/src/main/protobuf/HBase.proto
          • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
          • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
          • /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java
          • /hbase/trunk/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #9 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/9/ ) HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1551458) /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java /hbase/trunk/hbase-protocol/src/main/protobuf/HBase.proto /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java /hbase/trunk/hbase-server/src/main/resources/hbase-webapps/master/table.jsp /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java
          Hide
          stack added a comment -

          Andrew Purtell You want this boss?

          Show
          stack added a comment - Andrew Purtell You want this boss?
          Hide
          Andrew Purtell added a comment -

          Yes please stack

          Show
          Andrew Purtell added a comment - Yes please stack
          Hide
          stack added a comment -

          Resolving.

          You might want this issue Lars HofhanslLiu Shaohui wants to be able to run multiple RS on the one node and needs this to make it work. Lets open new issue though if you bring it into 0.94.

          Show
          stack added a comment - Resolving. You might want this issue Lars Hofhansl – Liu Shaohui wants to be able to run multiple RS on the one node and needs this to make it work. Lets open new issue though if you bring it into 0.94.
          Hide
          Lars Hofhansl added a comment -

          Would this have any backwards compatibility issues?

          Show
          Lars Hofhansl added a comment - Would this have any backwards compatibility issues?
          Hide
          stack added a comment -

          Not going by what Liu Shaohui writes above regards how it works but yeah, in 0.94, would want to try a rolling upgrade before commit I'd say.

          Show
          stack added a comment - Not going by what Liu Shaohui writes above regards how it works but yeah, in 0.94, would want to try a rolling upgrade before commit I'd say.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98 #22 (See https://builds.apache.org/job/HBase-0.98/22/)
          HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1552169)

          • /hbase/branches/0.98/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
          • /hbase/branches/0.98/hbase-protocol/src/main/protobuf/HBase.proto
          • /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
          • /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
          • /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java
          • /hbase/branches/0.98/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #22 (See https://builds.apache.org/job/HBase-0.98/22/ ) HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1552169) /hbase/branches/0.98/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java /hbase/branches/0.98/hbase-protocol/src/main/protobuf/HBase.proto /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java /hbase/branches/0.98/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
          Hide
          Liu Shaohui added a comment -

          stack Lars Hofhansl
          I will rebase the code and check the rolling upgrade compatibility for 0.94 today.

          Show
          Liu Shaohui added a comment - stack Lars Hofhansl I will rebase the code and check the rolling upgrade compatibility for 0.94 today.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #19 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/19/)
          HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1552169)

          • /hbase/branches/0.98/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
          • /hbase/branches/0.98/hbase-protocol/src/main/protobuf/HBase.proto
          • /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
          • /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
          • /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java
          • /hbase/branches/0.98/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #19 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/19/ ) HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1552169) /hbase/branches/0.98/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java /hbase/branches/0.98/hbase-protocol/src/main/protobuf/HBase.proto /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java /hbase/branches/0.98/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
          Hide
          Liu Shaohui added a comment -

          Lars Hofhansl
          Patch for 0.94 and test the compatibility

          Show
          Liu Shaohui added a comment - Lars Hofhansl Patch for 0.94 and test the compatibility
          Hide
          Enis Soztutar added a comment -

          Stack are we going to have this in 0.96?

          Show
          Enis Soztutar added a comment - Stack are we going to have this in 0.96?
          Hide
          stack added a comment -

          I'd like it in 0.96 if it does not break compatibility. I've not tried it. I can. Let me file it against 0.96.2 and try it before commit.

          Show
          stack added a comment - I'd like it in 0.96 if it does not break compatibility. I've not tried it. I can. Let me file it against 0.96.2 and try it before commit.
          Hide
          stack added a comment -

          Marking critical 0.96.2. Facilitates multiple RegionServers per node (I don't like that we have to do this but will facilitate it for those who would experiment). I'll test before committing to 0.96 when rolling 0.96.2 (soon).

          Show
          stack added a comment - Marking critical 0.96.2. Facilitates multiple RegionServers per node (I don't like that we have to do this but will facilitate it for those who would experiment). I'll test before committing to 0.96 when rolling 0.96.2 (soon).
          Hide
          Lars Hofhansl added a comment -

          This is currently marked fixed, but I do not think it was commited to 0.96.
          I would like this in 0.94 as well. Should I reopen, or rather create a backporting issue for 0.94 and 0.96?

          Show
          Lars Hofhansl added a comment - This is currently marked fixed, but I do not think it was commited to 0.96. I would like this in 0.94 as well. Should I reopen, or rather create a backporting issue for 0.94 and 0.96?
          Hide
          stack added a comment -

          Lars Hofhansl I opened HBASE-10340 I'd like to try it first. Will do soon.

          Show
          stack added a comment - Lars Hofhansl I opened HBASE-10340 I'd like to try it first. Will do soon.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in hbase-0.96 #283 (See https://builds.apache.org/job/hbase-0.96/283/)
          HBASE-10340 [BACKPORT] HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1565546)

          • /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
          • /hbase/branches/0.96/hbase-protocol/src/main/protobuf/HBase.proto
          • /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
          • /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
          • /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java
          • /hbase/branches/0.96/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
          Show
          Hudson added a comment - FAILURE: Integrated in hbase-0.96 #283 (See https://builds.apache.org/job/hbase-0.96/283/ ) HBASE-10340 [BACKPORT] HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1565546) /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java /hbase/branches/0.96/hbase-protocol/src/main/protobuf/HBase.proto /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java /hbase/branches/0.96/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in hbase-0.96-hadoop2 #196 (See https://builds.apache.org/job/hbase-0.96-hadoop2/196/)
          HBASE-10340 [BACKPORT] HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1565546)

          • /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
          • /hbase/branches/0.96/hbase-protocol/src/main/protobuf/HBase.proto
          • /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
          • /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
          • /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java
          • /hbase/branches/0.96/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
          Show
          Hudson added a comment - SUCCESS: Integrated in hbase-0.96-hadoop2 #196 (See https://builds.apache.org/job/hbase-0.96-hadoop2/196/ ) HBASE-10340 [BACKPORT] HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1565546) /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java /hbase/branches/0.96/hbase-protocol/src/main/protobuf/HBase.proto /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java /hbase/branches/0.96/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.94 #1277 (See https://builds.apache.org/job/HBase-0.94/1277/)
          HBASE-10340 [BACKPORT] HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1565828)

          • /hbase/branches/0.94/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java
          • /hbase/branches/0.94/src/main/protobuf/hbase.proto
          • /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.94 #1277 (See https://builds.apache.org/job/HBase-0.94/1277/ ) HBASE-10340 [BACKPORT] HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1565828) /hbase/branches/0.94/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java /hbase/branches/0.94/src/main/protobuf/hbase.proto /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.94-security #404 (See https://builds.apache.org/job/HBase-0.94-security/404/)
          HBASE-10340 [BACKPORT] HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1565828)

          • /hbase/branches/0.94/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java
          • /hbase/branches/0.94/src/main/protobuf/hbase.proto
          • /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #404 (See https://builds.apache.org/job/HBase-0.94-security/404/ ) HBASE-10340 [BACKPORT] HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1565828) /hbase/branches/0.94/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java /hbase/branches/0.94/src/main/protobuf/hbase.proto /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #13 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/13/)
          HBASE-10340 [BACKPORT] HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1565828)

          • /hbase/branches/0.94/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java
          • /hbase/branches/0.94/src/main/protobuf/hbase.proto
          • /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #13 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/13/ ) HBASE-10340 [BACKPORT] HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1565828) /hbase/branches/0.94/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java /hbase/branches/0.94/src/main/protobuf/hbase.proto /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.94-JDK7 #42 (See https://builds.apache.org/job/HBase-0.94-JDK7/42/)
          HBASE-10340 [BACKPORT] HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1565828)

          • /hbase/branches/0.94/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java
          • /hbase/branches/0.94/src/main/protobuf/hbase.proto
          • /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.94-JDK7 #42 (See https://builds.apache.org/job/HBase-0.94-JDK7/42/ ) HBASE-10340 [BACKPORT] HBASE-9892 Add info port to ServerName to support multi instances in a node (stack: rev 1565828) /hbase/branches/0.94/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSDumpServlet.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java /hbase/branches/0.94/src/main/protobuf/hbase.proto /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp

            People

            • Assignee:
              Liu Shaohui
              Reporter:
              Liu Shaohui
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development