[HBASE-9867] Save on array copies with a subclass of LiteralByteString

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.96.0
• Fix Version/s: 0.98.0, 0.96.1
• Component/s: Protobufs
• Hadoop Flags: Reviewed
• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 31/Oct/13 03:58
• Updated: 16/Dec/13 18:46
• Resolved: 31/Oct/13 23:17

Description

Any time we add a byte array to a protobuf, it'll copy the byte array.

I was playing with the client and noticed how a bunch of CPU and copying was being done just to copy basic arrays doing pb construction. I started to look at ByteString and then remembered a class Benoit sent me a while back that I did not understand from his new AsyncHBase. After looking in ByteString it made now sense. So, rather than copy byte arrays everywhere, do a version of a ByteString that instead wraps the array.