HBase
  1. HBase
  2. HBASE-9849

[REST] Forbidden schema delete in read only mode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.0, 0.94.14
    • Fix Version/s: 0.98.0, 0.96.1, 0.94.14
    • Component/s: REST
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If "hbase.rest.readonly" was set, all write operations should be forbidden via REST, right? So table schema deletion should also be forbidden in readonly mode?

      1. 9849-trunk-v0.patch
        3 kB
        Julian Zhou
      2. 9849-0.94-v0.patch
        2 kB
        Julian Zhou

        Activity

        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.96-hadoop2 #119 (See https://builds.apache.org/job/hbase-0.96-hadoop2/119/)
        HBASE-9849 [REST] Forbidden schema delete in read only mode (Julian Zhou) (larsh: rev 1541643)

        • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.96-hadoop2 #119 (See https://builds.apache.org/job/hbase-0.96-hadoop2/119/ ) HBASE-9849 [REST] Forbidden schema delete in read only mode (Julian Zhou) (larsh: rev 1541643) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #837 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/837/)
        HBASE-9849 [REST] Forbidden schema delete in read only mode (Julian Zhou) (larsh: rev 1541644)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #837 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/837/ ) HBASE-9849 [REST] Forbidden schema delete in read only mode (Julian Zhou) (larsh: rev 1541644) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.96 #189 (See https://builds.apache.org/job/hbase-0.96/189/)
        HBASE-9849 [REST] Forbidden schema delete in read only mode (Julian Zhou) (larsh: rev 1541643)

        • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #189 (See https://builds.apache.org/job/hbase-0.96/189/ ) HBASE-9849 [REST] Forbidden schema delete in read only mode (Julian Zhou) (larsh: rev 1541643) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4680 (See https://builds.apache.org/job/HBase-TRUNK/4680/)
        HBASE-9849 [REST] Forbidden schema delete in read only mode (Julian Zhou) (larsh: rev 1541644)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4680 (See https://builds.apache.org/job/HBase-TRUNK/4680/ ) HBASE-9849 [REST] Forbidden schema delete in read only mode (Julian Zhou) (larsh: rev 1541644) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94 #1201 (See https://builds.apache.org/job/HBase-0.94/1201/)
        HBASE-9849 [REST] Forbidden schema delete in read only mode (Julian Zhou) (larsh: rev 1541642)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.94 #1201 (See https://builds.apache.org/job/HBase-0.94/1201/ ) HBASE-9849 [REST] Forbidden schema delete in read only mode (Julian Zhou) (larsh: rev 1541642) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94-security #335 (See https://builds.apache.org/job/HBase-0.94-security/335/)
        HBASE-9849 [REST] Forbidden schema delete in read only mode (Julian Zhou) (larsh: rev 1541642)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #335 (See https://builds.apache.org/job/HBase-0.94-security/335/ ) HBASE-9849 [REST] Forbidden schema delete in read only mode (Julian Zhou) (larsh: rev 1541642) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
        Hide
        Lars Hofhansl added a comment -

        Committed to all branches. Thanks Julian.

        Show
        Lars Hofhansl added a comment - Committed to all branches. Thanks Julian.
        Hide
        Lars Hofhansl added a comment -

        Andy is MIA
        I'll commit today.

        Show
        Lars Hofhansl added a comment - Andy is MIA I'll commit today.
        Hide
        Lars Hofhansl added a comment -

        +1
        Andrew Purtell, are you still planning to commit?

        Show
        Lars Hofhansl added a comment - +1 Andrew Purtell , are you still planning to commit?
        Hide
        Andrew Purtell added a comment -

        Sure, +1.

        Will commit soon if no concerns.

        Show
        Andrew Purtell added a comment - Sure, +1. Will commit soon if no concerns.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12610510/9849-trunk-v0.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 7 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12610510/9849-trunk-v0.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 7 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7657//console This message is automatically generated.

          People

          • Assignee:
            Julian Zhou
            Reporter:
            Julian Zhou
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development