HBase
  1. HBase
  2. HBASE-9770

HFilePerformanceEvaluation is using the wrong Comparator

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.98.0, 0.96.0
    • Fix Version/s: 0.98.0, 0.96.0
    • Component/s: test
    • Labels:
      None

      Description

      HBASE-9262 changed the default comparator but the HFilePerformanceEvaluation tool code was not changed. so now the results has errors...

      ...
      ERROR [main] hbase.KeyValue: Unexpected getShortMidpointKey result, fakeKey:0000387144, firstKeyInBlock:0000387144
      ERROR [main] hbase.KeyValue: Unexpected getShortMidpointKey result, fakeKey:0000387427, firstKeyInBlock:0000387427
      ERROR [main] hbase.KeyValue: Unexpected getShortMidpointKey result, fakeKey:0000387710, firstKeyInBlock:0000387710
      ...
      INFO  [0] hbase.HFilePerformanceEvaluation: Nonexistent row: 0000020825
      INFO  [0] hbase.HFilePerformanceEvaluation: Nonexistent row: 0000056693
      INFO  [0] hbase.HFilePerformanceEvaluation: Nonexistent row: 0000093565
      ...
      
      1. HBASE-9770-96-v0.patch
        0.6 kB
        Matteo Bertozzi
      2. HBASE-9770-trunk-v0.patch
        0.6 kB
        Matteo Bertozzi

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12608548/HBASE-9770-trunk-v0.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608548/HBASE-9770-trunk-v0.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7550//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        +1

        Show
        Ted Yu added a comment - +1
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4624 (See https://builds.apache.org/job/HBase-TRUNK/4624/)
        HBASE-9770 HFilePerformanceEvaluation is using the wrong Comparator (mbertozzi: rev 1532702)

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4624 (See https://builds.apache.org/job/HBase-TRUNK/4624/ ) HBASE-9770 HFilePerformanceEvaluation is using the wrong Comparator (mbertozzi: rev 1532702) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.96 #144 (See https://builds.apache.org/job/hbase-0.96/144/)
        HBASE-9770 HFilePerformanceEvaluation is using the wrong Comparator (mbertozzi: rev 1532701)

        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #144 (See https://builds.apache.org/job/hbase-0.96/144/ ) HBASE-9770 HFilePerformanceEvaluation is using the wrong Comparator (mbertozzi: rev 1532701) /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96-hadoop2 #90 (See https://builds.apache.org/job/hbase-0.96-hadoop2/90/)
        HBASE-9770 HFilePerformanceEvaluation is using the wrong Comparator (mbertozzi: rev 1532701)

        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #90 (See https://builds.apache.org/job/hbase-0.96-hadoop2/90/ ) HBASE-9770 HFilePerformanceEvaluation is using the wrong Comparator (mbertozzi: rev 1532701) /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #796 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/796/)
        HBASE-9770 HFilePerformanceEvaluation is using the wrong Comparator (mbertozzi: rev 1532702)

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #796 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/796/ ) HBASE-9770 HFilePerformanceEvaluation is using the wrong Comparator (mbertozzi: rev 1532702) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java

          People

          • Assignee:
            Matteo Bertozzi
            Reporter:
            Matteo Bertozzi
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development