Why did you remove the 'force' option?
Actually, this method was always called with force as true. There are two methods: one w/o force, once w/ force.
Nit: the new value for START_LOG_ERRORS_CNT is 4, not 3. Was this intentional?
I may have a bug here: I want to log the retries > 3 and log the sucess > 4. This way if I log an error I will also log the result of the next attempt.
I see nbRegion never crossed your mind
Is the test failure related?
I don't thinks so. I will retry locally.
I suppose per-server limit makes sense. 5 outstanding requests seems low though. 10?
I will double check the code, but the intent is to have by default:
- we contact at most 100 servers
- we don't send more then 1 request per region
- we don't send more than different 5 requests to the same region servers (but a single request can be about 20 different regions). So with 5 we're already taking 5 handlers out of the 30.
As well, if we reach the limit per region or per region server, we still send the puts to the other region servers, until we reach the global limit of 100. So we will be able to customize a lot the behavior of the client (for example a map reduce client could be limited to one request per region server).
I will double check all this and commit tomorrow morning my time if it's trivial. Thanks for the reviews, Nick and Stack.