Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-9667

NullOutputStream removed from Guava 15

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.98.0, 0.94.12, 0.96.1
    • Fix Version/s: 0.98.0, 0.96.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      com.google.common.io.NullOutputStream was dropped in Guava 15.0 in favor of com.google.common.io.ByteStreams.nullOutputStream() which prevents projects on this artifact from upgrading from Guava 14 to Guava 15.

      ERROR 2013-09-26 17:46:12,229 [hbase.master.MasterFileSystem] bootstrap
      org.apache.hadoop.hbase.DroppedSnapshotException: region: -ROOT-,,0
              at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1608)
              at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1482)
              at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1011)
              at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:959)
              at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:930)
              at org.apache.hadoop.hbase.master.MasterFileSystem.bootstrap(MasterFileSystem.java:447)
              at org.apache.hadoop.hbase.master.MasterFileSystem.checkRootDir(MasterFileSystem.java:387)
              at org.apache.hadoop.hbase.master.MasterFileSystem.createInitialFileSystemLayout(MasterFileSystem.java:134)
              at org.apache.hadoop.hbase.master.MasterFileSystem.<init>(MasterFileSystem.java:119)
              at org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:536)
              at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:395)
              at java.lang.Thread.run(Thread.java:680)
      Caused by: java.lang.NoClassDefFoundError: com/google/common/io/NullOutputStream
              at org.apache.hadoop.hbase.io.hfile.HFileWriterV2.close(HFileWriterV2.java:374)
              at org.apache.hadoop.hbase.regionserver.StoreFile$Writer.close(StoreFile.java:1283)
              at org.apache.hadoop.hbase.regionserver.Store.internalFlushCache(Store.java:836)
              at org.apache.hadoop.hbase.regionserver.Store.flushCache(Store.java:747)
              at org.apache.hadoop.hbase.regionserver.Store$StoreFlusherImpl.flushCache(Store.java:2229)
              at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1583)
              ... 11 more
      Caused by: java.lang.ClassNotFoundException: com.google.common.io.NullOutputStream
              at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
              at java.security.AccessController.doPrivileged(Native Method)
              at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
              at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
              at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
              at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
              ... 17 more
      
      1. 9667.v1.patch
        10 kB
        Nicolas Liochon
      2. 9667.v2.patch
        11 kB
        Nicolas Liochon
      3. 9667.v3.patch
        11 kB
        Nicolas Liochon

        Issue Links

          Activity

          Hide
          nkeywal Nicolas Liochon added a comment -

          The issue is that the javadoc says for nullOutputStream : Since 14.0 (since 1.0 as com.google.common.io.NullOutputStream)
          So we would have to upgrade to guava 14 and people will be able to use guava 15, but then people using version 11 will have to upgrade, upgrade their third parties that depends on that old version.

          For 0.94 it seems to be an issue. For 0.96 it is possible, if it doesn't mess with hadoop common who uses guava as well.
          Note that the issue may be less critical in 0.96: the code using NullOutputStream is in hbase-server, not hbase client, so upgrading guava would work.

          The other option being to stop using both NullOutputStream and nullOutputStream. This would work in 0.94 as well.

          btw, Matt Greenfield, what's the version of HBase you're using? I don't see NullOutputStream referenced in HFileWriterV2 in 0.94 head.

          Show
          nkeywal Nicolas Liochon added a comment - The issue is that the javadoc says for nullOutputStream : Since 14.0 (since 1.0 as com.google.common.io.NullOutputStream) So we would have to upgrade to guava 14 and people will be able to use guava 15, but then people using version 11 will have to upgrade, upgrade their third parties that depends on that old version. For 0.94 it seems to be an issue. For 0.96 it is possible, if it doesn't mess with hadoop common who uses guava as well. Note that the issue may be less critical in 0.96: the code using NullOutputStream is in hbase-server, not hbase client, so upgrading guava would work. The other option being to stop using both NullOutputStream and nullOutputStream. This would work in 0.94 as well. btw, Matt Greenfield , what's the version of HBase you're using? I don't see NullOutputStream referenced in HFileWriterV2 in 0.94 head.
          Hide
          nkeywal Nicolas Liochon added a comment -

          I was wrong, some of them are in hbase-common, so visible from the client. So the issue is real in .96 as well. Marking critical.

          Show
          nkeywal Nicolas Liochon added a comment - I was wrong, some of them are in hbase-common, so visible from the client. So the issue is real in .96 as well. Marking critical.
          Hide
          nkeywal Nicolas Liochon added a comment -

          If I can rely on http://code.google.com/p/guava-libraries/wiki/ReleaseHistory, these guava guys are not joking: v13 was in august 2012; in v14 (feb 1013) they deprecated a feature and offered and replacement. In September 2013 they removed the old feature => it's impossible to have a client depending on 3 versions that came into just a year. If it's confirmed, we will have to pay extra attention each time we use this library, this is just not compatible with our timeframes.

          So I found 3 compilation issue when using guava 15:

          • NullOutputStream -> there is one in org.apache.hadoop.io. Easy.
          • LimitInputStream -> copy paste into hbase code base. Their Apache license allows that.
          • MapMaker -> Replaced with a concurrent map. See http://code.google.com/p/guava-libraries/wiki/MapMakerMigration: At first glance this behavior is tremendously useful, but the specific implementation of this functionality behind a plain ConcurrentMap was riddled with issues. Having a Map that auto-creates entries on get was simply a big mistake. Pinging Elliott Clark on this one as it may have in impact on performances.

          The patch is with guava 15 to check how it behaves, but I plan to keep the current version in our pom as hadoop 2.1 is on v11.0.2 (which is far too old as well, but imho it's better to limit the gap for the moment).

          Note that nothing guarantees us that we won't break our compatibility with guava 15 in a later patch.

          Show
          nkeywal Nicolas Liochon added a comment - If I can rely on http://code.google.com/p/guava-libraries/wiki/ReleaseHistory , these guava guys are not joking: v13 was in august 2012; in v14 (feb 1013) they deprecated a feature and offered and replacement. In September 2013 they removed the old feature => it's impossible to have a client depending on 3 versions that came into just a year. If it's confirmed, we will have to pay extra attention each time we use this library, this is just not compatible with our timeframes. So I found 3 compilation issue when using guava 15: NullOutputStream -> there is one in org.apache.hadoop.io. Easy. LimitInputStream -> copy paste into hbase code base. Their Apache license allows that. MapMaker -> Replaced with a concurrent map. See http://code.google.com/p/guava-libraries/wiki/MapMakerMigration: At first glance this behavior is tremendously useful, but the specific implementation of this functionality behind a plain ConcurrentMap was riddled with issues. Having a Map that auto-creates entries on get was simply a big mistake. Pinging Elliott Clark on this one as it may have in impact on performances. The patch is with guava 15 to check how it behaves, but I plan to keep the current version in our pom as hadoop 2.1 is on v11.0.2 (which is far too old as well, but imho it's better to limit the gap for the moment). Note that nothing guarantees us that we won't break our compatibility with guava 15 in a later patch.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12606070/9667.v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

          -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestAsyncProcess

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7427//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7427//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7427//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12606070/9667.v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to cause Findbugs (version 1.3.9) to fail. -1 release audit . The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestAsyncProcess Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7427//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7427//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7427//console This message is automatically generated.
          Hide
          nkeywal Nicolas Liochon added a comment -

          TestAsyncProcess.testThreadCreation is a flaky test I fixed in HBASE-9676.
          javadoc tool appears to have generated 1 warning messages: seems unrelated.
          -1 release audit. I forgot the Apache license in v1. Fixed in v2.

          So it seems that it works well with Guava 15. Version v2 fixed the warning above w/o changing the guava version.

          Hadoop branch 2 does have the same problems as hbase, but only on Journal and in the tests. So we will be fine.

          Show
          nkeywal Nicolas Liochon added a comment - TestAsyncProcess.testThreadCreation is a flaky test I fixed in HBASE-9676 . javadoc tool appears to have generated 1 warning messages: seems unrelated. -1 release audit. I forgot the Apache license in v1. Fixed in v2. So it seems that it works well with Guava 15. Version v2 fixed the warning above w/o changing the guava version. Hadoop branch 2 does have the same problems as hbase, but only on Journal and in the tests. So we will be fine.
          Hide
          mdgreenfield Matt Greenfield added a comment -

          Nicolas Liochon, we are running 0.94.6 (0.94.6-cdh4.3.0-00018943 to be exact)

          Show
          mdgreenfield Matt Greenfield added a comment - Nicolas Liochon , we are running 0.94.6 (0.94.6-cdh4.3.0-00018943 to be exact)
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12606094/9667.v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12606094/9667.v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7428//console This message is automatically generated.
          Hide
          nkeywal Nicolas Liochon added a comment -

          Any +1 on this one?

          Show
          nkeywal Nicolas Liochon added a comment - Any +1 on this one?
          Hide
          eclark Elliott Clark added a comment -

          Looking right now.

          Show
          eclark Elliott Clark added a comment - Looking right now.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Patch looks good.

          + * allows to be compatible with guava 15 to 15.
          

          Should the first 15 be 14 ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Patch looks good. + * allows to be compatible with guava 15 to 15. Should the first 15 be 14 ?
          Hide
          nkeywal Nicolas Liochon added a comment -

          Should the first 15 be 14 ?

          11 to 15 actually. I will fix this on commit.

          Show
          nkeywal Nicolas Liochon added a comment - Should the first 15 be 14 ? 11 to 15 actually. I will fix this on commit.
          Hide
          eclark Elliott Clark added a comment -

          +1

          ExactCounterMetric will be deprecated in 0.96 and is completely un-used to my knowledge. We should remove it in trunk, but this should make 0.96 more flexible. Thanks

          Show
          eclark Elliott Clark added a comment - +1 ExactCounterMetric will be deprecated in 0.96 and is completely un-used to my knowledge. We should remove it in trunk, but this should make 0.96 more flexible. Thanks
          Hide
          nkeywal Nicolas Liochon added a comment -

          Thanks for the reviews, Ted & Elliott. Actually, NullOutputStream is not available in hadoop branch 1.0. While trunk depends on 1.2, 0.96 is still with 1.0.4, so I need to include this class as well...

          Show
          nkeywal Nicolas Liochon added a comment - Thanks for the reviews, Ted & Elliott. Actually, NullOutputStream is not available in hadoop branch 1.0. While trunk depends on 1.2, 0.96 is still with 1.0.4, so I need to include this class as well...
          Hide
          nkeywal Nicolas Liochon added a comment -

          with the NullOutputStream from common-io at the end.

          Show
          nkeywal Nicolas Liochon added a comment - with the NullOutputStream from common-io at the end.
          Hide
          nkeywal Nicolas Liochon added a comment -

          committed to trunk & .96, thanks Elliott & Ted.

          Show
          nkeywal Nicolas Liochon added a comment - committed to trunk & .96, thanks Elliott & Ted.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12606388/9667.v3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12606388/9667.v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7445//console This message is automatically generated.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in hbase-0.96 #116 (See https://builds.apache.org/job/hbase-0.96/116/)
          HBASE-9667 NullOutputStream removed from Guava 15 (nkeywal: rev 1528574)

          • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
          • /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java
          • /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/ExactCounterMetric.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #116 (See https://builds.apache.org/job/hbase-0.96/116/ ) HBASE-9667 NullOutputStream removed from Guava 15 (nkeywal: rev 1528574) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/ExactCounterMetric.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #4584 (See https://builds.apache.org/job/HBase-TRUNK/4584/)
          HBASE-9667 NullOutputStream removed from Guava 15 (nkeywal: rev 1528573)

          • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
          • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java
          • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/ExactCounterMetric.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4584 (See https://builds.apache.org/job/HBase-TRUNK/4584/ ) HBASE-9667 NullOutputStream removed from Guava 15 (nkeywal: rev 1528573) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/ExactCounterMetric.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #773 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/773/)
          HBASE-9667 NullOutputStream removed from Guava 15 (nkeywal: rev 1528573)

          • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
          • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java
          • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/ExactCounterMetric.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #773 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/773/ ) HBASE-9667 NullOutputStream removed from Guava 15 (nkeywal: rev 1528573) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/ExactCounterMetric.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in hbase-0.96-hadoop2 #70 (See https://builds.apache.org/job/hbase-0.96-hadoop2/70/)
          HBASE-9667 NullOutputStream removed from Guava 15 (nkeywal: rev 1528574)

          • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
          • /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java
          • /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/ExactCounterMetric.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #70 (See https://builds.apache.org/job/hbase-0.96-hadoop2/70/ ) HBASE-9667 NullOutputStream removed from Guava 15 (nkeywal: rev 1528574) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/ExactCounterMetric.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
          Hide
          viralbajaria Viral Bajaria added a comment -

          Given this was reported on 0.94.x, are we going to have a patch for that ? Or should I just create one based on the files that are modified here and attach it here ?

          Show
          viralbajaria Viral Bajaria added a comment - Given this was reported on 0.94.x, are we going to have a patch for that ? Or should I just create one based on the files that are modified here and attach it here ?
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          @Viral:
          See HBASE-10174

          Show
          yuzhihong@gmail.com Ted Yu added a comment - @Viral: See HBASE-10174
          Hide
          lars_francke Lars Francke added a comment -

          This issue was closed as part of a bulk closing operation on 2015-11-20. All issues that have been resolved and where all fixVersions have been released have been closed (following discussions on the mailing list).

          Show
          lars_francke Lars Francke added a comment - This issue was closed as part of a bulk closing operation on 2015-11-20. All issues that have been resolved and where all fixVersions have been released have been closed (following discussions on the mailing list).

            People

            • Assignee:
              nkeywal Nicolas Liochon
              Reporter:
              mdgreenfield Matt Greenfield
            • Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development