Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-9661

Consistent log severity level guards and statements

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.98.0, 0.96.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      A log statement should be guarded by its matching severity level. A log statement like

      if (LOG.isTraceEnabled()) {
      LOG.debug(identifier + " opening connection to ZooKeeper ensemble=" + ensemble);

      doesn't make much sense because the log message is only printed out when TRACE-level is enabled. This inconsistency was possibly introduced when developers demoted the original log statement from DEBUG but forgot to change its corresponding log severity level.

        Attachments

        1. HBASE-9661.patch
          1 kB
          Jackie Chang

          Activity

            People

            • Assignee:
              jackie.chang Jackie Chang
              Reporter:
              jackie.chang Jackie Chang
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: