HBase
  1. HBase
  2. HBASE-9647

Add a test in TestAsyncProcess to check the number of threads created

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.0, 0.96.0
    • Fix Version/s: 0.98.0, 0.96.0
    • Component/s: Client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. 9333.v1.patch
      7 kB
      Nicolas Liochon

      Activity

      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12604844/9333.v1.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

      +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 site. The mvn site goal succeeds with this patch.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.regionserver.wal.TestLogRolling

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12604844/9333.v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestLogRolling Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7357//console This message is automatically generated.
      Hide
      Nick Dimiduk added a comment -

      nit: ws.

      +    static class CountingThreadFactory implements ThreadFactory{
                                                                      ^
      

      For my own education, what is the meaning of the "nb" prefix in variable names, such as nbMultiResponse and nbActions? You use it consistently for Atomic instances.

      +1

      Show
      Nick Dimiduk added a comment - nit: ws. + static class CountingThreadFactory implements ThreadFactory{ ^ For my own education, what is the meaning of the "nb" prefix in variable names, such as nbMultiResponse and nbActions ? You use it consistently for Atomic instances. +1
      Hide
      Nicolas Liochon added a comment -

      meaning of the "nb" prefix in variable names

      It's for number ("number of"). It seems to be a pure French abbreviation for "nombre" actually (http://fr.wikipedia.org/wiki/NB). I will use "ct" from now on

      Thanks for the review, Nick. I will fix the ws and commit.

      Show
      Nicolas Liochon added a comment - meaning of the "nb" prefix in variable names It's for number ("number of"). It seems to be a pure French abbreviation for "nombre" actually ( http://fr.wikipedia.org/wiki/NB ). I will use "ct" from now on Thanks for the review, Nick. I will fix the ws and commit.
      Hide
      Nick Dimiduk added a comment -

      Ah! I've seen this in JD's code too... My native-English brain would use actionsCnt instead. No need to change, just curious.

      Show
      Nick Dimiduk added a comment - Ah! I've seen this in JD's code too... My native-English brain would use actionsCnt instead. No need to change, just curious.
      Hide
      Nicolas Liochon added a comment -

      Committed to trunk & .96, thanks for the review and for improving my English Nick

      Show
      Nicolas Liochon added a comment - Committed to trunk & .96, thanks for the review and for improving my English Nick
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in HBase-TRUNK #4568 (See https://builds.apache.org/job/HBase-TRUNK/4568/)
      HBASE-9647 Add a test in TestAsyncProcess to check the number of threads created (nkeywal: rev 1526828)

      • /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
      Show
      Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4568 (See https://builds.apache.org/job/HBase-TRUNK/4568/ ) HBASE-9647 Add a test in TestAsyncProcess to check the number of threads created (nkeywal: rev 1526828) /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in hbase-0.96 #101 (See https://builds.apache.org/job/hbase-0.96/101/)
      HBASE-9647 Add a test in TestAsyncProcess to check the number of threads created (nkeywal: rev 1526829)

      • /hbase/branches/0.96/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
      Show
      Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #101 (See https://builds.apache.org/job/hbase-0.96/101/ ) HBASE-9647 Add a test in TestAsyncProcess to check the number of threads created (nkeywal: rev 1526829) /hbase/branches/0.96/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in hbase-0.96-hadoop2 #61 (See https://builds.apache.org/job/hbase-0.96-hadoop2/61/)
      HBASE-9647 Add a test in TestAsyncProcess to check the number of threads created (nkeywal: rev 1526829)

      • /hbase/branches/0.96/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
      Show
      Hudson added a comment - SUCCESS: Integrated in hbase-0.96-hadoop2 #61 (See https://builds.apache.org/job/hbase-0.96-hadoop2/61/ ) HBASE-9647 Add a test in TestAsyncProcess to check the number of threads created (nkeywal: rev 1526829) /hbase/branches/0.96/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
      Hide
      Hudson added a comment -

      FAILURE: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #765 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/765/)
      HBASE-9647 Add a test in TestAsyncProcess to check the number of threads created (nkeywal: rev 1526828)

      • /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
      Show
      Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #765 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/765/ ) HBASE-9647 Add a test in TestAsyncProcess to check the number of threads created (nkeywal: rev 1526828) /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java

        People

        • Assignee:
          Nicolas Liochon
          Reporter:
          Nicolas Liochon
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development