Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-9445

Snapshots should create column family dirs for empty regions

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0, 0.98.3
    • Component/s: snapshots
    • Labels:
      None

      Description

      Currently, taking a snapshot will not create the family directory under a region if the family does not have any files in it.

      Subsequent verification fails because of this. There is some logic in the SnapshotTestingUtils.confirmSnapshotValid() to deal with empty family directories, but I think we should create the family directories regardless of whether there are any hfiles referencing them.

      2013-09-05 11:07:21,566 DEBUG [Thread-208] util.FSUtils(1687): |-data/
      2013-09-05 11:07:21,567 DEBUG [Thread-208] util.FSUtils(1687): |----default/
      2013-09-05 11:07:21,568 DEBUG [Thread-208] util.FSUtils(1687): |-------test/
      2013-09-05 11:07:21,569 DEBUG [Thread-208] util.FSUtils(1687): |----------.tabledesc/
      2013-09-05 11:07:21,570 DEBUG [Thread-208] util.FSUtils(1690): |-------------.tableinfo.0000000001
      2013-09-05 11:07:21,570 DEBUG [Thread-208] util.FSUtils(1687): |----------.tmp/
      2013-09-05 11:07:21,571 DEBUG [Thread-208] util.FSUtils(1687): |----------accd6e55887057888de758df44dacda7/
      2013-09-05 11:07:21,572 DEBUG [Thread-208] util.FSUtils(1690): |-------------.regioninfo
      2013-09-05 11:07:21,572 DEBUG [Thread-208] util.FSUtils(1687): |-------------fam/
      
      2013-09-05 11:07:21,555 DEBUG [Thread-208] util.FSUtils(1687): |-.hbase-snapshot/
      2013-09-05 11:07:21,556 DEBUG [Thread-208] util.FSUtils(1687): |----.tmp/
      2013-09-05 11:07:21,557 DEBUG [Thread-208] util.FSUtils(1687): |----offlineTableSnapshot/
      2013-09-05 11:07:21,558 DEBUG [Thread-208] util.FSUtils(1690): |-------.snapshotinfo
      2013-09-05 11:07:21,558 DEBUG [Thread-208] util.FSUtils(1687): |-------.tabledesc/
      2013-09-05 11:07:21,558 DEBUG [Thread-208] util.FSUtils(1690): |----------.tableinfo.0000000001
      2013-09-05 11:07:21,559 DEBUG [Thread-208] util.FSUtils(1687): |-------.tmp/
      2013-09-05 11:07:21,559 DEBUG [Thread-208] util.FSUtils(1687): |-------accd6e55887057888de758df44dacda7/
      2013-09-05 11:07:21,560 DEBUG [Thread-208] util.FSUtils(1690): |----------.regioninfo
      

      I think this is important for 0.96.0.

        Attachments

        1. hbase-9445_v1.patch
          6 kB
          Enis Soztutar
        2. hbase-9445_v2.patch
          8 kB
          Enis Soztutar
        3. hbase-9445_v3.patch
          5 kB
          Enis Soztutar
        4. hbase-9445_v4.patch
          8 kB
          Enis Soztutar

          Activity

            People

            • Assignee:
              enis Enis Soztutar
              Reporter:
              enis Enis Soztutar
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: