HBase
  1. HBase
  2. HBASE-9121

Update HTrace to 2.00 and add new example usage.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.95.1
    • Fix Version/s: 0.98.0, 0.95.2
    • Component/s: None
    • Labels:
      None
    • Release Note:
      Updated to HTrace 2.00.
    • Tags:
      0.96notable

      Description

      Update HTrace to 2.00. This adds maven modularization so the client doesn't need all of HTraces dependencies.

      Also while changing to the new api I added some new very small ammounts of tracing around ZK and HFileReaderv2.

      1. HBASE-9121-0.patch
        63 kB
        Elliott Clark
      2. HBASE-9121-1.patch
        63 kB
        Elliott Clark
      3. HBASE-9121-2.patch
        64 kB
        Elliott Clark
      4. HBASE-9121-PRE.patch
        64 kB
        Elliott Clark
      5. Zipkin Trace c49e8c79b9555d62.png
        245 kB
        Elliott Clark

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        6d 32m 1 Elliott Clark 08/Aug/13 22:03
        Patch Available Patch Available Resolved Resolved
        6d 2h 26m 1 Elliott Clark 15/Aug/13 00:30
        Resolved Resolved Closed Closed
        39d 19h 52m 1 stack 23/Sep/13 20:22
        stack made changes -
        Tags 0.96notable
        stack made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.95-on-hadoop2 #243 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/243/)
        HBASE-9121 Update HTrace to 2.00 and add new example usage. – ADD (eclark: rev 1514130)

        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.95-on-hadoop2 #243 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/243/ ) HBASE-9121 Update HTrace to 2.00 and add new example usage. – ADD (eclark: rev 1514130) /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.95 #450 (See https://builds.apache.org/job/hbase-0.95/450/)
        HBASE-9121 Update HTrace to 2.00 and add new example usage. – ADD (eclark: rev 1514130)

        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.95 #450 (See https://builds.apache.org/job/hbase-0.95/450/ ) HBASE-9121 Update HTrace to 2.00 and add new example usage. – ADD (eclark: rev 1514130) /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.95 #449 (See https://builds.apache.org/job/hbase-0.95/449/)
        HBASE-9121 Update HTrace to 2.00 and add new example usage. – Part2 (eclark: rev 1514093)

        • /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/trace
        • /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseHTraceConfiguration.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseLocalFileSpanReceiver.java
          HBASE-9121 Update HTrace to 2.00 and add new example usage. (eclark: rev 1514092)
        • /hbase/branches/0.95/hbase-client/pom.xml
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • /hbase/branches/0.95/hbase-it/pom.xml
        • /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java
        • /hbase/branches/0.95/hbase-server/pom.xml
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RequestContext.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/trace/TestHTraceHooks.java
        • /hbase/branches/0.95/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.95 #449 (See https://builds.apache.org/job/hbase-0.95/449/ ) HBASE-9121 Update HTrace to 2.00 and add new example usage. – Part2 (eclark: rev 1514093) /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/trace /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseHTraceConfiguration.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseLocalFileSpanReceiver.java HBASE-9121 Update HTrace to 2.00 and add new example usage. (eclark: rev 1514092) /hbase/branches/0.95/hbase-client/pom.xml /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java /hbase/branches/0.95/hbase-it/pom.xml /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java /hbase/branches/0.95/hbase-server/pom.xml /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RequestContext.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/trace/TestHTraceHooks.java /hbase/branches/0.95/pom.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4391 (See https://builds.apache.org/job/HBase-TRUNK/4391/)
        HBASE-9121 Update HTrace to 2.00 and add new example usage. – Part2 (eclark: rev 1514094)

        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/trace
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseHTraceConfiguration.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseLocalFileSpanReceiver.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4391 (See https://builds.apache.org/job/HBase-TRUNK/4391/ ) HBASE-9121 Update HTrace to 2.00 and add new example usage. – Part2 (eclark: rev 1514094) /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/trace /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseHTraceConfiguration.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseLocalFileSpanReceiver.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #676 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/676/)
        HBASE-9121 Update HTrace to 2.00 and add new example usage. – Part2 (eclark: rev 1514094)

        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/trace
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseHTraceConfiguration.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseLocalFileSpanReceiver.java
          HBASE-9121 Update HTrace to 2.00 and add new example usage. (eclark: rev 1514091)
        • /hbase/trunk/hbase-client/pom.xml
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • /hbase/trunk/hbase-it/pom.xml
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java
        • /hbase/trunk/hbase-server/pom.xml
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RequestContext.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/trace/TestHTraceHooks.java
        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #676 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/676/ ) HBASE-9121 Update HTrace to 2.00 and add new example usage. – Part2 (eclark: rev 1514094) /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/trace /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseHTraceConfiguration.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseLocalFileSpanReceiver.java HBASE-9121 Update HTrace to 2.00 and add new example usage. (eclark: rev 1514091) /hbase/trunk/hbase-client/pom.xml /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java /hbase/trunk/hbase-it/pom.xml /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java /hbase/trunk/hbase-server/pom.xml /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RequestContext.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/trace/TestHTraceHooks.java /hbase/trunk/pom.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.95-on-hadoop2 #242 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/242/)
        HBASE-9121 Update HTrace to 2.00 and add new example usage. – Part2 (eclark: rev 1514093)

        • /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/trace
        • /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseHTraceConfiguration.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseLocalFileSpanReceiver.java
          HBASE-9121 Update HTrace to 2.00 and add new example usage. (eclark: rev 1514092)
        • /hbase/branches/0.95/hbase-client/pom.xml
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • /hbase/branches/0.95/hbase-it/pom.xml
        • /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java
        • /hbase/branches/0.95/hbase-server/pom.xml
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RequestContext.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/trace/TestHTraceHooks.java
        • /hbase/branches/0.95/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.95-on-hadoop2 #242 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/242/ ) HBASE-9121 Update HTrace to 2.00 and add new example usage. – Part2 (eclark: rev 1514093) /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/trace /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseHTraceConfiguration.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/HBaseLocalFileSpanReceiver.java HBASE-9121 Update HTrace to 2.00 and add new example usage. (eclark: rev 1514092) /hbase/branches/0.95/hbase-client/pom.xml /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java /hbase/branches/0.95/hbase-it/pom.xml /hbase/branches/0.95/hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java /hbase/branches/0.95/hbase-server/pom.xml /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RequestContext.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/trace/TestHTraceHooks.java /hbase/branches/0.95/pom.xml
        Elliott Clark made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Release Note Updated to HTrace 2.00.
        Resolution Fixed [ 1 ]
        Hide
        Elliott Clark added a comment -

        Comitted

        Show
        Elliott Clark added a comment - Comitted
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #4390 (See https://builds.apache.org/job/HBase-TRUNK/4390/)
        HBASE-9121 Update HTrace to 2.00 and add new example usage. (eclark: rev 1514091)

        • /hbase/trunk/hbase-client/pom.xml
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • /hbase/trunk/hbase-it/pom.xml
        • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java
        • /hbase/trunk/hbase-server/pom.xml
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RequestContext.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/trace/TestHTraceHooks.java
        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4390 (See https://builds.apache.org/job/HBase-TRUNK/4390/ ) HBASE-9121 Update HTrace to 2.00 and add new example usage. (eclark: rev 1514091) /hbase/trunk/hbase-client/pom.xml /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java /hbase/trunk/hbase-it/pom.xml /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java /hbase/trunk/hbase-server/pom.xml /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RequestContext.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/trace/SpanReceiverHost.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/trace/TestHTraceHooks.java /hbase/trunk/pom.xml
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12597533/HBASE-9121-2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 10 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 3 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12597533/HBASE-9121-2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 10 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 3 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6705//console This message is automatically generated.
        Elliott Clark made changes -
        Attachment HBASE-9121-2.patch [ 12597533 ]
        Hide
        Elliott Clark added a comment -

        We have to have this in hbase-client?

        Yep. The client uses htrace to see if there are any currently running traces that need to be attached to RPC calls as they are sent over the wire.

        Missing license:

        Fixed.

        This is removed because it is just useless --> HBaseLocalFileSpanReceiver?

        That functionality is duplicated in HTrace. No need to have extra code.

        Show
        Elliott Clark added a comment - We have to have this in hbase-client? Yep. The client uses htrace to see if there are any currently running traces that need to be attached to RPC calls as they are sent over the wire. Missing license: Fixed. This is removed because it is just useless --> HBaseLocalFileSpanReceiver? That functionality is duplicated in HTrace. No need to have extra code.
        Hide
        stack added a comment -

        We have to have this in hbase-client?

        + <groupId>org.cloudera.htrace</groupId>
        + <artifactId>htrace-zipkin</artifactId>

        Missing license:

        IntegrationTestSendTraceRequests.java

        Man, what is an AbstractHBaseTool? Could it hurt someone?

        This is removed because it is just useless --> HBaseLocalFileSpanReceiver?

        Big +1 after above are addressed and caveat getting Andrew's ok to commit up on dev list. This tool is great especially for the insight on where time is spent recovering (w/ other spans to be introduced later). Excellent E.

        Show
        stack added a comment - We have to have this in hbase-client? + <groupId>org.cloudera.htrace</groupId> + <artifactId>htrace-zipkin</artifactId> Missing license: IntegrationTestSendTraceRequests.java Man, what is an AbstractHBaseTool? Could it hurt someone? This is removed because it is just useless --> HBaseLocalFileSpanReceiver? Big +1 after above are addressed and caveat getting Andrew's ok to commit up on dev list. This tool is great especially for the insight on where time is spent recovering (w/ other spans to be introduced later). Excellent E.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12596986/HBASE-9121-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 10 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 20 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        -1 core tests. The patch failed these unit tests:

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12596986/HBASE-9121-1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 10 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 20 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6670//console This message is automatically generated.
        Elliott Clark made changes -
        Attachment HBASE-9121-1.patch [ 12596986 ]
        Hide
        Elliott Clark added a comment -

        Had old zipkin stuff in the config. Removed that.

        Show
        Elliott Clark added a comment - Had old zipkin stuff in the config. Removed that.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12596940/HBASE-9121-0.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 10 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 18 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.trace.TestHTraceHooks

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12596940/HBASE-9121-0.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 10 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 18 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.trace.TestHTraceHooks Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6661//console This message is automatically generated.
        Hide
        Elliott Clark added a comment -

        Nick Dimiduk Twitter does have something that's like htrace that will instrument threads and rpc requests. However it's scala specific, and targeted only at Finagle with thrift. [1] So it's not really something that we can use. HTrace is great because it's all java, has very few dependencies that we don't already use and is pretty easy to rev quickly if needed ( Todd Lipcon and I both have perms ).

        1. https://github.com/twitter/finagle/tree/master/finagle-zipkin/src/main

        Show
        Elliott Clark added a comment - Nick Dimiduk Twitter does have something that's like htrace that will instrument threads and rpc requests. However it's scala specific, and targeted only at Finagle with thrift. [1] So it's not really something that we can use. HTrace is great because it's all java, has very few dependencies that we don't already use and is pretty easy to rev quickly if needed ( Todd Lipcon and I both have perms ). 1. https://github.com/twitter/finagle/tree/master/finagle-zipkin/src/main
        Elliott Clark made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s 0.98.0 [ 12323143 ]
        Fix Version/s 0.95.2 [ 12320040 ]
        Elliott Clark made changes -
        Attachment HBASE-9121-0.patch [ 12596940 ]
        Hide
        Elliott Clark added a comment -

        Patch.

        Show
        Elliott Clark added a comment - Patch.
        Elliott Clark made changes -
        Attachment Zipkin Trace c49e8c79b9555d62.png [ 12596939 ]
        Hide
        Elliott Clark added a comment -

        Better Screenshot.

        Show
        Elliott Clark added a comment - Better Screenshot.
        Elliott Clark made changes -
        Attachment Zipkin - Trace 536c785021658f1d.png [ 12595714 ]
        Elliott Clark made changes -
        Description Add tracing to zk, hfile reader, and hlog. Update HTrace to 2.00. This adds maven modularization so the client doesn't need all of HTraces dependencies.

        Also while changing to the new api I added some new very small ammounts of tracing around ZK and HFileReaderv2.
        Elliott Clark made changes -
        Summary Add tracing into interesting parts of HBase Update HTrace to 2.00 and add new example usage.
        Hide
        Nick Dimiduk added a comment -

        Ah yes, it's the SpanReceiver I was missing. I would have thought Zipkin provides that.

        Show
        Nick Dimiduk added a comment - Ah yes, it's the SpanReceiver I was missing. I would have thought Zipkin provides that.
        Hide
        stack added a comment -
        Show
        stack added a comment - Nick Dimiduk Does this help http://hbase.apache.org/book.html#tracing ?
        Hide
        Nick Dimiduk added a comment -

        These are not sufficient? Maybe there's more to it thank I understood.

        Show
        Nick Dimiduk added a comment - These are not sufficient? Maybe there's more to it thank I understood.
        Hide
        Elliott Clark added a comment -

        HTrace is used inside of HBase to track what trace/span is currently being worked on. Tracking span id an annotations even as there are thread changes and RPC calls are exchanged.

        Zipkin is used to collect, index, and display the traces. It doesn't have any hooks to trace rpcs or collect annotations that would work with HBase or Hadoop.

        Show
        Elliott Clark added a comment - HTrace is used inside of HBase to track what trace/span is currently being worked on. Tracking span id an annotations even as there are thread changes and RPC calls are exchanged. Zipkin is used to collect, index, and display the traces. It doesn't have any hooks to trace rpcs or collect annotations that would work with HBase or Hadoop.
        Hide
        Nick Dimiduk added a comment -

        Now you're talking! I guess I don't understand the HTrace business then. Why not s/htrace/zipkin?

        Show
        Nick Dimiduk added a comment - Now you're talking! I guess I don't understand the HTrace business then. Why not s/htrace/zipkin?
        Elliott Clark made changes -
        Attachment Zipkin - Trace 536c785021658f1d.png [ 12595714 ]
        Hide
        Elliott Clark added a comment -

        Nick Dimiduk https://github.com/twitter/zipkin/pull/274

        Can't you put up a picture that would give others a clue as to why we should check this in?

        Sure can.

        Show
        Elliott Clark added a comment - Nick Dimiduk https://github.com/twitter/zipkin/pull/274 Can't you put up a picture that would give others a clue as to why we should check this in? Sure can.
        Hide
        Nick Dimiduk added a comment -

        This tracing stuff is useful for users too. Have you looked at Zipkin as a tracing tool that users might use in production?

        Show
        Nick Dimiduk added a comment - This tracing stuff is useful for users too. Have you looked at Zipkin as a tracing tool that users might use in production?
        Hide
        stack added a comment -

        Can't you put up a picture that would give others a clue as to why we should check this in? Elliott Clark

        Show
        stack added a comment - Can't you put up a picture that would give others a clue as to why we should check this in? Elliott Clark
        Elliott Clark made changes -
        Field Original Value New Value
        Attachment HBASE-9121-PRE.patch [ 12595709 ]
        Hide
        Elliott Clark added a comment -

        Stack was asking what the tracing patch looked like. It still needs a new version of HTrace to be released. That should be coming shortly. Here's a patch (that won't work without HTrace from my github).

        Show
        Elliott Clark added a comment - Stack was asking what the tracing patch looked like. It still needs a new version of HTrace to be released. That should be coming shortly. Here's a patch (that won't work without HTrace from my github).
        Elliott Clark created issue -

          People

          • Assignee:
            Elliott Clark
            Reporter:
            Elliott Clark
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development