Details

    • Type: Sub-task Sub-task
    • Status: Patch Available
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: build
    • Labels:
    • Tags:
      beginner

      Description

      Here is example from 0.95. Downstream project includes hbase-client ONLY. To run the downstream project, here are the runtime dependencies currently. This is hadoop1.

       java -cp target/client-1.0-SNAPSHOT.jar:/Users/stack/.m2/repository/org/apache/hbase/hbase-client/0.95.2-hadoop1-SNAPSHOT/hbase-client-0.95.2-hadoop1-SNAPSHOT.jar:/Users/stack/.m2/repository/org/apache/hbase/hbase-common/0.95.2-hadoop1-SNAPSHOT/hbase-common-0.95.2-hadoop1-SNAPSHOT.jar:/Users/stack/.m2/repository/org/apache/hadoop/hadoop-core/1.1.2/hadoop-core-1.1.2.jar:/Users/stack/.m2/repository/commons-logging/commons-logging/1.1.1/commons-logging-1.1.1.jar:/Users/stack/.m2/repository/com/google/protobuf/protobuf-java/2.4.1/protobuf-java-2.4.1.jar:/Users/stack/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar:/Users/stack/.m2/repository/commons-configuration/commons-configuration/1.6/commons-configuration-1.6.jar:/Users/stack/.m2/repository/org/apache/hbase/hbase-protocol/0.95.2-hadoop1-SNAPSHOT/hbase-protocol-0.95.2-hadoop1-SNAPSHOT.jar:/Users/stack/.m2/repository/org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.jar:/Users/stack/.m2/repository/org/slf4j/slf4j-api/1.6.4/slf4j-api-1.6.4.jar:/Users/stack/.m2/repository/com/google/guava/guava/12.0.1/guava-12.0.1.jar:/Users/stack/.m2/repository/org/codehaus/jackson/jackson-mapper-asl/1.8.8/jackson-mapper-asl-1.8.8.jar:/Users/stack/.m2/repository/org/codehaus/jackson/jackson-core-asl/1.8.8/jackson-core-asl-1.8.8.jar:/Users/stack/.m2/repository/org/cloudera/htrace/htrace/1.50/htrace-1.50.jar:/Users/stack/.m2/repository/org/slf4j/slf4j-log4j12/1.6.1/slf4j-log4j12-1.6.1.jar:/Users/stack/.m2/repository/log4j/log4j/1.2.17/log4j-1.2.17.jar  org.hbase.downstream.Client
      

      Thats:

      hbase-client
      base-common
      hbase-protocol
      hadoop-core
      commons-logging
      protobuf
      commons-lang
      commons-configuration
      zookeeper
      slf4j-api (AND commons-logging!)
      guava
      jackson-mapper-asl
      jackson-core-asl
      htrace
      slf4j-log4j12
      slf4j
      

      Most of the above come in because of hadoop and zk (zk wants slf4j).

      Can we shed any of these?

      1. HBASE_9083.patch
        5 kB
        Michael Webster

        Activity

        Hide
        Sean Busbey added a comment -

        Can this be obviated by HBASE-13517?

        Show
        Sean Busbey added a comment - Can this be obviated by HBASE-13517 ?
        Hide
        Enis Soztutar added a comment -

        Is this still a problem?

        Show
        Enis Soztutar added a comment - Is this still a problem?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12604179/HBASE_9083.patch
        against trunk revision .
        ATTACHMENT ID: 12604179

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10302//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12604179/HBASE_9083.patch against trunk revision . ATTACHMENT ID: 12604179 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10302//console This message is automatically generated.
        Hide
        Elliott Clark added a comment -

        I created HBASE-9597 as a way of fixing the slf4j issue in hbase-server.

        Show
        Elliott Clark added a comment - I created HBASE-9597 as a way of fixing the slf4j issue in hbase-server.
        Hide
        stack added a comment -

        On the jsp support, we shouldn't need them in hbase (Thanks for doing this Michael Webster You might find this silly project of help – https://github.com/saintstack/hbase-downstreamer Its a simple project that 'depends' on hbase... you can see what gets pulled in. Sets up a basic test... running an hdfs. A test that did MR would be great (Our Aleksandr Shulman found that though our MR tests passed on jenkins, running on a cluster they MRv1 failed for want of dependencies at MR time.

        Show
        stack added a comment - On the jsp support, we shouldn't need them in hbase (Thanks for doing this Michael Webster You might find this silly project of help – https://github.com/saintstack/hbase-downstreamer Its a simple project that 'depends' on hbase... you can see what gets pulled in. Sets up a basic test... running an hdfs. A test that did MR would be great (Our Aleksandr Shulman found that though our MR tests passed on jenkins, running on a cluster they MRv1 failed for want of dependencies at MR time.
        Hide
        Nicolas Liochon added a comment -

        [WARNING] Used undeclared dependencies found:

        [WARNING] commons-lang:commons-lang:jar:2.4:compile
        [WARNING] org.slf4j:slf4j-api:jar:1.6.4:compile

        This means that we're actually using these jar, so we should not remove them from our pom.
        For slf4j, it's what Elliott said.
        For commons-lang, I don't know. May be we have this dependency for a wrong reason and we should change the code that depends on it (like I did in HBASE-9558).

        For the org.mockito:mockito-all, it's because they are included by default. As it's scoped "test", I think it's not an issue.

        I've just committed the removal of commons-codec:commons-codec:jar:1.7:compile and org.codehaus.jackson:jackson-xc:jar:1.8.8:compile in HBASE-9558.

        For
        [WARNING] tomcat:jasper-compiler:jar:5.5.23:runtime
        [WARNING] tomcat:jasper-runtime:jar:5.5.23:runtime

        I don't know if we can remove them.

        Show
        Nicolas Liochon added a comment - [WARNING] Used undeclared dependencies found: [WARNING] commons-lang:commons-lang:jar:2.4:compile [WARNING] org.slf4j:slf4j-api:jar:1.6.4:compile This means that we're actually using these jar, so we should not remove them from our pom. For slf4j, it's what Elliott said. For commons-lang, I don't know. May be we have this dependency for a wrong reason and we should change the code that depends on it (like I did in HBASE-9558 ). For the org.mockito:mockito-all, it's because they are included by default. As it's scoped "test", I think it's not an issue. I've just committed the removal of commons-codec:commons-codec:jar:1.7:compile and org.codehaus.jackson:jackson-xc:jar:1.8.8:compile in HBASE-9558 . For [WARNING] tomcat:jasper-compiler:jar:5.5.23:runtime [WARNING] tomcat:jasper-runtime:jar:5.5.23:runtime I don't know if we can remove them.
        Hide
        Michael Webster added a comment -

        There are warnings about both "Used declared dependencies found" and "Unused declared dependencies found". So I should add the used dependencies back in, and remove the unused ones from the poms that list them? Here are the warnings from mvn dependency:analyze:

        [WARNING] Used undeclared dependencies found:
        [WARNING] commons-lang:commons-lang:jar:2.4:compile
        [WARNING] Unused declared dependencies found:
        [WARNING] log4j:log4j:jar:1.2.17:compile
        [WARNING] Unused declared dependencies found:
        [WARNING] com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile
        [WARNING] log4j:log4j:jar:1.2.17:compile
        [WARNING] junit:junit:jar:4.11:compile
        [WARNING] org.mockito:mockito-all:jar:1.9.0:test
        [WARNING] Used undeclared dependencies found:
        [WARNING] commons-lang:commons-lang:jar:2.4:compile
        [WARNING] Unused declared dependencies found:
        [WARNING] org.apache.hbase:hbase-common:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-common:test-jar:tests:0.97.0-SNAPSHOT:test
        [WARNING] org.apache.hbase:hbase-protocol:jar:0.97.0-SNAPSHOT:compile
        [WARNING] Unused declared dependencies found:
        [WARNING] com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile
        [WARNING] log4j:log4j:jar:1.2.17:compile
        [WARNING] org.mockito:mockito-all:jar:1.9.0:test
        [WARNING] Unused declared dependencies found:
        [WARNING] org.apache.hbase:hbase-hadoop-compat:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-hadoop-compat:test-jar:tests:0.97.0-SNAPSHOT:test
        [WARNING] org.apache.hadoop:hadoop-test:jar:1.2.1:test
        [WARNING] log4j:log4j:jar:1.2.17:compile
        [WARNING] org.mockito:mockito-all:jar:1.9.0:test
        [WARNING] Unused declared dependencies found:
        [WARNING] org.apache.hbase:hbase-common:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-hadoop-compat:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-hadoop1-compat:jar:0.97.0-SNAPSHOT:compile
        [WARNING] com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile
        [WARNING] log4j:log4j:jar:1.2.17:compile
        [WARNING] org.mockito:mockito-all:jar:1.9.0:test
        13/09/20 10:42:36 INFO mortbay.log: Logging to org.slf4j.impl.Log4jLoggerAdapter(org.mortbay.log) via org.mortbay.log.Slf4jLog
        [WARNING] Used undeclared dependencies found:
        [WARNING] org.slf4j:slf4j-api:jar:1.6.4:compile
        [WARNING] org.codehaus.jackson:jackson-core-asl:jar:1.8.8:compile
        [WARNING] commons-lang:commons-lang:jar:2.5:compile
        [WARNING] Unused declared dependencies found:
        [WARNING] org.apache.hbase:hbase-common:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-protocol:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-client:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-prefix-tree:jar:0.97.0-SNAPSHOT:runtime
        [WARNING] org.apache.hbase:hbase-common:test-jar:tests:0.97.0-SNAPSHOT:test
        [WARNING] org.apache.hbase:hbase-hadoop-compat:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-hadoop-compat:test-jar:tests:0.97.0-SNAPSHOT:test
        [WARNING] org.apache.hbase:hbase-hadoop1-compat:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-hadoop1-compat:test-jar:tests:0.97.0-SNAPSHOT:test
        [WARNING] commons-codec:commons-codec:jar:1.7:compile
        [WARNING] org.codehaus.jackson:jackson-xc:jar:1.8.8:compile
        [WARNING] tomcat:jasper-compiler:jar:5.5.23:runtime
        [WARNING] tomcat:jasper-runtime:jar:5.5.23:runtime
        [WARNING] org.codehaus.jettison:jettison:jar:1.3.1:test
        [WARNING] org.cloudera.htrace:htrace-zipkin:jar:2.01:compile
        [WARNING] Used undeclared dependencies found:
        [WARNING] commons-lang:commons-lang:jar:2.5:compile
        [WARNING] Unused declared dependencies found:
        [WARNING] org.apache.hbase:hbase-common:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-common:test-jar:tests:0.97.0-SNAPSHOT:test
        [WARNING] org.apache.hbase:hbase-protocol:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-client:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-server:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-server:test-jar:tests:0.97.0-SNAPSHOT:test
        [WARNING] org.apache.hbase:hbase-hadoop-compat:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-hadoop-compat:test-jar:tests:0.97.0-SNAPSHOT:test
        [WARNING] org.apache.hbase:hbase-hadoop1-compat:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-hadoop1-compat:test-jar:tests:0.97.0-SNAPSHOT:test
        [WARNING] org.cloudera.htrace:htrace-zipkin:jar:2.01:compile
        [WARNING] com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile
        [WARNING] log4j:log4j:jar:1.2.17:compile
        [WARNING] org.mockito:mockito-all:jar:1.9.0:test
        [WARNING] Unused declared dependencies found:
        [WARNING] org.apache.hbase:hbase-common:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-common:test-jar:tests:0.97.0-SNAPSHOT:test
        [WARNING] org.apache.hbase:hbase-protocol:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-client:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-server:jar:0.97.0-SNAPSHOT:compile
        [WARNING] org.apache.hbase:hbase-server:test-jar:tests:0.97.0-SNAPSHOT:test
        [WARNING] org.apache.hadoop:hadoop-test:jar:1.2.1:test
        [WARNING] log4j:log4j:jar:1.2.17:compile

        Show
        Michael Webster added a comment - There are warnings about both "Used declared dependencies found" and "Unused declared dependencies found". So I should add the used dependencies back in, and remove the unused ones from the poms that list them? Here are the warnings from mvn dependency:analyze: [WARNING] Used undeclared dependencies found: [WARNING] commons-lang:commons-lang:jar:2.4:compile [WARNING] Unused declared dependencies found: [WARNING] log4j:log4j:jar:1.2.17:compile [WARNING] Unused declared dependencies found: [WARNING] com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile [WARNING] log4j:log4j:jar:1.2.17:compile [WARNING] junit:junit:jar:4.11:compile [WARNING] org.mockito:mockito-all:jar:1.9.0:test [WARNING] Used undeclared dependencies found: [WARNING] commons-lang:commons-lang:jar:2.4:compile [WARNING] Unused declared dependencies found: [WARNING] org.apache.hbase:hbase-common:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-common:test-jar:tests:0.97.0-SNAPSHOT:test [WARNING] org.apache.hbase:hbase-protocol:jar:0.97.0-SNAPSHOT:compile [WARNING] Unused declared dependencies found: [WARNING] com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile [WARNING] log4j:log4j:jar:1.2.17:compile [WARNING] org.mockito:mockito-all:jar:1.9.0:test [WARNING] Unused declared dependencies found: [WARNING] org.apache.hbase:hbase-hadoop-compat:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-hadoop-compat:test-jar:tests:0.97.0-SNAPSHOT:test [WARNING] org.apache.hadoop:hadoop-test:jar:1.2.1:test [WARNING] log4j:log4j:jar:1.2.17:compile [WARNING] org.mockito:mockito-all:jar:1.9.0:test [WARNING] Unused declared dependencies found: [WARNING] org.apache.hbase:hbase-common:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-hadoop-compat:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-hadoop1-compat:jar:0.97.0-SNAPSHOT:compile [WARNING] com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile [WARNING] log4j:log4j:jar:1.2.17:compile [WARNING] org.mockito:mockito-all:jar:1.9.0:test 13/09/20 10:42:36 INFO mortbay.log: Logging to org.slf4j.impl.Log4jLoggerAdapter(org.mortbay.log) via org.mortbay.log.Slf4jLog [WARNING] Used undeclared dependencies found: [WARNING] org.slf4j:slf4j-api:jar:1.6.4:compile [WARNING] org.codehaus.jackson:jackson-core-asl:jar:1.8.8:compile [WARNING] commons-lang:commons-lang:jar:2.5:compile [WARNING] Unused declared dependencies found: [WARNING] org.apache.hbase:hbase-common:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-protocol:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-client:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-prefix-tree:jar:0.97.0-SNAPSHOT:runtime [WARNING] org.apache.hbase:hbase-common:test-jar:tests:0.97.0-SNAPSHOT:test [WARNING] org.apache.hbase:hbase-hadoop-compat:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-hadoop-compat:test-jar:tests:0.97.0-SNAPSHOT:test [WARNING] org.apache.hbase:hbase-hadoop1-compat:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-hadoop1-compat:test-jar:tests:0.97.0-SNAPSHOT:test [WARNING] commons-codec:commons-codec:jar:1.7:compile [WARNING] org.codehaus.jackson:jackson-xc:jar:1.8.8:compile [WARNING] tomcat:jasper-compiler:jar:5.5.23:runtime [WARNING] tomcat:jasper-runtime:jar:5.5.23:runtime [WARNING] org.codehaus.jettison:jettison:jar:1.3.1:test [WARNING] org.cloudera.htrace:htrace-zipkin:jar:2.01:compile [WARNING] Used undeclared dependencies found: [WARNING] commons-lang:commons-lang:jar:2.5:compile [WARNING] Unused declared dependencies found: [WARNING] org.apache.hbase:hbase-common:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-common:test-jar:tests:0.97.0-SNAPSHOT:test [WARNING] org.apache.hbase:hbase-protocol:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-client:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-server:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-server:test-jar:tests:0.97.0-SNAPSHOT:test [WARNING] org.apache.hbase:hbase-hadoop-compat:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-hadoop-compat:test-jar:tests:0.97.0-SNAPSHOT:test [WARNING] org.apache.hbase:hbase-hadoop1-compat:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-hadoop1-compat:test-jar:tests:0.97.0-SNAPSHOT:test [WARNING] org.cloudera.htrace:htrace-zipkin:jar:2.01:compile [WARNING] com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile [WARNING] log4j:log4j:jar:1.2.17:compile [WARNING] org.mockito:mockito-all:jar:1.9.0:test [WARNING] Unused declared dependencies found: [WARNING] org.apache.hbase:hbase-common:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-common:test-jar:tests:0.97.0-SNAPSHOT:test [WARNING] org.apache.hbase:hbase-protocol:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-client:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-server:jar:0.97.0-SNAPSHOT:compile [WARNING] org.apache.hbase:hbase-server:test-jar:tests:0.97.0-SNAPSHOT:test [WARNING] org.apache.hadoop:hadoop-test:jar:1.2.1:test [WARNING] log4j:log4j:jar:1.2.17:compile
        Hide
        Nicolas Liochon added a comment -

        Yes, thrift generates code that depends on sl4j. But we have a dependency on thrift, so may be it brings slf4j with it?
        Michael Webster when you do a mvn dependency:analyze, what do you see? If it complains about something like "usage of undeclared dependencies", it means that we're actually using the dependency.

        In any case, it may make sense to declare it in our DependencyManagement section: as we have multiple third parties requiring slf4j (zookeeper for example), so we may need to impose a final version if we don't want all of them in the final package.

        Show
        Nicolas Liochon added a comment - Yes, thrift generates code that depends on sl4j. But we have a dependency on thrift, so may be it brings slf4j with it? Michael Webster when you do a mvn dependency:analyze, what do you see? If it complains about something like "usage of undeclared dependencies", it means that we're actually using the dependency. In any case, it may make sense to declare it in our DependencyManagement section: as we have multiple third parties requiring slf4j (zookeeper for example), so we may need to impose a final version if we don't want all of them in the final package.
        Hide
        Elliott Clark added a comment -

        Doesn't some of the generated code depend upon slf4j (thought it was thrift but I could be wrong) ?

        Show
        Elliott Clark added a comment - Doesn't some of the generated code depend upon slf4j (thought it was thrift but I could be wrong) ?
        Hide
        Michael Webster added a comment -

        Patch includes removal of dependencies stack mentioned. No tests since this is a change to the pom. I built and ran tests and verified that nothing broke from removing any of the dependencies

        Show
        Michael Webster added a comment - Patch includes removal of dependencies stack mentioned. No tests since this is a change to the pom. I built and ran tests and verified that nothing broke from removing any of the dependencies
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12604179/HBASE_9083.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12604179/HBASE_9083.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7313//console This message is automatically generated.
        Hide
        Michael Webster added a comment -

        I can work on this. Correct me if I am wrong, but this change should consist of removing dependencies HBase doesn't directly use and let maven figure out what to pull in for zk and the rest? Sorry if that is a restatement of previous comments, I just wanted to make sure I understand.

        Show
        Michael Webster added a comment - I can work on this. Correct me if I am wrong, but this change should consist of removing dependencies HBase doesn't directly use and let maven figure out what to pull in for zk and the rest? Sorry if that is a restatement of previous comments, I just wanted to make sure I understand.
        Hide
        stack added a comment -

        Moving out of 0.95/0.96. Chatting w/ Elliott we may not actually need jackson-core-asl nor commons-lang. Making this set smaller would be a nice noob project.

        Show
        stack added a comment - Moving out of 0.95/0.96. Chatting w/ Elliott we may not actually need jackson-core-asl nor commons-lang. Making this set smaller would be a nice noob project.
        Hide
        stack added a comment -

        Hopefully we can at least get out of the slf4j business. We're commons-logging. slf4j is used by zk and by thrift. Let those dependencies duke it out. Even still, with this patch installed, I think its four versions of slf4j that get installed in local repo: 1.4.3 from hadoop, 1.5.8 from netty (I believe) and then 1.6.1 from zk and someone else is shoving in 1.6.4. Ugh.

        Show
        stack added a comment - Hopefully we can at least get out of the slf4j business. We're commons-logging. slf4j is used by zk and by thrift. Let those dependencies duke it out. Even still, with this patch installed, I think its four versions of slf4j that get installed in local repo: 1.4.3 from hadoop, 1.5.8 from netty (I believe) and then 1.6.1 from zk and someone else is shoving in 1.6.4. Ugh.

          People

          • Assignee:
            stack
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:

              Development