HBase
  1. HBase
  2. HBASE-8965

TestRemoteAdmin.testClusterStatus fails

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.2
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. 8965.addendum_removetest.txt
      6 kB
      stack
    2. 8965.disabledtest.txt
      2 kB
      stack
    3. 8965.txt
      1 kB
      stack

      Activity

      Hide
      stack added a comment -

      Change the name of the table that we use for REST test.

      Show
      stack added a comment - Change the name of the table that we use for REST test.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12592659/8965.txt
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

      +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 site. The mvn site goal succeeds with this patch.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.security.access.TestAccessController
      org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12592659/8965.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.security.access.TestAccessController org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6363//console This message is automatically generated.
      Hide
      stack added a comment -

      I committed the patch to 0.95 and trunk. Lets see if this comes up again.

      Show
      stack added a comment - I committed the patch to 0.95 and trunk. Lets see if this comes up again.
      Hide
      Hudson added a comment -

      FAILURE: Integrated in hbase-0.95 #331 (See https://builds.apache.org/job/hbase-0.95/331/)
      HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1504001)

      • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Show
      Hudson added a comment - FAILURE: Integrated in hbase-0.95 #331 (See https://builds.apache.org/job/hbase-0.95/331/ ) HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1504001) /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Hide
      Hudson added a comment -

      FAILURE: Integrated in HBase-TRUNK #4260 (See https://builds.apache.org/job/HBase-TRUNK/4260/)
      HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1503999)

      • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Show
      Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4260 (See https://builds.apache.org/job/HBase-TRUNK/4260/ ) HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1503999) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Hide
      Hudson added a comment -

      FAILURE: Integrated in hbase-0.95-on-hadoop2 #182 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/182/)
      HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1504001)

      • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Show
      Hudson added a comment - FAILURE: Integrated in hbase-0.95-on-hadoop2 #182 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/182/ ) HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1504001) /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #620 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/620/)
      HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1503999)

      • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Show
      Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #620 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/620/ ) HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1503999) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Show
      stack added a comment - It failed again here: http://54.241.6.143/job/HBase-0.95-Hadoop-2/org.apache.hbase$hbase-server/642/testReport/org.apache.hadoop.hbase.rest.client/TestRemoteAdmin/testClusterStatus/ Looking at it...
      Hide
      stack added a comment -

      I wonder if this is to be believed:

      • Thread LEAK? -, OpenFileDescriptor=335 (was 334) - OpenFileDescriptor LEAK? -, MaxFileDescriptor=65536 (was 65536), SystemLoadAverage=869 (was 859) - SystemLoadAverage LEAK? -, ProcessCount=85 (was 85), AvailableMemoryMB=4223 (was 4332), ConnectionCount=4 (was 4)

      Descriptors are up against the limit and load is 870. That could do it.

      Andrew Purtell Any input here? After first test testCreateAndDeleteTable runs, there are more threads afloat:
      2013-07-17 20:54:50,781 INFO [pool-1-thread-1] hbase.ResourceChecker(171): after: rest.client.TestRemoteAdmin#testCreateAnDeleteTable Thread=184 (was 161)

      Going to disable this test for now.

      Show
      stack added a comment - I wonder if this is to be believed: Thread LEAK? -, OpenFileDescriptor=335 (was 334) - OpenFileDescriptor LEAK? -, MaxFileDescriptor=65536 (was 65536), SystemLoadAverage=869 (was 859) - SystemLoadAverage LEAK? -, ProcessCount=85 (was 85), AvailableMemoryMB=4223 (was 4332), ConnectionCount=4 (was 4) Descriptors are up against the limit and load is 870. That could do it. Andrew Purtell Any input here? After first test testCreateAndDeleteTable runs, there are more threads afloat: 2013-07-17 20:54:50,781 INFO [pool-1-thread-1] hbase.ResourceChecker(171): after: rest.client.TestRemoteAdmin#testCreateAnDeleteTable Thread=184 (was 161) Going to disable this test for now.
      Hide
      Andrew Purtell added a comment -

      Going to disable this test for now.

      Sounds good. Please reassign after, will look.

      Show
      Andrew Purtell added a comment - Going to disable this test for now. Sounds good. Please reassign after, will look.
      Hide
      stack added a comment -

      Patch to disable the test applied to 0.95 and trunk.

      I won't be surprised if see other failures in the class given the load and fds used.

      Show
      stack added a comment - Patch to disable the test applied to 0.95 and trunk. I won't be surprised if see other failures in the class given the load and fds used.
      Hide
      Andrew Purtell added a comment -

      Actually let's consider if these tests provide much value. My position is RemoteAdmin and RemoteTable are for facilitating other REST tests, not for use as any kind of official client. I've not heard a contradictory opinion. Other unit tests cover any administrative actions these tests might take, they're basic. I propose to remove these tests entirely under this issue. Tests that verify the REST admin APIs with a mocked back end could be a new JIRA after this.

      Show
      Andrew Purtell added a comment - Actually let's consider if these tests provide much value. My position is RemoteAdmin and RemoteTable are for facilitating other REST tests, not for use as any kind of official client. I've not heard a contradictory opinion. Other unit tests cover any administrative actions these tests might take, they're basic. I propose to remove these tests entirely under this issue. Tests that verify the REST admin APIs with a mocked back end could be a new JIRA after this.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12592881/8965.disabledtest.txt
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      -1 patch. The patch command could not apply the patch.

      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6387//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12592881/8965.disabledtest.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6387//console This message is automatically generated.
      Hide
      stack added a comment -

      Thanks Andrew Purtell Let me remove the test altogether.

      Show
      stack added a comment - Thanks Andrew Purtell Let me remove the test altogether.
      Hide
      stack added a comment -

      Remove the test completely. Applied to trunk and 0.95.

      Show
      stack added a comment - Remove the test completely. Applied to trunk and 0.95.
      Hide
      stack added a comment -

      Removed the test from 0.95 and trunk.

      Show
      stack added a comment - Removed the test from 0.95 and trunk.
      Hide
      Hudson added a comment -

      FAILURE: Integrated in hbase-0.95-on-hadoop2 #183 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/183/)
      HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1504319)

      • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
        HBASE-8965 TestRemoteAdmin.testClusterStatus fails; DISABLING TEST (stack: rev 1504307)
      • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Show
      Hudson added a comment - FAILURE: Integrated in hbase-0.95-on-hadoop2 #183 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/183/ ) HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1504319) /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java HBASE-8965 TestRemoteAdmin.testClusterStatus fails; DISABLING TEST (stack: rev 1504307) /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in hbase-0.95 #333 (See https://builds.apache.org/job/hbase-0.95/333/)
      HBASE-8965 TestRemoteAdmin.testClusterStatus fails; DISABLING TEST (stack: rev 1504307)

      • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Show
      Hudson added a comment - SUCCESS: Integrated in hbase-0.95 #333 (See https://builds.apache.org/job/hbase-0.95/333/ ) HBASE-8965 TestRemoteAdmin.testClusterStatus fails; DISABLING TEST (stack: rev 1504307) /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #621 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/621/)
      HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1504320)

      • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
        HBASE-8965 TestRemoteAdmin.testClusterStatus fails; DISABLING TEST (stack: rev 1504306)
      • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Show
      Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #621 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/621/ ) HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1504320) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java HBASE-8965 TestRemoteAdmin.testClusterStatus fails; DISABLING TEST (stack: rev 1504306) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in HBase-TRUNK #4264 (See https://builds.apache.org/job/HBase-TRUNK/4264/)
      HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1504320)

      • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
        HBASE-8965 TestRemoteAdmin.testClusterStatus fails; DISABLING TEST (stack: rev 1504306)
      • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Show
      Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4264 (See https://builds.apache.org/job/HBase-TRUNK/4264/ ) HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1504320) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java HBASE-8965 TestRemoteAdmin.testClusterStatus fails; DISABLING TEST (stack: rev 1504306) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in hbase-0.95 #334 (See https://builds.apache.org/job/hbase-0.95/334/)
      HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1504319)

      • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java
      Show
      Hudson added a comment - SUCCESS: Integrated in hbase-0.95 #334 (See https://builds.apache.org/job/hbase-0.95/334/ ) HBASE-8965 TestRemoteAdmin.testClusterStatus fails (stack: rev 1504319) /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java

        People

        • Assignee:
          stack
          Reporter:
          stack
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development