HBase
  1. HBase
  2. HBASE-8818 [thrift2] Update Thrift2 to supersede Thrift1 and equal REST
  3. HBASE-8943

Split Thrift2's ThriftServer into separate classes for easier testing and modularization

    Details

    • Type: Sub-task Sub-task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Thrift
    • Labels:
    • Tags:
      Thrift2

      Description

      Currently the ThriftServer class in Thrift 2 sets up and starts the actual server. Better follow a similar pattern to Thrift 1 where there is some factory setting up the server, and a separate start section. That way it is easier to test if the setup of the server is picking up everything it needs.

        Issue Links

          Activity

          Hide
          stack added a comment -

          Can they share code?

          Show
          stack added a comment - Can they share code?
          Hide
          Lars George added a comment -

          Hi Stack, I am not sure they can share much, they quickly get into the issue of linking to the specific Thrift modules. Also, Thrift 1 is going to go away eventually, so why start fiddling with a factory class of sorts?

          I am still amazed how we ripped out REST and replaced it with Stargate (aka REST 2) and no one asked these questions?

          Show
          Lars George added a comment - Hi Stack, I am not sure they can share much, they quickly get into the issue of linking to the specific Thrift modules. Also, Thrift 1 is going to go away eventually, so why start fiddling with a factory class of sorts? I am still amazed how we ripped out REST and replaced it with Stargate (aka REST 2) and no one asked these questions?
          Hide
          Lars George added a comment -

          Just to clarify my above comment on REST - it seems that if we would have had someone in the past to drive Thrift, we would not be in this dual interface predicament. REST had an owner and got in timely and swiftly. Thrift should have been the same. No one to blame, just saying.

          Show
          Lars George added a comment - Just to clarify my above comment on REST - it seems that if we would have had someone in the past to drive Thrift, we would not be in this dual interface predicament. REST had an owner and got in timely and swiftly. Thrift should have been the same. No one to blame, just saying.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #4256 (See https://builds.apache.org/job/HBase-TRUNK/4256/)
          HBASE-8943 TestRegionMergeTransactionOnCluster#testWholesomeMerge may fail due to race in opening region (stack: rev 1503470)

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DispatchMergingRegionHandler.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4256 (See https://builds.apache.org/job/HBase-TRUNK/4256/ ) HBASE-8943 TestRegionMergeTransactionOnCluster#testWholesomeMerge may fail due to race in opening region (stack: rev 1503470) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DispatchMergingRegionHandler.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in hbase-0.95 #327 (See https://builds.apache.org/job/hbase-0.95/327/)
          HBASE-8943 TestRegionMergeTransactionOnCluster#testWholesomeMerge may fail due to race in opening region (stack: rev 1503471)

          • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DispatchMergingRegionHandler.java
          Show
          Hudson added a comment - FAILURE: Integrated in hbase-0.95 #327 (See https://builds.apache.org/job/hbase-0.95/327/ ) HBASE-8943 TestRegionMergeTransactionOnCluster#testWholesomeMerge may fail due to race in opening region (stack: rev 1503471) /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DispatchMergingRegionHandler.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #617 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/617/)
          HBASE-8943 TestRegionMergeTransactionOnCluster#testWholesomeMerge may fail due to race in opening region (stack: rev 1503470)

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DispatchMergingRegionHandler.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #617 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/617/ ) HBASE-8943 TestRegionMergeTransactionOnCluster#testWholesomeMerge may fail due to race in opening region (stack: rev 1503470) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DispatchMergingRegionHandler.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in hbase-0.95-on-hadoop2 #180 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/180/)
          HBASE-8943 TestRegionMergeTransactionOnCluster#testWholesomeMerge may fail due to race in opening region (stack: rev 1503471)

          • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DispatchMergingRegionHandler.java
          Show
          Hudson added a comment - FAILURE: Integrated in hbase-0.95-on-hadoop2 #180 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/180/ ) HBASE-8943 TestRegionMergeTransactionOnCluster#testWholesomeMerge may fail due to race in opening region (stack: rev 1503471) /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DispatchMergingRegionHandler.java

            People

            • Assignee:
              Lars George
              Reporter:
              Lars George
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development