Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.95.2, 0.94.10
    • Component/s: Thrift
    • Labels:
    • Tags:
      Thrift2

      Description

      HBASE-5428 adds loading filters at start up. Needs to be added in Thrift 2 as well.

      1. HBASE-8819.patch
        4 kB
        Lars George
      2. HBASE-8819-0.94.patch
        4 kB
        Lars George

        Issue Links

          Activity

          Lars George created issue -
          Lars George made changes -
          Field Original Value New Value
          Labels thrift2
          Lars George made changes -
          Attachment HBASE-8819.patch [ 12591221 ]
          Lars George made changes -
          Assignee Lars George [ larsgeorge ]
          Lars George made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Fix Version/s 0.98.0 [ 12323143 ]
          Fix Version/s 0.95.2 [ 12320040 ]
          Tags Thrift2
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12591221/HBASE-8819.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12591221/HBASE-8819.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6239//console This message is automatically generated.
          Lars George made changes -
          Attachment HBASE-8819-0.94.patch [ 12591233 ]
          Hide
          Lars George added a comment -

          Hey Hamed Madani, could you have a look at the patch I did? I would appreciate a second eyeball set before committing. Tests pass.

          Show
          Lars George added a comment - Hey Hamed Madani , could you have a look at the patch I did? I would appreciate a second eyeball set before committing. Tests pass.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12591233/HBASE-8819-0.94.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6240//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12591233/HBASE-8819-0.94.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6240//console This message is automatically generated.
          Hide
          Hamed Madani added a comment -

          Thank you Lars George. The patch looks good.

          Show
          Hamed Madani added a comment - Thank you Lars George . The patch looks good.
          Hide
          Lars George added a comment -

          Committed to 0.94, 0.95, and trunk.

          Show
          Lars George added a comment - Committed to 0.94, 0.95, and trunk.
          Lars George made changes -
          Link This issue is related to HBASE-5428 [ HBASE-5428 ]
          Lars George made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.94.10 [ 12324627 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security #201 (See https://builds.apache.org/job/HBase-0.94-security/201/)
          HBASE-8819 Port HBASE-5428 to Thrift 2 (Revision 1501211)

          Result = FAILURE
          larsgeorge :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security #201 (See https://builds.apache.org/job/HBase-0.94-security/201/ ) HBASE-8819 Port HBASE-5428 to Thrift 2 (Revision 1501211) Result = FAILURE larsgeorge : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #1047 (See https://builds.apache.org/job/HBase-0.94/1047/)
          HBASE-8819 Port HBASE-5428 to Thrift 2 (Revision 1501211)

          Result = SUCCESS
          larsgeorge :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #1047 (See https://builds.apache.org/job/HBase-0.94/1047/ ) HBASE-8819 Port HBASE-5428 to Thrift 2 (Revision 1501211) Result = SUCCESS larsgeorge : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Hide
          Hudson added a comment -

          Integrated in hbase-0.95 #302 (See https://builds.apache.org/job/hbase-0.95/302/)
          HBASE-8819 Port HBASE-5428 to Thrift 2 (Revision 1501210)

          Result = SUCCESS
          larsgeorge :
          Files :

          • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
          • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Show
          Hudson added a comment - Integrated in hbase-0.95 #302 (See https://builds.apache.org/job/hbase-0.95/302/ ) HBASE-8819 Port HBASE-5428 to Thrift 2 (Revision 1501210) Result = SUCCESS larsgeorge : Files : /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #4230 (See https://builds.apache.org/job/HBase-TRUNK/4230/)
          HBASE-8819 Port HBASE-5428 to Thrift 2 (Revision 1501209)

          Result = FAILURE
          larsgeorge :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #4230 (See https://builds.apache.org/job/HBase-TRUNK/4230/ ) HBASE-8819 Port HBASE-5428 to Thrift 2 (Revision 1501209) Result = FAILURE larsgeorge : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #606 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/606/)
          HBASE-8819 Port HBASE-5428 to Thrift 2 (Revision 1501209)

          Result = FAILURE
          larsgeorge :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #606 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/606/ ) HBASE-8819 Port HBASE-5428 to Thrift 2 (Revision 1501209) Result = FAILURE larsgeorge : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Hide
          Hudson added a comment -

          Integrated in hbase-0.95-on-hadoop2 #172 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/172/)
          HBASE-8819 Port HBASE-5428 to Thrift 2 (Revision 1501210)

          Result = FAILURE
          larsgeorge :
          Files :

          • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
          • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Show
          Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #172 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/172/ ) HBASE-8819 Port HBASE-5428 to Thrift 2 (Revision 1501210) Result = FAILURE larsgeorge : Files : /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Lars Hofhansl made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Lars George
              Reporter:
              Lars George
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development