[HBASE-8699] Parameter to DistributedFileSystem#isFileClosed should be of type Path

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.98.0, 0.95.2
• Component/s: wal
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 06/Jun/13 16:13
• Updated: 23/Sep/13 19:22
• Resolved: 18/Jul/13 22:24

Description

Here is current code of FSHDFSUtils#isFileClosed():

  boolean isFileClosed(final DistributedFileSystem dfs, final Path p) {
    try {
      Method m = dfs.getClass().getMethod("isFileClosed", new Class<?>[] {String.class});
      return (Boolean) m.invoke(dfs, p.toString());

We look for isFileClosed method with parameter type of String.

However, from hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java (branch-2):

  public boolean isFileClosed(Path src) throws IOException {

The parameter type is of Path.
This means we would get NoSuchMethodException.

Issue Links

• is related to: HBASE-8670 [0.94] Backport HBASE-8449,HBASE-8204 and HBASE-8699 to 0.94 (Refactor recoverLease retries and pauses)