[HBASE-8695] The HBase thrift service ignores XML configuration

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.94.6
• Fix Version/s: 0.98.0, 0.95.2, 0.94.10
• Component/s: Thrift

Environment

Ubuntu 12.04.2 LTS

• Assignee: Lars George
• Reporter: Brandon Forehand
• Created: 05/Jun/13 21:53
• Updated: 24/Jul/13 19:08
• Resolved: 11/Jul/13 09:12

Description

I put the following configuration in my hbase-site.xml:

  <property>
    <name>hbase.regionserver.thrift.compact</name>
    <value>true</value>
  </property>
  <property>
    <name>hbase.regionserver.thrift.framed</name>
    <value>true</value>
  </property>

But the configuration is ignored due to the following lines in ThriftServer.java around lines 197:

    conf.setBoolean(
        ThriftServerRunner.COMPACT_CONF_KEY, cmd.hasOption(COMPACT_OPTION));
    conf.setBoolean(
        ThriftServerRunner.FRAMED_CONF_KEY, cmd.hasOption(FRAMED_OPTION));

The configuration values are being unconditionally set to the defaults programmatically.

Issue Links

• relates to: HBASE-8826 Ensure HBASE-8695 is covered in Thrift 2
• relates to: HBASE-8921 [thrift2] Add GenericOptionsParser to Thrift 2 server