Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-8530

Refine error message from ExportSnapshot when there is leftover snapshot in target cluster

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.98.0, 0.94.8, 0.95.1
    • None
    • None
    • Reviewed

    Description

      ExportSnapshot performs the following validation check before starting export:

          // Check if the snapshot already in-progress
          if (outputFs.exists(snapshotTmpDir)) {
            System.err.println("A snapshot with the same name '" + snapshotName + "' is in-progress");
            return 1;
          }
      

      The intention was to prevent concurrent snapshot export when snapshot with the same name may be outstanding.
      Here is sample output:

      hbase@ip-10-165-36-226 root$ hbase org.apache.hadoop.hbase.snapshot.ExportSnapshot -snapshot snapone -copy-to hdfs://10.12.113.22:8020/apps/hbase/data -mappers 1
      A snapshot with the same name 'snapone' is in-progress
      

      We should note the actual path in the error message so that user can check whether the snapshot with same name is still pending.

      Attachments

        1. 8530-v1.txt
          0.9 kB
          Ted Yu
        2. 8530-0.94.txt
          0.8 kB
          Ted Yu

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            yuzhihong@gmail.com Ted Yu
            yuzhihong@gmail.com Ted Yu
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment