Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.95.2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Added Durability setting for table with HTableDescriptor.setDurability() API. Deprecated HTableDescriptor.setDeferredLogFlush(), and shell usage in favor of the new durability setting. Now, durability can be configured per table and per mutation.

      Description

      HBASE-7801 introduces the notion of per mutation fine grained durability settings.
      This issue is to consider and the discuss the same for the per table settings (i.e. what would be used if the mutation indicates USE_DEFAULT). I propose the following setting per table:

      • SKIP_WAL (i.e. an unlogged table)
      • ASYNC_WAL (the current deferred log flush)
      • SYNC_WAL (the current default)
      • FSYNC_WAL (for future uses of HDFS' hsync())
      1. hbase-8375_v1.patch
        27 kB
        Enis Soztutar
      2. hbase-8375_v2.patch
        27 kB
        Enis Soztutar
      3. hbase-8375_v5.patch
        33 kB
        Enis Soztutar

        Activity

        Hide
        devaraj Devaraj Das added a comment -

        I think we should seriously consider HBASE-5930 in the context of these "don't write to WAL" changes. That jira would have done at least some damage control in the events of node failures.

        Show
        devaraj Devaraj Das added a comment - I think we should seriously consider HBASE-5930 in the context of these "don't write to WAL" changes. That jira would have done at least some damage control in the events of node failures.
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Agreed.

        Show
        lhofhansl Lars Hofhansl added a comment - Agreed.
        Hide
        enis Enis Soztutar added a comment -

        It seems that we should get this in by 0.96, marking it for 0.95.2. Lars, I can work on it if you would not mind.

        Show
        enis Enis Soztutar added a comment - It seems that we should get this in by 0.96, marking it for 0.95.2. Lars, I can work on it if you would not mind.
        Hide
        lhofhansl Lars Hofhansl added a comment -

        I do not mind at all.

        Show
        lhofhansl Lars Hofhansl added a comment - I do not mind at all.
        Hide
        enis Enis Soztutar added a comment -

        Put up a patch at https://reviews.apache.org/r/11064/. Reviews welcome, no rush
        The patch does what the jira description talks about.

        Show
        enis Enis Soztutar added a comment - Put up a patch at https://reviews.apache.org/r/11064/ . Reviews welcome, no rush The patch does what the jira description talks about.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12582727/hbase-8375_v1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.regionserver.wal.TestDurability

        -1 core zombie tests. There are 1 zombie test(s):

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12582727/hbase-8375_v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestDurability -1 core zombie tests . There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5632//console This message is automatically generated.
        Hide
        enis Enis Soztutar added a comment -

        Wow, totally forgot that there is a TestDurability class. Let me fix the test.

        Show
        enis Enis Soztutar added a comment - Wow, totally forgot that there is a TestDurability class. Let me fix the test.
        Hide
        enis Enis Soztutar added a comment -

        v2 from RB.

        Show
        enis Enis Soztutar added a comment - v2 from RB.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12582760/hbase-8375_v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.TestFullLogReconstruction

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.client.TestHCM.testDeleteForZKConnLeak(TestHCM.java:855)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12582760/hbase-8375_v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestFullLogReconstruction -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.client.TestHCM.testDeleteForZKConnLeak(TestHCM.java:855) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5636//console This message is automatically generated.
        Hide
        enis Enis Soztutar added a comment -

        Lars Hofhansl, Anoop Sam John do you mind taking a look?

        Show
        enis Enis Soztutar added a comment - Lars Hofhansl , Anoop Sam John do you mind taking a look?
        Hide
        sershe Sergey Shelukhin added a comment -

        few small comments on rb

        Show
        sershe Sergey Shelukhin added a comment - few small comments on rb
        Hide
        anoop.hbase Anoop Sam John added a comment -

        Sorry for being late. Not getting the mails from JIRA regarding mentioning me in comment!!
        Few minor comments are added in RB.
        Looks good to me Enis..

        Show
        anoop.hbase Anoop Sam John added a comment - Sorry for being late. Not getting the mails from JIRA regarding mentioning me in comment!! Few minor comments are added in RB. Looks good to me Enis..
        Hide
        sershe Sergey Shelukhin added a comment -

        latest iteration on rb looks reasonable

        Show
        sershe Sergey Shelukhin added a comment - latest iteration on rb looks reasonable
        Hide
        anoop.hbase Anoop Sam John added a comment -

        LGTM as well. +1

        Show
        anoop.hbase Anoop Sam John added a comment - LGTM as well. +1
        Hide
        enis Enis Soztutar added a comment -

        Attaching patch from RB. Will commit if tests pass.

        Show
        enis Enis Soztutar added a comment - Attaching patch from RB. Will commit if tests pass.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12591722/hbase-8375_v5.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestAdmin

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12591722/hbase-8375_v5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestAdmin Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6302//console This message is automatically generated.
        Hide
        enis Enis Soztutar added a comment -

        I've committed this. Thanks for reviews. (TestAdmin passes locally)

        Show
        enis Enis Soztutar added a comment - I've committed this. Thanks for reviews. (TestAdmin passes locally)
        Hide
        hudson Hudson added a comment -

        Integrated in hbase-0.95 #312 (See https://builds.apache.org/job/hbase-0.95/312/)
        HBASE-8375 Durability setting per table (Revision 1502077)

        Result = SUCCESS
        enis :
        Files :

        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Durability.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/admin.rb
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Show
        hudson Hudson added a comment - Integrated in hbase-0.95 #312 (See https://builds.apache.org/job/hbase-0.95/312/ ) HBASE-8375 Durability setting per table (Revision 1502077) Result = SUCCESS enis : Files : /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Durability.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/admin.rb /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-TRUNK #4239 (See https://builds.apache.org/job/HBase-TRUNK/4239/)
        HBASE-8375 Durability setting per table (Revision 1502076)

        Result = SUCCESS
        enis :
        Files :

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Durability.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Show
        hudson Hudson added a comment - Integrated in HBase-TRUNK #4239 (See https://builds.apache.org/job/HBase-TRUNK/4239/ ) HBASE-8375 Durability setting per table (Revision 1502076) Result = SUCCESS enis : Files : /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Durability.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Hide
        hudson Hudson added a comment -

        Integrated in hbase-0.95-on-hadoop2 #175 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/175/)
        HBASE-8375 Durability setting per table (Revision 1502077)

        Result = FAILURE
        enis :
        Files :

        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
        • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Durability.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/admin.rb
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Show
        hudson Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #175 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/175/ ) HBASE-8375 Durability setting per table (Revision 1502077) Result = FAILURE enis : Files : /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Durability.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/admin.rb /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #609 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/609/)
        HBASE-8375 Durability setting per table (Revision 1502076)

        Result = FAILURE
        enis :
        Files :

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Durability.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Show
        hudson Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #609 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/609/ ) HBASE-8375 Durability setting per table (Revision 1502076) Result = FAILURE enis : Files : /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Durability.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Enis Soztutar, any assessment as to how risky this would be in 0.94? It looks like it would be backward compatible (as long as we still also support the old option - or interpret that in terms of the new options).

        Show
        lhofhansl Lars Hofhansl added a comment - Enis Soztutar , any assessment as to how risky this would be in 0.94? It looks like it would be backward compatible (as long as we still also support the old option - or interpret that in terms of the new options).
        Hide
        enis Enis Soztutar added a comment -

        I think this is low risk, especially with the test in the trunk patch. It tests all the combinations for Durability for table x mutation with a mocked WAL to check whether sync is called. We have to be careful to keep BC. I probably won't have any time to work on the backport though.

        Show
        enis Enis Soztutar added a comment - I think this is low risk, especially with the test in the trunk patch. It tests all the combinations for Durability for table x mutation with a mocked WAL to check whether sync is called. We have to be careful to keep BC. I probably won't have any time to work on the backport though.

          People

          • Assignee:
            enis Enis Soztutar
            Reporter:
            lhofhansl Lars Hofhansl
          • Votes:
            0 Vote for this issue
            Watchers:
            12 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development