HBase
  1. HBase
  2. HBASE-8259

Snapshot backport in 0.94.6 breaks rolling restarts

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.94.6
    • Fix Version/s: 0.94.6.1, 0.94.7
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Aleksandr Shulman found with his nifty QA tools that 0.94.6 has an incompatible change due to HBASE-7360 (Snapshot 0.94 Backport) that breaks rolling restarts.

      RegionTransitionData.write() uses eventType.ordinal() that is the index in the enum and not the value specified in the enum definition. It means we can't add new states in the middle of the list. This can be fixed by moving C_M_SNAPSHOT_TABLE and C_M_RESTORE_SNAPSHOT at the end of the list. Trunk does the right thing already.

      Right now, RIT znodes created with 0.94.6 (or top of the branch) will use the wrong value for the event type. You will see things like:

      2013-04-03 14:57:25,197 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign: regionserver:60020-0x13dd1e10dbd0004 Attempting to transition node 70236052/-ROOT- from M_ZK_REGION_OFFLINE to RS_ZK_REGION_OPENING
      2013-04-03 14:57:25,201 WARN org.apache.hadoop.hbase.zookeeper.ZKAssign: regionserver:60020-0x13dd1e10dbd0004 Attempt to transition the unassigned node for 70236052 from M_ZK_REGION_OFFLINE to RS_ZK_REGION_OPENING failed, the node existed but was in the state M_SERVER_SHUTDOWN set by the server 192.168.1.112,60020,1365026237977
      2013-04-03 14:57:25,201 WARN org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler: Failed transition from OFFLINE to OPENING for region=70236052
      2013-04-03 14:57:25,201 WARN org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler: Region was hijacked? It no longer exists, encodedName=70236052
      

      We should roll a 0.94.6.1 or 0.94.7 as soon this is fixed IMO.

      1. HBASE-8259-v0.patch
        3 kB
        Matteo Bertozzi

        Activity

        Jean-Daniel Cryans created issue -
        Matteo Bertozzi made changes -
        Field Original Value New Value
        Attachment HBASE-8259-v0.patch [ 12576864 ]
        Matteo Bertozzi made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Lars Hofhansl made changes -
        Fix Version/s 0.94.6.1 [ 12324295 ]
        Fix Version/s 0.94.7 [ 12324039 ]
        Lars Hofhansl made changes -
        Fix Version/s 0.94.7 [ 12324039 ]
        Lars Hofhansl made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Lars Hofhansl made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Matteo Bertozzi
            Reporter:
            Jean-Daniel Cryans
          • Votes:
            0 Vote for this issue
            Watchers:
            13 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development