[HBASE-822] Update thrift README and HBase.thrift to use thrift 20080411

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.2.1, 0.18.0
• Assignee: Unassigned
• Reporter: Michael Stack
• Created: 12/Aug/08 17:56
• Updated: 13/Sep/08 23:22
• Resolved: 16/Aug/08 22:12

Description

From hbase-dev list titled 'Thrift':

Hey,
When using thrift as per the README.txt in
$HBASE_HOME/src/examples/thrift is outdated and uses deprecated
arguments for thrift.  The command should be

$thrift --gen cpp --gen java -gen rb \
    ../../../src/java/org/apache/hadoop/hbase/thrift/Hbase.thrift

Also, the Hbase.thrift file is a little outdated.  It uses namespaces now.

java_package org.apache.hadoop.hbase.thrift.generated
cpp_namespace apache.hadoop.hbase.thrift
ruby_namespace Apache.Hadoop.Hbase.Thrift

Should be

namespace java org.apache.hadoop.hbase.thrift.generated
namespace cpp  apache.hadoop.hbase.thrift
namespace rb Apache.Hadoop.Hbase.Thrift

I have attached both patch files.

Thanks,
Michael




34,36c34,36
< java_package org.apache.hadoop.hbase.thrift.generated
< cpp_namespace apache.hadoop.hbase.thrift
< ruby_namespace Apache.Hadoop.Hbase.Thrift
---
> > namespace java org.apache.hadoop.hbase.thrift.generated
> > namespace cpp  apache.hadoop.hbase.thrift
> > namespace rb Apache.Hadoop.Hbase.Thrift



12c12
< thrift -cpp -java -rb \
---
> > thrift --gen cpp -- gen java --gen rb \

Issue Links

• is related to: HBASE-697 thrift idl needs update/edit to match new 0.2 API (and to fix bugs)