Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-8059

Enhance test-patch.sh so that patch can specify hadoop-2.0 as the default profile

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.98.0
    • None
    • None

    Description

      Over in HBASE-7904, I produced a patch which uses hadoop-2.0 as the default profile.
      However, when QA tries to validate compilation against hadoop-2.0:

      [ERROR] The build could not read 1 project -> [Help 1]
      [ERROR]
      [ERROR]   The project org.apache.hbase:hbase:0.97-SNAPSHOT (/Users/tyu/trunk/pom.xml) has 2 errors
      [ERROR]     'dependencyManagement.dependencies.dependency.artifactId' for org.apache.hbase:${compat.module}:jar with value '${compat.module}' does not match a valid id pattern. @ line 979, column 21
      [ERROR]     'dependencyManagement.dependencies.dependency.artifactId' for org.apache.hbase:${compat.module}:test-jar with value '${compat.module}' does not match a valid id pattern. @ line 984, column 21
      

      We should enhance test-patch.sh so that patch with hadoop-2.0 as default profile doesn't go through validation step against hadoop-2.0

      Ideally, the changes in various pom.xml files should be saved as template. User can specify the hadoop profile to test against in the header of patch file.
      e.g.

      This patch uses hadoop-2.0 as default profile
      
      Index: hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
      

      Attachments

        1. 7904-v5-hadoop-2.0.txt
          7 kB
          Ted Yu
        2. hadoop-2.0-template-pom.xml
          5 kB
          Ted Yu
        3. 8059-v2.txt
          0.6 kB
          Ted Yu
        4. 8059-v1.txt
          0.6 kB
          Ted Yu

        Activity

          People

            Unassigned Unassigned
            yuzhihong@gmail.com Ted Yu
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: