Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-7986

[REST] Make HTablePool size configurable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.98.0, 0.94.6, 0.95.0
    • REST
    • None
    • Reviewed

    Description

      Current in rest the HTablePool use a size 10 and can not be changed.

        RESTServlet(Configuration conf) throws IOException {
          this.conf = conf;
          this.pool = new HTablePool(conf, 10);
          this.admin = new HBaseAdmin(conf);
        }
      

      Attachments

        1. HBASE-7986-94.patch
          0.6 kB
          Lijin Bin
        2. HBASE-7986-trunk.patch
          0.6 kB
          Lijin Bin

        Activity

          +1 on patch

          ram_krish ramkrishna.s.vasudevan added a comment - +1 on patch
          zjushch Chunhui Shen added a comment -

          +1

          zjushch Chunhui Shen added a comment - +1
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12571854/HBASE-7986-trunk.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
          org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571854/HBASE-7986-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4649//console This message is automatically generated.

          Going to commit this but having trouble getting minicluster to come up with current trunk. Might be an environment issue. Will commit to trunk, 0.94, 0.95 once I get a green REST test locally. I'm sure the change is good but still want to do that.

          apurtell Andrew Kyle Purtell added a comment - Going to commit this but having trouble getting minicluster to come up with current trunk. Might be an environment issue. Will commit to trunk, 0.94, 0.95 once I get a green REST test locally. I'm sure the change is good but still want to do that.
          hudson Hudson added a comment -

          Integrated in HBase-TRUNK #3914 (See https://builds.apache.org/job/HBase-TRUNK/3914/)
          HBASE-7986. [REST] Make HTablePool size configurable (binlijin) (Revision 1452770)

          Result = FAILURE
          apurtell :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
          hudson Hudson added a comment - Integrated in HBase-TRUNK #3914 (See https://builds.apache.org/job/HBase-TRUNK/3914/ ) HBASE-7986 . [REST] Make HTablePool size configurable (binlijin) (Revision 1452770) Result = FAILURE apurtell : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
          hudson Hudson added a comment -

          Integrated in hbase-0.95 #24 (See https://builds.apache.org/job/hbase-0.95/24/)
          HBASE-7986. [REST] Make HTablePool size configurable (binlijin) (Revision 1452771)

          Result = FAILURE
          apurtell :
          Files :

          • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
          hudson Hudson added a comment - Integrated in hbase-0.95 #24 (See https://builds.apache.org/job/hbase-0.95/24/ ) HBASE-7986 . [REST] Make HTablePool size configurable (binlijin) (Revision 1452771) Result = FAILURE apurtell : Files : /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
          hudson Hudson added a comment -

          Integrated in HBase-0.94 #881 (See https://builds.apache.org/job/HBase-0.94/881/)
          HBASE-7986. [REST] Make HTablePool size configurable (binlijin) (Revision 1452772)

          Result = SUCCESS
          apurtell :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
          hudson Hudson added a comment - Integrated in HBase-0.94 #881 (See https://builds.apache.org/job/HBase-0.94/881/ ) HBASE-7986 . [REST] Make HTablePool size configurable (binlijin) (Revision 1452772) Result = SUCCESS apurtell : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
          hudson Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #431 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/431/)
          HBASE-7986. [REST] Make HTablePool size configurable (binlijin) (Revision 1452770)

          Result = FAILURE
          apurtell :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
          hudson Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #431 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/431/ ) HBASE-7986 . [REST] Make HTablePool size configurable (binlijin) (Revision 1452770) Result = FAILURE apurtell : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
          hudson Hudson added a comment -

          Integrated in hbase-0.95-on-hadoop2 #12 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/12/)
          HBASE-7986. [REST] Make HTablePool size configurable (binlijin) (Revision 1452771)

          Result = FAILURE
          apurtell :
          Files :

          • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
          hudson Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #12 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/12/ ) HBASE-7986 . [REST] Make HTablePool size configurable (binlijin) (Revision 1452771) Result = FAILURE apurtell : Files : /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
          hudson Hudson added a comment -

          Integrated in HBase-0.94-security #117 (See https://builds.apache.org/job/HBase-0.94-security/117/)
          HBASE-7986. [REST] Make HTablePool size configurable (binlijin) (Revision 1452772)

          Result = SUCCESS
          apurtell :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
          hudson Hudson added a comment - Integrated in HBase-0.94-security #117 (See https://builds.apache.org/job/HBase-0.94-security/117/ ) HBASE-7986 . [REST] Make HTablePool size configurable (binlijin) (Revision 1452772) Result = SUCCESS apurtell : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
          hudson Hudson added a comment -

          Integrated in HBase-0.94-security-on-Hadoop-23 #13 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/13/)
          HBASE-7986. [REST] Make HTablePool size configurable (binlijin) (Revision 1452772)

          Result = FAILURE
          apurtell :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
          hudson Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #13 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/13/ ) HBASE-7986 . [REST] Make HTablePool size configurable (binlijin) (Revision 1452772) Result = FAILURE apurtell : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java

          People

            binlijin Lijin Bin
            binlijin Lijin Bin
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: