[HBASE-7888] Simplify logic of SnapshotManager#getCompletedSnapshots() - ASF JIRA

Add vote

Voters

Watch issue

Watchers

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Sub-task
Status: Open
Priority: Major
Resolution: Unresolved
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None

Description

This came up during code review of mega patch.

isSnapshotCompleted() checks the existence of snapshotDir to see if the snapshot already exists.
getCompletedSnapshots(), on the other hand, reads SnapshotDescriptionUtils.SNAPSHOTINFO_FILE for the same purpose.

Since all the snapshot files are first created in a tmp dir and a rename is done to move them into the .snapshots dir upon completion, logic in getCompletedSnapshots() can be simplified.