Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-7290 Online snapshots
  3. HBASE-7888

Simplify logic of SnapshotManager#getCompletedSnapshots()

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Invalid
    • None
    • None
    • None
    • None

    Description

      This came up during code review of mega patch.

      isSnapshotCompleted() checks the existence of snapshotDir to see if the snapshot already exists.
      getCompletedSnapshots(), on the other hand, reads SnapshotDescriptionUtils.SNAPSHOTINFO_FILE for the same purpose.

      Since all the snapshot files are first created in a tmp dir and a rename is done to move them into the .snapshots dir upon completion, logic in getCompletedSnapshots() can be simplified.

      Attachments

        Activity

          People

            Unassigned Unassigned
            yuzhihong@gmail.com Ted Yu
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: