[HBASE-7878] recoverFileLease does not check return value of recoverLease

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.94.6, 0.95.0
• Fix Version/s: 0.98.0, 0.95.0
• Component/s: util
• Hadoop Flags: Reviewed
• Release Note: A new config parameter, hbase.lease.recovery.timeout, is introduced for the maximum duration recoverFileLease() would wait for any single file. Default is 5 minutes. If lease recovery doesn't succeed within this limit, append() would be called.
• Assignee: Ted Yu
• Reporter: Eric C. Newton
• Created: 19/Feb/13 14:18
• Updated: 23/Sep/13 18:30
• Resolved: 24/Mar/13 10:40

Description

I think this is a problem, so I'm opening a ticket so an HBase person takes a look.

Apache Accumulo has moved its write-ahead log to HDFS. I modeled the lease recovery for Accumulo after HBase's lease recovery. During testing, we experienced data loss. I found it is necessary to wait until recoverLease returns true to know that the file has been truly closed. In FSHDFSUtils, the return result of recoverLease is not checked. In the unit tests created to check lease recovery in HBASE-2645, the return result of recoverLease is always checked.

I think FSHDFSUtils should be modified to check the return result, and wait until it returns true.

Issue Links

• is related to: HBASE-8204 Don't use hdfs append during lease recovery
• is related to: HBASE-8321 Log split worker should heartbeat to avoid timeout when the hlog is under recovery
• is related to: HBASE-8670 [0.94] Backport HBASE-8449,HBASE-8204 and HBASE-8699 to 0.94 (Refactor recoverLease retries and pauses)
• relates to: HBASE-8354 Backport HBASE-7878 'recoverFileLease does not check return value of recoverLease' to 0.94