HBase
  1. HBase
  2. HBASE-7832

Use User.getShortName() in FSUtils

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.94.6
    • Fix Version/s: 0.94.6
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is 0.94. HBASE-7814 backports HBASE-6963, but I think it can be done in a cleaner way using o.a.h.hbase.User.

        Issue Links

          Activity

          Lars Hofhansl made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security-on-Hadoop-23 #12 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/12/)
          HBASE-7832. Use User.getShortName() in FSUtils (Revision 1446036)

          Result = FAILURE
          enis :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #12 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/12/ ) HBASE-7832 . Use User.getShortName() in FSUtils (Revision 1446036) Result = FAILURE enis : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security #111 (See https://builds.apache.org/job/HBase-0.94-security/111/)
          HBASE-7832. Use User.getShortName() in FSUtils (Revision 1446036)

          Result = SUCCESS
          enis :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security #111 (See https://builds.apache.org/job/HBase-0.94-security/111/ ) HBASE-7832 . Use User.getShortName() in FSUtils (Revision 1446036) Result = SUCCESS enis : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Enis Soztutar made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Enis Soztutar added a comment -

          Forgot to resolve the issue. Done now.

          Show
          Enis Soztutar added a comment - Forgot to resolve the issue. Done now.
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #841 (See https://builds.apache.org/job/HBase-0.94/841/)
          HBASE-7832. Use User.getShortName() in FSUtils (Revision 1446036)

          Result = FAILURE
          enis :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #841 (See https://builds.apache.org/job/HBase-0.94/841/ ) HBASE-7832 . Use User.getShortName() in FSUtils (Revision 1446036) Result = FAILURE enis : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12569118/hbase-7832_v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4439//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12569118/hbase-7832_v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4439//console This message is automatically generated.
          Enis Soztutar made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hadoop Flags Reviewed [ 10343 ]
          Hide
          Enis Soztutar added a comment -

          Committed this holy patch. Thanks Stack, Gary.

          Show
          Enis Soztutar added a comment - Committed this holy patch. Thanks Stack, Gary.
          Hide
          stack added a comment -

          +1 because it takes us closer to God (but more because of what Gary said).

          Show
          stack added a comment - +1 because it takes us closer to God (but more because of what Gary said).
          Hide
          Enis Soztutar added a comment -

          Is cleanliness (and taking us closer to godliness) the only motivation Enis Soztutar?

          Normally, I would advocate for reverting HBASE-7814 once again, and doing what this patch does. But since it was already reverted once, let's keep it, and apply this on top.

          That's what the User class is there for.

          Agreed.

          Show
          Enis Soztutar added a comment - Is cleanliness (and taking us closer to godliness) the only motivation Enis Soztutar? Normally, I would advocate for reverting HBASE-7814 once again, and doing what this patch does. But since it was already reverted once, let's keep it, and apply this on top. That's what the User class is there for. Agreed.
          Hide
          Gary Helmling added a comment -

          +1 to patch.

          That's what the User class is there for. User.getShortName() does also have an optimization in that it caches the obtained shortname. In profiling of the AccessController coprocessor, where this was called frequently, UserGroupInformation.getShortUserName() did show up with significant CPU usage, since it reconstructs the short name for every call from the stored credentials.

          Show
          Gary Helmling added a comment - +1 to patch. That's what the User class is there for. User.getShortName() does also have an optimization in that it caches the obtained shortname. In profiling of the AccessController coprocessor, where this was called frequently, UserGroupInformation.getShortUserName() did show up with significant CPU usage, since it reconstructs the short name for every call from the stored credentials.
          Hide
          stack added a comment -

          Patch looks cleaner. Is cleanliness (and taking us closer to godliness) the only motivation Enis Soztutar? Otherwise, leave well-enough alone I'd say.

          Show
          stack added a comment - Patch looks cleaner. Is cleanliness (and taking us closer to godliness) the only motivation Enis Soztutar ? Otherwise, leave well-enough alone I'd say.
          Enis Soztutar made changes -
          Link This issue is related to HBASE-7833 [ HBASE-7833 ]
          Enis Soztutar made changes -
          Attachment hbase-7832_v1.patch [ 12569118 ]
          Hide
          Enis Soztutar added a comment -

          Attaching simple patch.

          BTW, I am trying to compile tip of 0.94 with hadoop-0.20.205 and 0.22.0 without any success. Will open an issue for that.

          Show
          Enis Soztutar added a comment - Attaching simple patch. BTW, I am trying to compile tip of 0.94 with hadoop-0.20.205 and 0.22.0 without any success. Will open an issue for that.
          Enis Soztutar made changes -
          Field Original Value New Value
          Link This issue is related to HBASE-7814 [ HBASE-7814 ]
          Enis Soztutar created issue -

            People

            • Assignee:
              Enis Soztutar
              Reporter:
              Enis Soztutar
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development