-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12568924/HBASE-7829_94.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

-1 patch. The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4420//console

This message is automatically generated.

Oops.
How did this ever work correctly?

So how bad is this? Will this prevent secure operation? In that case I'll sink the current 0.94.5 RC.

It's not that bad, since the previous method of enabling zookeeper with security still works. No one has probably tried this new method else we would've seen a jira earlier.

94 patch will work on trunk as well.

yup, that's my fault.. looking at my configuration the values are swapped
+1 on the patch (for 0.94 and trunk), thanks!

Integrated to 0.94 and trunk.

Thanks for the patch, Francis.

Thanks for the reviews, Lars and Matteo.

Integrated in HBase-0.94 #838 (See https://builds.apache.org/job/HBase-0.94/838/)
HBASE-7829 zookeeper kerberos conf keytab and principal parameters interchanged (Francis) (Revision 1445211)

Result = FAILURE
tedyu :
Files :

• /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java

Thanks. This points to we are generally not testing security. I raised the priority of HBASE-7781 to critical and hope to have some time for it soon.

Integrated in HBase-TRUNK #3873 (See https://builds.apache.org/job/HBase-TRUNK/3873/)
HBASE-7829 zookeeper kerberos conf keytab and principal parameters interchanged (Francis) (Revision 1445213)

Result = FAILURE
tedyu :
Files :

• /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java

Integrated in HBase-0.94-security #110 (See https://builds.apache.org/job/HBase-0.94-security/110/)
HBASE-7829 zookeeper kerberos conf keytab and principal parameters interchanged (Francis) (Revision 1445211)

Result = SUCCESS
tedyu :
Files :

• /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #405 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/405/)
HBASE-7829 zookeeper kerberos conf keytab and principal parameters interchanged (Francis) (Revision 1445213)

Result = FAILURE
tedyu :
Files :

• /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java

Integrated in HBase-0.94-security-on-Hadoop-23 #12 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/12/)
HBASE-7829 zookeeper kerberos conf keytab and principal parameters interchanged (Francis) (Revision 1445211)

Result = FAILURE
tedyu :
Files :

• /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java