[HBASE-7658] grant with an empty string as permission should throw an exception

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.95.2
• Fix Version/s: 0.94.7, 0.95.1
• Component/s: security
• Assignee: Matteo Bertozzi
• Reporter: Matteo Bertozzi
• Created: 24/Jan/13 20:21
• Updated: 20/Aug/13 01:19
• Resolved: 10/Apr/13 22:53

Description

If someone specify an empty permission

grant 'user', ''

AccessControlLists.addUserPermission() output a log message and doesn't change the permission, but the user doesn't know about it.

if ((actions == null) || (actions.length == 0)) {
  LOG.warn("No actions associated with user '"+Bytes.toString(userPerm.getUser())+"'");
  return;
}

I think we should throw an exception instead of just logging.