HBase
  1. HBase
  2. HBASE-7564

[replication] Create interfaces for manipulation of replication state

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.96.0
    • Component/s: Replication
    • Labels:
      None

      Description

      Currently ReplicationZookeeper maintains all the zookeeper state for replication. This makes the class relatively large and slightly confusing. There are three major pieces of zookeeper state maintained for replication:

      1. The state of replication (i.e. whether replication is ENABLED or DISABLED on the cluster). This is held in the state znode.

      2. The set of slave (or peer) clusters that replication needs to ship edits to. This is held in the peer znode.

      3. The replication queues that keep track of which hlog files still need to be replicated. There is one queue for each replication source/peer cluster pair.

      Splitting each of these three pieces into their own interfaces will separate the implementation from the operations needed to manipulate replication state. This will allow easier unit testing of the replication logic and more flexibility for future implementations of how replication state is stored.

      The plan is to implement these changes as a series of patches (at least one for each of the three interfaces). The state interface will be first, since it is the most easily separable from the other two pieces.

      1. ReplicationRefactor-v2.pdf
        214 kB
        Chris Trezzo
      2. ReplicationRefactor.pdf
        217 kB
        Chris Trezzo

        Issue Links

          Activity

          Chris Trezzo created issue -
          Chris Trezzo made changes -
          Field Original Value New Value
          Description Currently ReplicationZookeeper maintains all the zookeeper state for replication. This makes the class relatively large and slightly confusing. There are three major pieces of zookeeper state maintained for replication:

          1. The state of replication (i.e. whether replication is ENABLED or DISABLED on the cluster). This is held in the state znode.

          2. The set of slave (or peer) clusters that replication needs to ship edits to. This is held in the peer znode.

          3. The replication queues that keep track of which hlog files still need to be replicated. There is one queue for each replication source/peer cluster pair.

          Splitting each of these three pieces into their own interfaces will separate the implementation from the operations needed to manipulate replication state. This will allow easier unit testing of the replication logic and more flexibility for future implementations of how replication state is stored.

          The plan is to implement these changes as a series of patches (at least one for each of the three interfaces). The state interface will be first, since it is the most separate from the other three pieces.
          Currently ReplicationZookeeper maintains all the zookeeper state for replication. This makes the class relatively large and slightly confusing. There are three major pieces of zookeeper state maintained for replication:

          1. The state of replication (i.e. whether replication is ENABLED or DISABLED on the cluster). This is held in the state znode.

          2. The set of slave (or peer) clusters that replication needs to ship edits to. This is held in the peer znode.

          3. The replication queues that keep track of which hlog files still need to be replicated. There is one queue for each replication source/peer cluster pair.

          Splitting each of these three pieces into their own interfaces will separate the implementation from the operations needed to manipulate replication state. This will allow easier unit testing of the replication logic and more flexibility for future implementations of how replication state is stored.

          The plan is to implement these changes as a series of patches (at least one for each of the three interfaces). The state interface will be first, since it is the most easily separable from the other two pieces.
          stack made changes -
          Fix Version/s 0.95.0 [ 12324094 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          Chris Trezzo made changes -
          Attachment ReplicationRefactor.pdf [ 12573986 ]
          Chris Trezzo made changes -
          Link This issue depends upon HBASE-7568 [ HBASE-7568 ]
          Chris Trezzo made changes -
          Link This issue depends upon HBASE-7567 [ HBASE-7567 ]
          Chris Trezzo made changes -
          Link This issue depends upon HBASE-8149 [ HBASE-8149 ]
          stack made changes -
          Fix Version/s 0.95.1 [ 12324288 ]
          Fix Version/s 0.95.0 [ 12324094 ]
          Chris Trezzo made changes -
          Attachment ReplicationRefactor-v2.pdf [ 12576888 ]
          Chris Trezzo made changes -
          Link This issue depends upon HBASE-8439 [ HBASE-8439 ]
          Chris Trezzo made changes -
          Link This issue depends upon HBASE-8440 [ HBASE-8440 ]
          Chris Trezzo made changes -
          Link This issue depends upon HBASE-8441 [ HBASE-8441 ]
          stack made changes -
          Fix Version/s 0.95.2 [ 12320040 ]
          Fix Version/s 0.95.1 [ 12324288 ]
          stack made changes -
          Fix Version/s 0.96.0 [ 12324822 ]
          Fix Version/s 0.95.2 [ 12320040 ]
          Chris Trezzo made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Chris Trezzo
              Reporter:
              Chris Trezzo
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development