HBase
  1. HBase
  2. HBASE-7488

Implement HConnectionManager.locateRegions which is currently returning null

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.95.0
    • Component/s: None
    • Hadoop Flags:
      Reviewed
    1. HBASE-7488-v0-trunk.patch
      1 kB
      Jean-Marc Spaggiari
    2. HBASE-7488-v0-0.94.patch
      1 kB
      Jean-Marc Spaggiari
    3. HBASE-7488-v1-trunk.patch
      5 kB
      Jean-Marc Spaggiari
    4. HBASE-7488-v2-trunk.patch
      5 kB
      Jean-Marc Spaggiari
    5. HBASE-7488-v3-trunk.patch
      5 kB
      Jean-Marc Spaggiari
    6. HBASE-7488-v4-trunk.patch
      4 kB
      Jean-Marc Spaggiari
    7. HBASE-7488-v5-trunk.patch
      4 kB
      Jean-Marc Spaggiari
    8. HBASE-7488-v6-trunk.patch
      4 kB
      Jean-Marc Spaggiari
    9. HBASE-7488-v6-0.94.patch
      4 kB
      Sergey Shelukhin
    10. HBASE-7488-v6-0.94.patch
      4 kB
      Sergey Shelukhin

      Issue Links

        Activity

        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #133 (See https://builds.apache.org/job/HBase-0.94-security/133/)
        HBASE-8274 Backport to 94: HBASE-7488 Implement HConnectionManager.locateRegions which is currently returning null (Revision 1465142)

        Result = SUCCESS
        sershe :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #133 (See https://builds.apache.org/job/HBase-0.94-security/133/ ) HBASE-8274 Backport to 94: HBASE-7488 Implement HConnectionManager.locateRegions which is currently returning null (Revision 1465142) Result = SUCCESS sershe : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnection.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #948 (See https://builds.apache.org/job/HBase-0.94/948/)
        HBASE-8274 Backport to 94: HBASE-7488 Implement HConnectionManager.locateRegions which is currently returning null (Revision 1465142)

        Result = FAILURE
        sershe :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #948 (See https://builds.apache.org/job/HBase-0.94/948/ ) HBASE-8274 Backport to 94: HBASE-7488 Implement HConnectionManager.locateRegions which is currently returning null (Revision 1465142) Result = FAILURE sershe : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnection.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Hide
        Sergey Shelukhin added a comment -

        Added HBASE-8274

        Show
        Sergey Shelukhin added a comment - Added HBASE-8274
        Hide
        Ted Yu added a comment -

        Since the 0.95 patch was integrated in Jan., I think we should open a new JIRA for backport.

        I am running 0.94 test suite now.

        Show
        Ted Yu added a comment - Since the 0.95 patch was integrated in Jan., I think we should open a new JIRA for backport. I am running 0.94 test suite now.
        Hide
        Sergey Shelukhin added a comment -

        latest patch for 94

        Show
        Sergey Shelukhin added a comment - latest patch for 94
        Hide
        Sergey Shelukhin added a comment -

        This is the root cause of the original intent of HBASE-8239 (chaosmonkey can never find server holding meta) so it is useful in 94.
        I will attach latest patch, rebased, shortly. Hopefully we can commit in this JIRA, I will open backport one if necessary

        Show
        Sergey Shelukhin added a comment - This is the root cause of the original intent of HBASE-8239 (chaosmonkey can never find server holding meta) so it is useful in 94. I will attach latest patch, rebased, shortly. Hopefully we can commit in this JIRA, I will open backport one if necessary
        Hide
        stack added a comment -

        Committed to 0.95 a while back.

        Doesn't look like it would be the end of the world if this was NOT in 0.94.

        Show
        stack added a comment - Committed to 0.95 a while back. Doesn't look like it would be the end of the world if this was NOT in 0.94.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563230/HBASE-7488-v6-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3880//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563230/HBASE-7488-v6-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3880//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #330 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/330/)
        HBASE-7488 Implement HConnectionManager.locateRegions which is currently returning null (Jean-Marc) (Revision 1428907)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #330 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/330/ ) HBASE-7488 Implement HConnectionManager.locateRegions which is currently returning null (Jean-Marc) (Revision 1428907) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnection.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3698 (See https://builds.apache.org/job/HBase-TRUNK/3698/)
        HBASE-7488 Implement HConnectionManager.locateRegions which is currently returning null (Jean-Marc) (Revision 1428907)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3698 (See https://builds.apache.org/job/HBase-TRUNK/3698/ ) HBASE-7488 Implement HConnectionManager.locateRegions which is currently returning null (Jean-Marc) (Revision 1428907) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnection.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Hide
        Ted Yu added a comment -

        Patch v6 integrated to trunk.

        Thanks for the patch, Jean-Marc.

        Thanks for the review, Matteo.

        @Lars:
        Do you want this in 0.94 as well ?

        Show
        Ted Yu added a comment - Patch v6 integrated to trunk. Thanks for the patch, Jean-Marc. Thanks for the review, Matteo. @Lars: Do you want this in 0.94 as well ?
        Hide
        Jean-Marc Spaggiari added a comment -

        Thanks. What's the next step? Should I create the same for 0.94?

        Show
        Jean-Marc Spaggiari added a comment - Thanks. What's the next step? Should I create the same for 0.94?
        Hide
        Matteo Bertozzi added a comment -

        v6 looks good to me

        Show
        Matteo Bertozzi added a comment - v6 looks good to me
        Hide
        Ted Yu added a comment -

        Patch v6 looks good.

        Show
        Ted Yu added a comment - Patch v6 looks good.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563230/HBASE-7488-v6-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563230/HBASE-7488-v6-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3847//console This message is automatically generated.
        Hide
        Jean-Marc Spaggiari added a comment -

        I put the comments in the wrong box (Release note) so I'm not sure where they are now.

        What I said was:
        Here is the last version.
        I have added back the missing final statements.
        I have "un-silenced" the IOException.
        Also added the useCache parameter.
        All comments are welcome.

        JM

        Show
        Jean-Marc Spaggiari added a comment - I put the comments in the wrong box (Release note) so I'm not sure where they are now. What I said was: Here is the last version. I have added back the missing final statements. I have "un-silenced" the IOException. Also added the useCache parameter. All comments are welcome. JM
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563205/HBASE-7488-v4-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.replication.TestReplication

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563205/HBASE-7488-v4-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3844//console This message is automatically generated.
        Hide
        Matteo Bertozzi added a comment -
            public List<HRegionLocation> locateRegions(final byte [] tableName)
            public List<HRegionLocation> locateRegions(byte[] tableName)
        

        tableName has lost a final, but doesn't changed in the method, and is just passed to another locateRegions() with the tableName as final. (just add it back)

              return parseRegionName(regionName)[1];
            } catch (IOException e) {
              LOG.error(
                "Error while retrieving the start key from region " + ytes.toStringBinary(regionName), e);
            }
        

        Not sure if we should be silent about that... the regioName is malformed and the request goes on with a null key, and the result probably is not the one expected.

        Show
        Matteo Bertozzi added a comment - public List<HRegionLocation> locateRegions( final byte [] tableName) public List<HRegionLocation> locateRegions( byte [] tableName) tableName has lost a final, but doesn't changed in the method, and is just passed to another locateRegions() with the tableName as final. (just add it back) return parseRegionName(regionName)[1]; } catch (IOException e) { LOG.error( "Error while retrieving the start key from region " + ytes.toStringBinary(regionName), e); } Not sure if we should be silent about that... the regioName is malformed and the request goes on with a null key, and the result probably is not the one expected.
        Hide
        Ted Yu added a comment -

        I think we should add variants of the methods that utilize cache.

        Show
        Ted Yu added a comment - I think we should add variants of the methods that utilize cache.
        Hide
        Jean-Marc Spaggiari added a comment -

        Update version to address all Ted's comments.

        Also, regarding locateRegions "costs", should we consider adding public HRegionLocation locateRegion(final byte[] regionName, boolean useCache) and public List<HRegionLocation> locateRegions(byte[] tableName, boolean useCache) to take advantage of the cache?

        Show
        Jean-Marc Spaggiari added a comment - Update version to address all Ted's comments. Also, regarding locateRegions "costs", should we consider adding public HRegionLocation locateRegion(final byte[] regionName, boolean useCache) and public List<HRegionLocation> locateRegions(byte[] tableName, boolean useCache) to take advantage of the cache?
        Hide
        Ted Yu added a comment -
        +      e.printStackTrace();
        +      LOG.error("Error while retrieving the start key from region " + Bytes.toStringBinary(regionName), e);
        

        You can omit the printStackTrace() call - the error log would reveal information.
        The error log exceeds 100 characters.

        +      return locateRegion(HRegionInfo.getTableName(regionName), HRegionInfo.getStartKey(regionName), false, true);
        

        Wrap long line above.

        +     */
        +    public List<HRegionLocation> locateRegions(byte[] tableName)
        

        Add @Override for the above method.
        There is no need to repeat javadoc when @Override is present.

        Please also note that locateRegions() are expensive methods.

        Show
        Ted Yu added a comment - + e.printStackTrace(); + LOG.error( "Error while retrieving the start key from region " + Bytes.toStringBinary(regionName), e); You can omit the printStackTrace() call - the error log would reveal information. The error log exceeds 100 characters. + return locateRegion(HRegionInfo.getTableName(regionName), HRegionInfo.getStartKey(regionName), false , true ); Wrap long line above. + */ + public List<HRegionLocation> locateRegions( byte [] tableName) Add @Override for the above method. There is no need to repeat javadoc when @Override is present. Please also note that locateRegions() are expensive methods.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563157/HBASE-7488-v3-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces lines longer than 100

        -1 core tests. The patch failed these unit tests:

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563157/HBASE-7488-v3-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3839//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563144/HBASE-7488-v2-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.TestLocalHBaseCluster

        -1 core zombie tests. There are 5 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563144/HBASE-7488-v2-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestLocalHBaseCluster -1 core zombie tests . There are 5 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3835//console This message is automatically generated.
        Hide
        Jean-Marc Spaggiari added a comment -

        Updated version for HRegion.getStartKey calling parseRegionName instead of implementing it's own code.

        Show
        Jean-Marc Spaggiari added a comment - Updated version for HRegion.getStartKey calling parseRegionName instead of implementing it's own code.
        Hide
        Jean-Marc Spaggiari added a comment -

        Applied Matteo's comments.

        Show
        Jean-Marc Spaggiari added a comment - Applied Matteo's comments.
        Hide
        Jean-Marc Spaggiari added a comment -

        I did not used it because I missed it

        I will update my code to use it.

        Also, getTableName is not using it. Should I update it too to use parseRegionName? I don't think it's really required.

        Show
        Jean-Marc Spaggiari added a comment - I did not used it because I missed it I will update my code to use it. Also, getTableName is not using it. Should I update it too to use parseRegionName? I don't think it's really required.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563137/HBASE-7488-v1-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestHCM

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563137/HBASE-7488-v1-trunk.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestHCM -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3833//console This message is automatically generated.
        Hide
        Matteo Bertozzi added a comment -

        why don't you call parseRegionName()? or share some code with it?

        Show
        Matteo Bertozzi added a comment - why don't you call parseRegionName()? or share some code with it?
        Hide
        Jean-Marc Spaggiari added a comment -

        HRegionInfo, HConnectionManager and HConnection modifications included in this patch.

        Show
        Jean-Marc Spaggiari added a comment - HRegionInfo, HConnectionManager and HConnection modifications included in this patch.
        Hide
        Jean-Marc Spaggiari added a comment -

        Improved version with update locateRegion(final byte[] regionName) implementation. Now using HRegionInfo.getStartKey (also included in this patch).

        Show
        Jean-Marc Spaggiari added a comment - Improved version with update locateRegion(final byte[] regionName) implementation. Now using HRegionInfo.getStartKey (also included in this patch).
        Hide
        Jean-Marc Spaggiari added a comment -

        Added the updated interface to pass the offlined parameters, and the method implementation too. Also implemented locateRegion(final byte[] regionName).

        Show
        Jean-Marc Spaggiari added a comment - Added the updated interface to pass the offlined parameters, and the method implementation too. Also implemented locateRegion(final byte[] regionName).
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563122/HBASE-7488-v0-0.94.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3827//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563122/HBASE-7488-v0-0.94.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3827//console This message is automatically generated.
        Hide
        Jean-Marc Spaggiari added a comment -

        HConnectionManager.locateRegions is currently returning null. Goal of this patch is to implement this call.

        Show
        Jean-Marc Spaggiari added a comment - HConnectionManager.locateRegions is currently returning null. Goal of this patch is to implement this call.

          People

          • Assignee:
            Jean-Marc Spaggiari
            Reporter:
            Jean-Marc Spaggiari
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development