Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-7263 Investigate more fine grained locking for checkAndPut/append/increment
  3. HBASE-7315

Remove support for client-side RowLocks

        Details

        • Type: Sub-task
        • Status: Closed
        • Priority: Critical
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.95.0
        • Component/s: Transactions/MVCC
        • Labels:
          None
        • Hadoop Flags:
          Incompatible change, Reviewed
        • Release Note:
          Removes API that allowed client to grab and hold and then later release a rowlock: e.g. HTable#lockRow and HTable#unlockRow. It was a bad idea.
        • Tags:
          0.96notable

          Description

          See comments in HBASE-7263.

          1. Text File
            HBASE-7315-v7.patch
            291 kB
            Gregory Chanan
          2. Text File
            HBASE-7315-v6.patch
            292 kB
            Gregory Chanan
          3. Text File
            HBASE-7315-v5.patch
            298 kB
            Gregory Chanan
          4. Text File
            HBASE-7315-v4.patch
            295 kB
            Gregory Chanan
          5. Text File
            HBASE-7315-v3.patch
            294 kB
            Gregory Chanan
          6. Text File
            HBASE-7315-v2.patch
            222 kB
            Gregory Chanan
          7. Text File
            HBASE-7315.patch
            222 kB
            Gregory Chanan

            Issue Links

            relates to

            Improvement - An improvement or enhancement to an existing feature or task. HBASE-2332 Remove client-exposed row locks from region server

            • Major - Major loss of function.
            • Resolved

            Task - A task that needs to be done. HBASE-7341 Deprecate RowLocks in 0.94

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Closed

              Activity

              Descending order - Click to sort in ascending order
              Hide
              Permalink
              stack stack added a comment -

              Marking closed.

              Show
              stack stack added a comment - Marking closed.
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #362 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/362/)
              HBASE-7315 Remove support for client-side RowLocks (Revision 1435747)

              Result = FAILURE
              stack :
              Files :

              • /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/BulkDeleteEndpoint.java
              • /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
              • /hbase/trunk/hbase-protocol/src/main/protobuf/Client.proto
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/UnknownRowLockException.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Delete.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Get.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTable.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Increment.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Put.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/RowLock.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RowResource.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HMerge.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/Merge.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/MetaUtils.java
              • /hbase/trunk/hbase-server/src/main/ruby/hbase/table.rb
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestEncodedSeekers.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinVersions.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestParallelPut.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestResettingCounters.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java
              Show
              hudson Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #362 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/362/ ) HBASE-7315 Remove support for client-side RowLocks (Revision 1435747) Result = FAILURE stack : Files : /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/BulkDeleteEndpoint.java /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java /hbase/trunk/hbase-protocol/src/main/protobuf/Client.proto /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/UnknownRowLockException.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Delete.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Get.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTable.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Increment.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Mutation.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Put.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/RowLock.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RowResource.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HMerge.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/Merge.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/MetaUtils.java /hbase/trunk/hbase-server/src/main/ruby/hbase/table.rb /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestEncodedSeekers.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinVersions.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestParallelPut.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestResettingCounters.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in HBase-TRUNK #3770 (See https://builds.apache.org/job/HBase-TRUNK/3770/)
              HBASE-7315 Remove support for client-side RowLocks (Revision 1435747)

              Result = FAILURE
              stack :
              Files :

              • /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/BulkDeleteEndpoint.java
              • /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
              • /hbase/trunk/hbase-protocol/src/main/protobuf/Client.proto
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/UnknownRowLockException.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Delete.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Get.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTable.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Increment.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Put.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/RowLock.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RowResource.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HMerge.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/Merge.java
              • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/MetaUtils.java
              • /hbase/trunk/hbase-server/src/main/ruby/hbase/table.rb
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestEncodedSeekers.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinVersions.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestParallelPut.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestResettingCounters.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
              • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java
              Show
              hudson Hudson added a comment - Integrated in HBase-TRUNK #3770 (See https://builds.apache.org/job/HBase-TRUNK/3770/ ) HBASE-7315 Remove support for client-side RowLocks (Revision 1435747) Result = FAILURE stack : Files : /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/BulkDeleteEndpoint.java /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java /hbase/trunk/hbase-protocol/src/main/protobuf/Client.proto /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/UnknownRowLockException.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Delete.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Get.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTable.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Increment.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Mutation.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Put.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/RowLock.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RowResource.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HMerge.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/Merge.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/MetaUtils.java /hbase/trunk/hbase-server/src/main/ruby/hbase/table.rb /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestEncodedSeekers.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHBase7051.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinVersions.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestParallelPut.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestResettingCounters.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java
              Hide
              Permalink
              stack stack added a comment -

              Pardon me. I got impatient and I like closing criticals so I went and committed it. Thanks G.

              Show
              stack stack added a comment - Pardon me. I got impatient and I like closing criticals so I went and committed it. Thanks G.
              Hide
              Permalink
              eclark Elliott Clark added a comment -

              +1

              Show
              eclark Elliott Clark added a comment - +1
              Hide
              Permalink
              stack stack added a comment -

              +1

              Nice surgery G. Thorough. Let me know if you want me to commit it.

              Show
              stack stack added a comment - +1 Nice surgery G. Thorough. Let me know if you want me to commit it.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12565620/HBASE-7315-v7.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 88 new or modified tests.

              +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 lineLengths. The patch introduces lines longer than 100

              +1 core tests. The patch passed unit tests in .

              Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4098//testReport/
              Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4098//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565620/HBASE-7315-v7.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 88 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4098//testReport/ Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4098//console This message is automatically generated.
              Hide
              Permalink
              gchanan Gregory Chanan added a comment -

              Updated version for new trunk. Tests that failed last time passed locally – let's try HadoopQA again.

              Show
              gchanan Gregory Chanan added a comment - Updated version for new trunk. Tests that failed last time passed locally – let's try HadoopQA again.
              Hide
              Permalink
              stack stack added a comment -

              Marking critical so we don't forget about it.

              Show
              stack stack added a comment - Marking critical so we don't forget about it.
              Hide
              Permalink
              stack stack added a comment -

              Gregory Chanan You think above failures are because of your patch? Would it take much to get this in? Would be sweet to have this in trunk. Good on you.

              Show
              stack stack added a comment - Gregory Chanan You think above failures are because of your patch? Would it take much to get this in? Would be sweet to have this in trunk. Good on you.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12562630/HBASE-7315-v6.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 88 new or modified tests.

              +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

              -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 lineLengths. The patch introduces lines longer than 100

              -1 core tests. The patch failed these unit tests:
              org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
              org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed
              org.apache.hadoop.hbase.replication.TestReplication
              org.apache.hadoop.hbase.regionserver.wal.TestWALReplay
              org.apache.hadoop.hbase.TestRegionRebalancing

              -1 core zombie tests. There are 2 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83)

              Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//testReport/
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
              Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12562630/HBASE-7315-v6.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 88 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestMultiSlaveReplication org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.regionserver.wal.TestWALReplay org.apache.hadoop.hbase.TestRegionRebalancing -1 core zombie tests . There are 2 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3743//console This message is automatically generated.
              Hide
              Permalink
              gchanan Gregory Chanan added a comment -

              v5 no longer applies, here's a v6.

              Show
              gchanan Gregory Chanan added a comment - v5 no longer applies, here's a v6.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12561077/HBASE-7315-v5.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 91 new or modified tests.

              +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

              +1 javadoc. The javadoc tool did not generate any additional warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              -1 findbugs. The patch appears to introduce 26 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed these unit tests:
              org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
              org.apache.hadoop.hbase.regionserver.TestStore

              -1 core zombie tests. There are zombie tests. See build logs for details.

              Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//testReport/
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
              Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12561077/HBASE-7315-v5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 91 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any additional warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 26 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks org.apache.hadoop.hbase.regionserver.TestStore -1 core zombie tests . There are zombie tests. See build logs for details. Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3558//console This message is automatically generated.
              Hide
              Permalink
              gchanan Gregory Chanan added a comment -

              Thanks for the review.

              TestAccessController has a new import since you uploaded your patch.

              Thanks, will fix in new version

              # HRegion#getLock doesn't appear to have any where that the first parameter is ever used.

              BatchOperationInProgress doesn't need to take in pairs anymore, as far as I can see

              checkAndMutate needs it, because it holds the row lock over the entire (check, mutate) operation. So the mutate part needs to take an existing rowlock.

              Show
              gchanan Gregory Chanan added a comment - Thanks for the review. TestAccessController has a new import since you uploaded your patch. Thanks, will fix in new version # HRegion#getLock doesn't appear to have any where that the first parameter is ever used. BatchOperationInProgress doesn't need to take in pairs anymore, as far as I can see checkAndMutate needs it, because it holds the row lock over the entire (check, mutate) operation. So the mutate part needs to take an existing rowlock.
              Hide
              Permalink
              eclark Elliott Clark added a comment -

              Thanks for removing the NullType.

              • TestAccessController has a new import since you uploaded your patch.
              • HRegion#getLock doesn't appear to have any where that the first parameter is ever used.
              • BatchOperationInProgress doesn't need to take in pairs anymore, as far as I can see.
              Show
              eclark Elliott Clark added a comment - Thanks for removing the NullType. TestAccessController has a new import since you uploaded your patch. HRegion#getLock doesn't appear to have any where that the first parameter is ever used. BatchOperationInProgress doesn't need to take in pairs anymore, as far as I can see.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12560905/HBASE-7315-v4.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 88 new or modified tests.

              +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

              +1 javadoc. The javadoc tool did not generate any additional warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              -1 findbugs. The patch appears to introduce 21 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              +1 core tests. The patch passed unit tests in .

              Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//testReport/
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
              Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12560905/HBASE-7315-v4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 88 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any additional warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 21 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3541//console This message is automatically generated.
              Hide
              Permalink
              gchanan Gregory Chanan added a comment -

              TestShell failure is reproducible, I'm taking a look.

              Show
              gchanan Gregory Chanan added a comment - TestShell failure is reproducible, I'm taking a look.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12560857/HBASE-7315-v3.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 88 new or modified tests.

              +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

              -1 javadoc. The javadoc tool appears to have generated 104 warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              -1 findbugs. The patch appears to introduce 21 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed these unit tests:
              org.apache.hadoop.hbase.client.TestShell

              Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//testReport/
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
              Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12560857/HBASE-7315-v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 88 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 104 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 21 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestShell Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3535//console This message is automatically generated.
              Hide
              Permalink
              gchanan Gregory Chanan added a comment -

              Here is a version with the NullTypes removed.

              Show
              gchanan Gregory Chanan added a comment - Attached HBASE-7315 -v3.patch * Here is a version with the NullTypes removed.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12560447/HBASE-7315-v2.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 18 new or modified tests.

              +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

              -1 javadoc. The javadoc tool appears to have generated 105 warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              -1 findbugs. The patch appears to introduce 21 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              +1 core tests. The patch passed unit tests in .

              Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//testReport/
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
              Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12560447/HBASE-7315-v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 18 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 105 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 21 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3492//console This message is automatically generated.
              Hide
              Permalink
              lhofhansl Lars Hofhansl added a comment -

              Can we even remove the NullType from Increment, Append, etc. It's fine to break client code I think, and leaving this around is just going to be confusing.

              Show
              lhofhansl Lars Hofhansl added a comment - Can we even remove the NullType from Increment, Append, etc. It's fine to break client code I think, and leaving this around is just going to be confusing.
              Hide
              Permalink
              gchanan Gregory Chanan added a comment -

              I sent an e-mail to the dev list discussing the change. If there isn't objection over there, I'll commit after addressing your nit.

              Show
              gchanan Gregory Chanan added a comment - I sent an e-mail to the dev list discussing the change. If there isn't objection over there, I'll commit after addressing your nit.
              Hide
              Permalink
              eclark Elliott Clark added a comment -
              • Very Minor Nit: In Hregion#checkAndMutate you create a get, passing a null. Since the null's always ignored it might be cleaner to use the other constructor. But whatever you think.

              +1 looks good to me.

              Show
              eclark Elliott Clark added a comment - Very Minor Nit: In Hregion#checkAndMutate you create a get, passing a null. Since the null's always ignored it might be cleaner to use the other constructor. But whatever you think. +1 looks good to me.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12560447/HBASE-7315-v2.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 18 new or modified tests.

              +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

              -1 javadoc. The javadoc tool appears to have generated 105 warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              -1 findbugs. The patch appears to introduce 21 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              +1 core tests. The patch passed unit tests in .

              Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//testReport/
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
              Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12560447/HBASE-7315-v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 18 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 105 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 21 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3489//console This message is automatically generated.
              Hide
              Permalink
              gchanan Gregory Chanan added a comment -

              Yeah I would vote for removing the NullTypes when possible. It seems like we have the ability to break compatibility very rarely so we should use that to clean up what we can.

              Thanks for the input. Happy to do that in a later JIRA if this goes in.

              Show
              gchanan Gregory Chanan added a comment - Yeah I would vote for removing the NullTypes when possible. It seems like we have the ability to break compatibility very rarely so we should use that to clean up what we can. Thanks for the input. Happy to do that in a later JIRA if this goes in.
              Hide
              Permalink
              eclark Elliott Clark added a comment -

              Yeah I would vote for removing the NullTypes when possible. It seems like we have the ability to break compatibility very rarely so we should use that to clean up what we can.

              Show
              eclark Elliott Clark added a comment - Yeah I would vote for removing the NullTypes when possible. It seems like we have the ability to break compatibility very rarely so we should use that to clean up what we can.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12560314/HBASE-7315.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 18 new or modified tests.

              -1 patch. The patch command could not apply the patch.

              Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3488//console

              This message is automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12560314/HBASE-7315.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 18 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3488//console This message is automatically generated.
              Hide
              Permalink
              gchanan Gregory Chanan added a comment -

              Removes support for user-level RowLocks.

              I tried to minimize the changes to the interfaces as follows:

              • On the client side, replaces instances of RowLock with NullType. This is so that client code that only passed in a null RowLock, e.g. Get get = new Get(row, null) will still work.
              • On the server side, replaces instances of "Integer lockId" with NullType in the public methods of HRegion. This is so that coprocessors that call into HRegion directly will still function as long as they passed in "null" as the lockId.

              This also means it was easier to not change all the tests . If it is preferred, I can do a follow on issue that removes the NullTypes.

              Show
              gchanan Gregory Chanan added a comment - attached HBASE-7315 .patch * Removes support for user-level RowLocks. I tried to minimize the changes to the interfaces as follows: On the client side, replaces instances of RowLock with NullType. This is so that client code that only passed in a null RowLock, e.g. Get get = new Get(row, null) will still work. On the server side, replaces instances of "Integer lockId" with NullType in the public methods of HRegion. This is so that coprocessors that call into HRegion directly will still function as long as they passed in "null" as the lockId. This also means it was easier to not change all the tests . If it is preferred, I can do a follow on issue that removes the NullTypes.

                People

                • Assignee:
                  gchanan Gregory Chanan
                  Reporter:
                  gchanan Gregory Chanan
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  10 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development