HBase
  1. HBase
  2. HBASE-7299

TestMultiParallel fails intermittently in trunk builds

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      From trunk build #3598:

       testFlushCommitsNoAbort(org.apache.hadoop.hbase.client.TestMultiParallel): Count of regions=8
      

      It failed in 3595 as well:

      java.lang.AssertionError: Server count=2, abort=true expected:<1> but was:<2>
      	at org.junit.Assert.fail(Assert.java:93)
      	at org.junit.Assert.failNotEquals(Assert.java:647)
      	at org.junit.Assert.assertEquals(Assert.java:128)
      	at org.junit.Assert.assertEquals(Assert.java:472)
      	at org.apache.hadoop.hbase.client.TestMultiParallel.doTestFlushCommits(TestMultiParallel.java:267)
      	at org.apache.hadoop.hbase.client.TestMultiParallel.testFlushCommitsWithAbort(TestMultiParallel.java:226)
      
      1. HBASE-7299.patch
        1 kB
        chunhui shen
      2. HBASE-7299v2.patch
        1 kB
        chunhui shen
      3. HBASE-7299v3.patch
        2 kB
        chunhui shen
      4. 7299-v4.txt
        2 kB
        Ted Yu
      5. 7299.addendum
        0.8 kB
        Ted Yu
      6. 7299-addendum2.patch
        3 kB
        chunhui shen
      7. 7299-addendum.v3
        3 kB
        Ted Yu
      8. 7299-addendumv3.txt
        3 kB
        chunhui shen
      9. 7299-addendumv4.patch
        2 kB
        chunhui shen

        Activity

        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #360 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/360/)
        HBASE-7299 TestMultiParallel fails intermittently in trunk builds, addendum 4 (Chunhui) (Revision 1435301)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #360 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/360/ ) HBASE-7299 TestMultiParallel fails intermittently in trunk builds, addendum 4 (Chunhui) (Revision 1435301) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3766 (See https://builds.apache.org/job/HBase-TRUNK/3766/)
        HBASE-7299 TestMultiParallel fails intermittently in trunk builds, addendum 4 (Chunhui) (Revision 1435301)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3766 (See https://builds.apache.org/job/HBase-TRUNK/3766/ ) HBASE-7299 TestMultiParallel fails intermittently in trunk builds, addendum 4 (Chunhui) (Revision 1435301) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Hide
        Ted Yu added a comment -

        Addendum v2 integrated to trunk.

        Show
        Ted Yu added a comment - Addendum v2 integrated to trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12565261/7299-addendumv4.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestHTableMultiplexer

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565261/7299-addendumv4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestHTableMultiplexer Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4072//console This message is automatically generated.
        Hide
        stack added a comment -

        Should probably be in a new issue at this stage in the game – so much time has elapsed since last patches applied against this issue.

        Show
        stack added a comment - Should probably be in a new issue at this stage in the game – so much time has elapsed since last patches applied against this issue.
        Hide
        stack added a comment -

        Addendum looks good to me chunhui shen. See how hadoopqa goes and then commit if all is well.

        Show
        stack added a comment - Addendum looks good to me chunhui shen . See how hadoopqa goes and then commit if all is well.
        Hide
        chunhui shen added a comment -

        TestMultiParallel#testActiveThreadsCount failed in recent building

        From
        https://builds.apache.org/job/PreCommit-HBASE-Build/4051/testReport/junit/org.apache.hadoop.hbase.client/TestMultiParallel/testActiveThreadsCount/

        I found one reason:

        testActiveThreadsCount(){
        ...
        table.batch(puts);
        ThreadPoolExecutor tExecutor = (ThreadPoolExecutor) poolField.get(table);
            assertEquals(slaves, tExecutor.getLargestPoolSize());
        ...
        }
        

        Here slaves=2,
        Though there are 2 live regionservers, if all regions are on one server, there will only one pool to execute table.batch(). So assertEquals(slaves, tExecutor.getLargestPoolSize()) is failed.

        From the logs,

        2013-01-16 19:41:15,642 DEBUG [IPC Server handler 2 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1902; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region {
        2013-01-16 19:41:15,646 DEBUG [IPC Server handler 4 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1903; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region {
        2013-01-16 19:41:15,650 DEBUG [IPC Server handler 0 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1904; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region {
        2013-01-16 19:41:15,652 DEBUG [IPC Server handler 1 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1905; served=ClientProtocol#multi, queueTime=0, processingTime=1, request=region {
        2013-01-16 19:41:15,657 DEBUG [IPC Server handler 3 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1906; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region {
        2013-01-16 19:41:15,660 DEBUG [IPC Server handler 2 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1907; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region {
        2013-01-16 19:41:15,664 DEBUG [IPC Server handler 4 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1908; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region {
        2013-01-16 19:41:15,668 DEBUG [IPC Server handler 0 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1909; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region {
        2013-01-16 19:41:15,672 DEBUG [IPC Server handler 1 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1910; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region {
        2013-01-16 19:41:15,675 DEBUG [IPC Server handler 3 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1911; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region {
        2013-01-16 19:41:15,678 DEBUG [IPC Server handler 2 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1912; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region {
        2013-01-16 19:41:15,682 DEBUG [IPC Server handler 4 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1913; served=ClientProtocol#multi, queueTime=0, processingTime=1, request=region {
        2013-01-16 19:41:15,685 DEBUG [IPC Server handler 0 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1914; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region {
        2013-01-16 19:41:15,689 DEBUG [IPC Server handler 1 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1915; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region {
        2013-01-16 19:41:15,692 DEBUG [IPC Server handler 3 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1916; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region {
        2013-01-16 19:41:15,696 DEBUG [IPC Server handler 2 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1917; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region {
        2013-01-16 19:41:15,699 DEBUG [IPC Server handler 4 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1918; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region {
        2013-01-16 19:41:15,703 DEBUG [IPC Server handler 0 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1919; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region {
        2013-01-16 19:41:15,705 DEBUG [IPC Server handler 1 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1920; served=ClientProtocol#multi, queueTime=0, processingTime=1, request=region {
        2013-01-16 19:41:15,709 DEBUG [IPC Server handler 3 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1921; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region {
        2013-01-16 19:41:15,713 DEBUG [IPC Server handler 2 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1922; served=ClientProtocol#multi, queueTime=0, processingTime=1, request=region {
        2013-01-16 19:41:15,716 DEBUG [IPC Server handler 4 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1923; served=ClientProtocol#multi, queueTime=0, processingTime=1, request=region {
        2013-01-16 19:41:15,720 DEBUG [IPC Server handler 0 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1924; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region {
        2013-01-16 19:41:15,723 DEBUG [IPC Server handler 1 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1925; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region {
        2013-01-16 19:41:15,727 DEBUG [IPC Server handler 3 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1926; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region {
        

        I found all the rpc are on the server with port 50914.

        Show
        chunhui shen added a comment - TestMultiParallel#testActiveThreadsCount failed in recent building From https://builds.apache.org/job/PreCommit-HBASE-Build/4051/testReport/junit/org.apache.hadoop.hbase.client/TestMultiParallel/testActiveThreadsCount/ I found one reason: testActiveThreadsCount(){ ... table.batch(puts); ThreadPoolExecutor tExecutor = (ThreadPoolExecutor) poolField.get(table); assertEquals(slaves, tExecutor.getLargestPoolSize()); ... } Here slaves=2, Though there are 2 live regionservers, if all regions are on one server, there will only one pool to execute table.batch(). So assertEquals(slaves, tExecutor.getLargestPoolSize()) is failed. From the logs, 2013-01-16 19:41:15,642 DEBUG [IPC Server handler 2 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1902; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region { 2013-01-16 19:41:15,646 DEBUG [IPC Server handler 4 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1903; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region { 2013-01-16 19:41:15,650 DEBUG [IPC Server handler 0 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1904; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region { 2013-01-16 19:41:15,652 DEBUG [IPC Server handler 1 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1905; served=ClientProtocol#multi, queueTime=0, processingTime=1, request=region { 2013-01-16 19:41:15,657 DEBUG [IPC Server handler 3 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1906; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region { 2013-01-16 19:41:15,660 DEBUG [IPC Server handler 2 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1907; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region { 2013-01-16 19:41:15,664 DEBUG [IPC Server handler 4 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1908; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region { 2013-01-16 19:41:15,668 DEBUG [IPC Server handler 0 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1909; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region { 2013-01-16 19:41:15,672 DEBUG [IPC Server handler 1 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1910; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region { 2013-01-16 19:41:15,675 DEBUG [IPC Server handler 3 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1911; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region { 2013-01-16 19:41:15,678 DEBUG [IPC Server handler 2 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1912; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region { 2013-01-16 19:41:15,682 DEBUG [IPC Server handler 4 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1913; served=ClientProtocol#multi, queueTime=0, processingTime=1, request=region { 2013-01-16 19:41:15,685 DEBUG [IPC Server handler 0 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1914; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region { 2013-01-16 19:41:15,689 DEBUG [IPC Server handler 1 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1915; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region { 2013-01-16 19:41:15,692 DEBUG [IPC Server handler 3 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1916; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region { 2013-01-16 19:41:15,696 DEBUG [IPC Server handler 2 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1917; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region { 2013-01-16 19:41:15,699 DEBUG [IPC Server handler 4 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1918; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region { 2013-01-16 19:41:15,703 DEBUG [IPC Server handler 0 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1919; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region { 2013-01-16 19:41:15,705 DEBUG [IPC Server handler 1 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1920; served=ClientProtocol#multi, queueTime=0, processingTime=1, request=region { 2013-01-16 19:41:15,709 DEBUG [IPC Server handler 3 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1921; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region { 2013-01-16 19:41:15,713 DEBUG [IPC Server handler 2 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1922; served=ClientProtocol#multi, queueTime=0, processingTime=1, request=region { 2013-01-16 19:41:15,716 DEBUG [IPC Server handler 4 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1923; served=ClientProtocol#multi, queueTime=0, processingTime=1, request=region { 2013-01-16 19:41:15,720 DEBUG [IPC Server handler 0 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1924; served=ClientProtocol#multi, queueTime=1, processingTime=1, request=region { 2013-01-16 19:41:15,723 DEBUG [IPC Server handler 1 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1925; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region { 2013-01-16 19:41:15,727 DEBUG [IPC Server handler 3 on 50914] ipc.ProtobufRpcServerEngine$Server(209): Call #1926; served=ClientProtocol#multi, queueTime=0, processingTime=2, request=region { I found all the rpc are on the server with port 50914.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3717 (See https://builds.apache.org/job/HBase-TRUNK/3717/)
        HBASE-7299 TestMultiParallel fails intermittently in trunk builds, addendum 3 (Revision 1431138)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3717 (See https://builds.apache.org/job/HBase-TRUNK/3717/ ) HBASE-7299 TestMultiParallel fails intermittently in trunk builds, addendum 3 (Revision 1431138) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #338 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/338/)
        HBASE-7299 TestMultiParallel fails intermittently in trunk builds, addendum 3 (Revision 1431138)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #338 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/338/ ) HBASE-7299 TestMultiParallel fails intermittently in trunk builds, addendum 3 (Revision 1431138) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Hide
        Ted Yu added a comment -

        Integrated 7299-addendumv3.txt

        Show
        Ted Yu added a comment - Integrated 7299-addendumv3.txt
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563262/7299-addendumv3.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.replication.TestReplication

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563262/7299-addendumv3.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3855//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563029/7299-addendum2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.coprocessor.TestMasterObserver
        org.apache.hadoop.hbase.coprocessor.TestAggregateProtocol
        org.apache.hadoop.hbase.mapred.TestTableInputFormat
        org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed
        org.apache.hadoop.hbase.io.encoding.TestChangingEncoding
        org.apache.hadoop.hbase.client.TestHTableUtil
        org.apache.hadoop.hbase.coprocessor.TestClassLoading
        org.apache.hadoop.hbase.rest.TestScannersWithFilters
        org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort
        org.apache.hadoop.hbase.master.handler.TestTableDeleteFamilyHandler
        org.apache.hadoop.hbase.master.TestMasterNoCluster
        org.apache.hadoop.hbase.mapreduce.TestImportExport
        org.apache.hadoop.hbase.util.TestMergeTool
        org.apache.hadoop.hbase.security.access.TestTablePermissions
        org.apache.hadoop.hbase.TestZooKeeper
        org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove
        org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher
        org.apache.hadoop.hbase.util.TestIdLock
        org.apache.hadoop.hbase.client.TestClientTimeouts
        org.apache.hadoop.hbase.TestHBaseTestingUtility
        org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap
        org.apache.hadoop.hbase.client.TestMultiParallel
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase
        org.apache.hadoop.hbase.security.access.TestAccessControlFilter
        org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
        org.apache.hadoop.hbase.regionserver.TestHRegion
        org.apache.hadoop.hbase.client.TestTimestampsFilter
        org.apache.hadoop.hbase.util.TestRegionSplitter
        org.apache.hadoop.hbase.catalog.TestMetaMigrationConvertingToPB
        org.apache.hadoop.hbase.client.TestMetaScanner
        org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass
        org.apache.hadoop.hbase.client.TestAdmin
        org.apache.hadoop.hbase.client.TestMultipleTimestamps
        org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster
        org.apache.hadoop.hbase.master.TestMasterMetricsWrapper
        org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
        org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient
        org.apache.hadoop.hbase.TestAcidGuarantees
        org.apache.hadoop.hbase.master.TestRollingRestart
        org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding
        org.apache.hadoop.hbase.rest.TestStatusResource
        org.apache.hadoop.hbase.mapreduce.TestWALPlayer
        org.apache.hadoop.hbase.client.TestScannersFromClientSide
        org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove
        org.apache.hadoop.hbase.master.TestMasterTransitions
        org.apache.hadoop.hbase.client.TestScannerTimeout
        org.apache.hadoop.hbase.client.TestClientScannerRPCTimeout
        org.apache.hadoop.hbase.util.TestMergeTable
        org.apache.hadoop.hbase.TestRegionRebalancing
        org.apache.hadoop.hbase.client.TestShell
        org.apache.hadoop.hbase.master.TestRestartCluster
        org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
        org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithAbort
        org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel
        org.apache.hadoop.hbase.TestDrainingServer
        org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential
        org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit
        org.apache.hadoop.hbase.master.TestMasterFileSystem
        org.apache.hadoop.hbase.master.TestZKBasedOpenCloseRegion
        org.apache.hadoop.hbase.regionserver.TestHRegionBusyWait
        org.apache.hadoop.hbase.zookeeper.TestZooKeeperACL
        org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy
        org.apache.hadoop.hbase.master.TestOpenedRegionHandler
        org.apache.hadoop.hbase.io.TestFileLink
        org.apache.hadoop.hbase.master.cleaner.TestLogsCleaner
        org.apache.hadoop.hbase.master.TestMasterMetrics
        org.apache.hadoop.hbase.regionserver.wal.TestHLogFiltering
        org.apache.hadoop.hbase.client.TestHTableMultiplexer
        org.apache.hadoop.hbase.replication.TestMasterReplication
        org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
        org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
        org.apache.hadoop.hbase.master.TestMasterFailover
        org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
        org.apache.hadoop.hbase.backup.TestHFileArchiving
        org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint
        org.apache.hadoop.hbase.client.TestHCM
        org.apache.hadoop.hbase.master.TestMasterShutdown
        org.apache.hadoop.hbase.coprocessor.TestWALObserver
        org.apache.hadoop.hbase.client.TestFromClientSide
        org.apache.hadoop.hbase.rest.TestTableResource
        org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded
        org.apache.hadoop.hbase.client.TestFromClientSide3
        org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
        org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan
        org.apache.hadoop.hbase.security.access.TestAccessController
        org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint
        org.apache.hadoop.hbase.io.hfile.TestHFileBlock
        org.apache.hadoop.hbase.master.TestDistributedLogSplitting
        org.apache.hadoop.hbase.util.TestFSUtils
        org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
        org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface
        org.apache.hadoop.hbase.master.cleaner.TestHFileCleaner
        org.apache.hadoop.hbase.master.TestMaster
        org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk
        org.apache.hadoop.hbase.util.TestHBaseFsck

        -1 core zombie tests. There are 12 zombie test(s): at org.apache.hadoop.hbase.master.TestHMasterRPCException.testRPCException(TestHMasterRPCException.java:45)
        at org.apache.hadoop.hbase.mapreduce.TestTableMapReduce.testMultiRegionTable(TestTableMapReduce.java:127)
        at org.apache.hadoop.hbase.regionserver.wal.TestHLog.testAppendClose(TestHLog.java:406)
        at org.apache.hadoop.hbase.regionserver.wal.TestWALReplay.testReplayEditsWrittenViaHRegion(TestWALReplay.java:417)
        at org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat.testMRIncrementalLoad(TestHFileOutputFormat.java:350)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563029/7299-addendum2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestMasterObserver org.apache.hadoop.hbase.coprocessor.TestAggregateProtocol org.apache.hadoop.hbase.mapred.TestTableInputFormat org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed org.apache.hadoop.hbase.io.encoding.TestChangingEncoding org.apache.hadoop.hbase.client.TestHTableUtil org.apache.hadoop.hbase.coprocessor.TestClassLoading org.apache.hadoop.hbase.rest.TestScannersWithFilters org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort org.apache.hadoop.hbase.master.handler.TestTableDeleteFamilyHandler org.apache.hadoop.hbase.master.TestMasterNoCluster org.apache.hadoop.hbase.mapreduce.TestImportExport org.apache.hadoop.hbase.util.TestMergeTool org.apache.hadoop.hbase.security.access.TestTablePermissions org.apache.hadoop.hbase.TestZooKeeper org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher org.apache.hadoop.hbase.util.TestIdLock org.apache.hadoop.hbase.client.TestClientTimeouts org.apache.hadoop.hbase.TestHBaseTestingUtility org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap org.apache.hadoop.hbase.client.TestMultiParallel org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase org.apache.hadoop.hbase.security.access.TestAccessControlFilter org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort org.apache.hadoop.hbase.regionserver.TestHRegion org.apache.hadoop.hbase.client.TestTimestampsFilter org.apache.hadoop.hbase.util.TestRegionSplitter org.apache.hadoop.hbase.catalog.TestMetaMigrationConvertingToPB org.apache.hadoop.hbase.client.TestMetaScanner org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass org.apache.hadoop.hbase.client.TestAdmin org.apache.hadoop.hbase.client.TestMultipleTimestamps org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster org.apache.hadoop.hbase.master.TestMasterMetricsWrapper org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient org.apache.hadoop.hbase.TestAcidGuarantees org.apache.hadoop.hbase.master.TestRollingRestart org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding org.apache.hadoop.hbase.rest.TestStatusResource org.apache.hadoop.hbase.mapreduce.TestWALPlayer org.apache.hadoop.hbase.client.TestScannersFromClientSide org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove org.apache.hadoop.hbase.master.TestMasterTransitions org.apache.hadoop.hbase.client.TestScannerTimeout org.apache.hadoop.hbase.client.TestClientScannerRPCTimeout org.apache.hadoop.hbase.util.TestMergeTable org.apache.hadoop.hbase.TestRegionRebalancing org.apache.hadoop.hbase.client.TestShell org.apache.hadoop.hbase.master.TestRestartCluster org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithAbort org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel org.apache.hadoop.hbase.TestDrainingServer org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit org.apache.hadoop.hbase.master.TestMasterFileSystem org.apache.hadoop.hbase.master.TestZKBasedOpenCloseRegion org.apache.hadoop.hbase.regionserver.TestHRegionBusyWait org.apache.hadoop.hbase.zookeeper.TestZooKeeperACL org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy org.apache.hadoop.hbase.master.TestOpenedRegionHandler org.apache.hadoop.hbase.io.TestFileLink org.apache.hadoop.hbase.master.cleaner.TestLogsCleaner org.apache.hadoop.hbase.master.TestMasterMetrics org.apache.hadoop.hbase.regionserver.wal.TestHLogFiltering org.apache.hadoop.hbase.client.TestHTableMultiplexer org.apache.hadoop.hbase.replication.TestMasterReplication org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles org.apache.hadoop.hbase.replication.TestMultiSlaveReplication org.apache.hadoop.hbase.master.TestMasterFailover org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery org.apache.hadoop.hbase.backup.TestHFileArchiving org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint org.apache.hadoop.hbase.client.TestHCM org.apache.hadoop.hbase.master.TestMasterShutdown org.apache.hadoop.hbase.coprocessor.TestWALObserver org.apache.hadoop.hbase.client.TestFromClientSide org.apache.hadoop.hbase.rest.TestTableResource org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded org.apache.hadoop.hbase.client.TestFromClientSide3 org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan org.apache.hadoop.hbase.security.access.TestAccessController org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint org.apache.hadoop.hbase.io.hfile.TestHFileBlock org.apache.hadoop.hbase.master.TestDistributedLogSplitting org.apache.hadoop.hbase.util.TestFSUtils org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface org.apache.hadoop.hbase.master.cleaner.TestHFileCleaner org.apache.hadoop.hbase.master.TestMaster org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk org.apache.hadoop.hbase.util.TestHBaseFsck -1 core zombie tests . There are 12 zombie test(s): at org.apache.hadoop.hbase.master.TestHMasterRPCException.testRPCException(TestHMasterRPCException.java:45) at org.apache.hadoop.hbase.mapreduce.TestTableMapReduce.testMultiRegionTable(TestTableMapReduce.java:127) at org.apache.hadoop.hbase.regionserver.wal.TestHLog.testAppendClose(TestHLog.java:406) at org.apache.hadoop.hbase.regionserver.wal.TestWALReplay.testReplayEditsWrittenViaHRegion(TestWALReplay.java:417) at org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat.testMRIncrementalLoad(TestHFileOutputFormat.java:350) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3822//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563094/7299-addendum.v3
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.TestLocalHBaseCluster
        org.apache.hadoop.hbase.client.TestMultiParallel

        -1 core zombie tests. There are 4 zombie test(s):

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563094/7299-addendum.v3 against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestLocalHBaseCluster org.apache.hadoop.hbase.client.TestMultiParallel -1 core zombie tests . There are 4 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3823//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Addendum v3 wraps long line and makes exception message specific

        Show
        Ted Yu added a comment - Addendum v3 wraps long line and makes exception message specific
        Hide
        chunhui shen added a comment -

        I have analysed the logs of trunk build #3686, and found the reason.

        1.We will abort the regionserver 0 in both testBatchWithPut and testFlushCommitsWithAbort

        2.We will ensure 2 regionservers alisve before each test

        @Before public void before() throws IOException {
            LOG.info("before");
            if (UTIL.ensureSomeRegionServersAvailable(slaves)) {
              // Distribute regions
              UTIL.getMiniHBaseCluster().getMaster().balance();
            }
            LOG.info("before done");
          }
        

        3.In trunk build #3686, testFlushCommitsWithAbort is run after testBatchWithPut

        2013-01-02 12:28:33,183 INFO  [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testBatchWithPut 
        ...
        2013-01-02 12:30:08,410 INFO  [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testFlushCommitsWithAbort
        

        4.testFlushCommitsWithAbort abort the regionserver 0 which is already aborted by testBatchWithPut, so we see the following log:

        2013-01-02 12:30:08,410 INFO  [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testFlushCommitsWithAbort 
        2013-01-02 12:30:08,410 INFO  [pool-1-thread-1] client.TestMultiParallel(77): before
        2013-01-02 12:30:08,410 INFO  [pool-1-thread-1] hbase.LocalHBaseCluster(243): Not alive RegionServer:0;juno.apache.org,40265,1357129678691
        2013-01-02 12:30:08,410 INFO  [pool-1-thread-1] client.TestMultiParallel(82): before done
        2013-01-02 12:30:08,410 INFO  [Thread-709] client.TestMultiParallel(226): test=testFlushCommitsWithAbort
        ...
        2013-01-02 12:30:09,059 INFO  [Thread-709] hbase.LocalHBaseCluster(243): Not alive RegionServer:0;juno.apache.org,40265,1357129678691
        2013-01-02 12:30:09,059 INFO  [Thread-709] client.TestMultiParallel(277): Count=1, Alive=juno.apache.org,40198,1357129678744
        2013-01-02 12:30:09,059 INFO  [Thread-709] client.TestMultiParallel(277): Count=2, Alive=juno.apache.org,51431,1357129753348
        

        5.From the above, it's clear there are total 3 regionservers and 2 are alive, but testFlushCommitsWithAbort consider only total 2 regionserver

        Uploading the addendum2 to fix the case bug

        Show
        chunhui shen added a comment - I have analysed the logs of trunk build #3686, and found the reason. 1.We will abort the regionserver 0 in both testBatchWithPut and testFlushCommitsWithAbort 2.We will ensure 2 regionservers alisve before each test @Before public void before() throws IOException { LOG.info( "before" ); if (UTIL.ensureSomeRegionServersAvailable(slaves)) { // Distribute regions UTIL.getMiniHBaseCluster().getMaster().balance(); } LOG.info( "before done" ); } 3.In trunk build #3686, testFlushCommitsWithAbort is run after testBatchWithPut 2013-01-02 12:28:33,183 INFO [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testBatchWithPut ... 2013-01-02 12:30:08,410 INFO [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testFlushCommitsWithAbort 4.testFlushCommitsWithAbort abort the regionserver 0 which is already aborted by testBatchWithPut, so we see the following log: 2013-01-02 12:30:08,410 INFO [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testFlushCommitsWithAbort 2013-01-02 12:30:08,410 INFO [pool-1-thread-1] client.TestMultiParallel(77): before 2013-01-02 12:30:08,410 INFO [pool-1-thread-1] hbase.LocalHBaseCluster(243): Not alive RegionServer:0;juno.apache.org,40265,1357129678691 2013-01-02 12:30:08,410 INFO [pool-1-thread-1] client.TestMultiParallel(82): before done 2013-01-02 12:30:08,410 INFO [ Thread -709] client.TestMultiParallel(226): test=testFlushCommitsWithAbort ... 2013-01-02 12:30:09,059 INFO [ Thread -709] hbase.LocalHBaseCluster(243): Not alive RegionServer:0;juno.apache.org,40265,1357129678691 2013-01-02 12:30:09,059 INFO [ Thread -709] client.TestMultiParallel(277): Count=1, Alive=juno.apache.org,40198,1357129678744 2013-01-02 12:30:09,059 INFO [ Thread -709] client.TestMultiParallel(277): Count=2, Alive=juno.apache.org,51431,1357129753348 5.From the above, it's clear there are total 3 regionservers and 2 are alive, but testFlushCommitsWithAbort consider only total 2 regionserver Uploading the addendum2 to fix the case bug
        Hide
        Ted Yu added a comment -

        In trunk build #3686, I saw:

        testFlushCommitsWithAbort(org.apache.hadoop.hbase.client.TestMultiParallel): Server count=2, abort=true expected:<1> but was:<2>

        Show
        Ted Yu added a comment - In trunk build #3686, I saw: testFlushCommitsWithAbort(org.apache.hadoop.hbase.client.TestMultiParallel): Server count=2, abort=true expected:<1> but was:<2>
        Hide
        Ted Yu added a comment -

        I triggered several trunk builds, last of which being #3683.

        This test didn't fail among the recent builds.

        Show
        Ted Yu added a comment - I triggered several trunk builds, last of which being #3683. This test didn't fail among the recent builds.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #323 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/323/)
        HBASE-7299 TestMultiParallel fails intermittently in trunk builds, addendum (Revision 1427289)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #323 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/323/ ) HBASE-7299 TestMultiParallel fails intermittently in trunk builds, addendum (Revision 1427289) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3678 (See https://builds.apache.org/job/HBase-TRUNK/3678/)
        HBASE-7299 TestMultiParallel fails intermittently in trunk builds, addendum (Revision 1427289)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3678 (See https://builds.apache.org/job/HBase-TRUNK/3678/ ) HBASE-7299 TestMultiParallel fails intermittently in trunk builds, addendum (Revision 1427289) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Hide
        Ted Yu added a comment -

        Thanks for the confirmation, Chunhui.

        Addendum integrated to trunk.

        Show
        Ted Yu added a comment - Thanks for the confirmation, Chunhui. Addendum integrated to trunk.
        Hide
        chunhui shen added a comment -

        The region counts assertion for each server is not essential to commit flushing test

        +1 on addendum

        Show
        chunhui shen added a comment - The region counts assertion for each server is not essential to commit flushing test +1 on addendum
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12562801/7299.addendum
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestFromClientSide

        -1 core zombie tests. There are 3 zombie test(s):

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12562801/7299.addendum against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestFromClientSide -1 core zombie tests . There are 3 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3784//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Addendum comments out the assertion that region server holds more than 10 regions.

        The assertion is not essential to commit flushing test.

        Show
        Ted Yu added a comment - Addendum comments out the assertion that region server holds more than 10 regions. The assertion is not essential to commit flushing test.
        Hide
        chunhui shen added a comment -

        Ted Yu
        I have see the log again.
        And I think it's because of balance

        First, see the order of test:

        2012-12-31 03:11:48,688 INFO  [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testActiveThreadsCount 
        2012-12-31 03:11:49,247 INFO  [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testBatchWithGet 
        2012-12-31 03:11:50,151 INFO  [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testBadFam 
        2012-12-31 03:11:50,169 INFO  [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testFlushCommitsNoAbort 
        2012-12-31 03:11:50,825 INFO  [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testFlushCommitsWithAbort 
        

        Therefore, We only need to take care what happen before 2012-12-31 03:11:50,825

        Then, I grep all the opened region logs

        2012-12-31 03:11:46,309 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-0] handler.OpenRegionHandler(149): Opened multi_test_table,,1356923505778.5e876dba9be19501a1eb65bf3a169e52. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:47,164 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,bbb,1356923506859.7c3f09396e7314de6f5a757b010b6497. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:47,202 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-0] handler.OpenRegionHandler(149): Opened multi_test_table,ccc,1356923506862.2a80b82e2d6c3152e3f12bc91e1cc621. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:47,303 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-1] handler.OpenRegionHandler(149): Opened multi_test_table,fff,1356923506868.63ffa8986cd30ff5314b4c2a70cf846a. on server:asf001.sp2.ygridcore.net,45800,1356923500558
        2012-12-31 03:11:47,329 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,ddd,1356923506864.744510f09d963e39dd9c0b6e3119dc10. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:47,370 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-2] handler.OpenRegionHandler(149): Opened multi_test_table,iii,1356923506875.d09ca7b9b80b6cde560772598a240d0e. on server:asf001.sp2.ygridcore.net,45800,1356923500558
        2012-12-31 03:11:47,400 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-0] handler.OpenRegionHandler(149): Opened multi_test_table,eee,1356923506866.6a1697e740f121d009c3085e0cccd18d. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:47,439 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-0] handler.OpenRegionHandler(149): Opened multi_test_table,jjj,1356923506878.f25b9086263fb7a4f983524c708503b6. on server:asf001.sp2.ygridcore.net,45800,1356923500558
        2012-12-31 03:11:47,465 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-1] handler.OpenRegionHandler(149): Opened multi_test_table,,1356923506856.2db538d9e2005dba4e28746d51cf3831. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:47,482 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,ggg,1356923506871.7adeba3045bdbb0f4e499b221d2ffc87. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:47,598 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-1] handler.OpenRegionHandler(149): Opened multi_test_table,nnn,1356923506888.9cc1e013ebfba7da8e00e4963c2d111a. on server:asf001.sp2.ygridcore.net,45800,1356923500558
        2012-12-31 03:11:47,603 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-1] handler.OpenRegionHandler(149): Opened multi_test_table,kkk,1356923506880.a2a3e39af3fa95eb1a3979998b075bb6. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:47,634 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-2] handler.OpenRegionHandler(149): Opened multi_test_table,ppp,1356923506893.915969809cfe733d325591b7c27bd088. on server:asf001.sp2.ygridcore.net,45800,1356923500558
        2012-12-31 03:11:47,643 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,lll,1356923506883.0e6b1c9b373cecb0c74380b78d1cc492. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:47,701 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-0] handler.OpenRegionHandler(149): Opened multi_test_table,rrr,1356923506899.67925003b24f6408e7ee6ef2360a77f6. on server:asf001.sp2.ygridcore.net,45800,1356923500558
        2012-12-31 03:11:47,717 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-1] handler.OpenRegionHandler(149): Opened multi_test_table,mmm,1356923506886.d0a07239a287e74e7706e4b9a0c9f491. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:47,745 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,ooo,1356923506891.524c6a4fb529fbb5b86e0865ac0131f5. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:47,867 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,sss,1356923506901.af5693d7dc46541210d7c26cf4e4c1a0. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:47,936 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-0] handler.OpenRegionHandler(149): Opened multi_test_table,hhh,1356923506873.12dff64cde2a448c9d5b7adecfabfaaa. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:47,957 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,ttt,1356923506904.c121cfbfb3e248f820d4729e4452ff14. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:48,012 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,vvv,1356923506908.797a80f1a86a9256a833e4cd48554185. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:48,076 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,www,1356923506911.79129a00e6718ae7ca478e3dde854524. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:48,185 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-1] handler.OpenRegionHandler(149): Opened multi_test_table,qqq,1356923506896.cf9a88d3961133afeaaeabdf5a9cffc3. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:48,411 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-0] handler.OpenRegionHandler(149): Opened multi_test_table,uuu,1356923506906.62d60488f81f0e0edce10369200b1543. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:48,556 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,xxx,1356923506913.bf54cd9fae68060237f700e0c7acc6b4. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        2012-12-31 03:11:48,626 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-1] handler.OpenRegionHandler(149): Opened multi_test_table,yyy,1356923506915.7b41bd006a2c832842a67b85f1837c68. on server:asf001.sp2.ygridcore.net,38198,1356923500609
        

        These regions are created by

         @BeforeClass public static void beforeClass() throws Exception {
        ...
            UTIL.createMultiRegions(t, Bytes.toBytes(FAMILY));
        ...
          }
        

        From the above, we could see server:asf001.sp2.ygridcore.net,38198,1356923500609 serve 20 regions, and asf001.sp2.ygridcore.net,45800,1356923500558 only serve 6 regions.
        It seems clear:

        for (JVMClusterUtil.RegionServerThread t: liveRSs) {
              int regions = ProtobufUtil.getOnlineRegions(t.getRegionServer()).size();
              Assert.assertTrue("Count of regions=" + regions, regions > 10);
            }
        

        I don't know why we assert regions more than 10 for each regionserver.
        From the failed logs, "java.lang.AssertionError: Count of regions=7", there is another region on asf001.sp2.ygridcore.net,45800,1356923500558

        2012-12-31 03:11:44,306 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-0] handler.OpenRegionHandler(149): Opened -ROOT-,,0.70236052 on server:asf001.sp2.ygridcore.net,45800,1356923500558
        

        Yes, It's the ROOT region.

        Also, we could see the balance logs later

        2012-12-31 03:11:58,883 INFO  [pool-1-thread-1] master.HMaster(1325): balance hri=multi_test_table,mmm,1356923506886.d0a07239a287e74e7706e4b9a0c9f491., src=asf001.sp2.ygridcore.net,38198,1356923500609, dest=asf001.sp2.ygridcore.net,59241,1356923517635
        2012-12-31 03:11:58,890 INFO  [pool-1-thread-1] master.HMaster(1325): balance hri=multi_test_table,,1356923505778.5e876dba9be19501a1eb65bf3a169e52., src=asf001.sp2.ygridcore.net,38198,1356923500609, dest=asf001.sp2.ygridcore.net,59241,1356923517635
        2012-12-31 03:11:58,949 INFO  [pool-1-thread-1] master.HMaster(1325): balance hri=multi_test_table,bbb,1356923506859.7c3f09396e7314de6f5a757b010b6497., src=asf001.sp2.ygridcore.net,38198,1356923500609, dest=asf001.sp2.ygridcore.net,59241,1356923517635
        2012-12-31 03:11:58,967 INFO  [pool-1-thread-1] master.HMaster(1325): balance hri=multi_test_table,eee,1356923506866.6a1697e740f121d009c3085e0cccd18d., src=asf001.sp2.ygridcore.net,38198,1356923500609, dest=asf001.sp2.ygridcore.net,59241,1356923517635
        

        So, I think the reason is unbalanced regions on the servers at before, And I don't think it's necessary that assert regions more than 10 for each regionserver.

        By the way, I find we will abort regionserver 0 in TestMultiParallel#testBatchWithPut, however we will also abort regionserver 0 TestMultiParallel#testFlushCommitsWithAbort(). It seems confused.

        Show
        chunhui shen added a comment - Ted Yu I have see the log again. And I think it's because of balance First, see the order of test: 2012-12-31 03:11:48,688 INFO [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testActiveThreadsCount 2012-12-31 03:11:49,247 INFO [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testBatchWithGet 2012-12-31 03:11:50,151 INFO [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testBadFam 2012-12-31 03:11:50,169 INFO [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testFlushCommitsNoAbort 2012-12-31 03:11:50,825 INFO [pool-1-thread-1] hbase.ResourceChecker(147): before: client.TestMultiParallel#testFlushCommitsWithAbort Therefore, We only need to take care what happen before 2012-12-31 03:11:50,825 Then, I grep all the opened region logs 2012-12-31 03:11:46,309 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-0] handler.OpenRegionHandler(149): Opened multi_test_table,,1356923505778.5e876dba9be19501a1eb65bf3a169e52. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:47,164 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,bbb,1356923506859.7c3f09396e7314de6f5a757b010b6497. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:47,202 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-0] handler.OpenRegionHandler(149): Opened multi_test_table,ccc,1356923506862.2a80b82e2d6c3152e3f12bc91e1cc621. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:47,303 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-1] handler.OpenRegionHandler(149): Opened multi_test_table,fff,1356923506868.63ffa8986cd30ff5314b4c2a70cf846a. on server:asf001.sp2.ygridcore.net,45800,1356923500558 2012-12-31 03:11:47,329 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,ddd,1356923506864.744510f09d963e39dd9c0b6e3119dc10. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:47,370 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-2] handler.OpenRegionHandler(149): Opened multi_test_table,iii,1356923506875.d09ca7b9b80b6cde560772598a240d0e. on server:asf001.sp2.ygridcore.net,45800,1356923500558 2012-12-31 03:11:47,400 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-0] handler.OpenRegionHandler(149): Opened multi_test_table,eee,1356923506866.6a1697e740f121d009c3085e0cccd18d. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:47,439 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-0] handler.OpenRegionHandler(149): Opened multi_test_table,jjj,1356923506878.f25b9086263fb7a4f983524c708503b6. on server:asf001.sp2.ygridcore.net,45800,1356923500558 2012-12-31 03:11:47,465 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-1] handler.OpenRegionHandler(149): Opened multi_test_table,,1356923506856.2db538d9e2005dba4e28746d51cf3831. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:47,482 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,ggg,1356923506871.7adeba3045bdbb0f4e499b221d2ffc87. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:47,598 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-1] handler.OpenRegionHandler(149): Opened multi_test_table,nnn,1356923506888.9cc1e013ebfba7da8e00e4963c2d111a. on server:asf001.sp2.ygridcore.net,45800,1356923500558 2012-12-31 03:11:47,603 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-1] handler.OpenRegionHandler(149): Opened multi_test_table,kkk,1356923506880.a2a3e39af3fa95eb1a3979998b075bb6. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:47,634 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-2] handler.OpenRegionHandler(149): Opened multi_test_table,ppp,1356923506893.915969809cfe733d325591b7c27bd088. on server:asf001.sp2.ygridcore.net,45800,1356923500558 2012-12-31 03:11:47,643 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,lll,1356923506883.0e6b1c9b373cecb0c74380b78d1cc492. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:47,701 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-0] handler.OpenRegionHandler(149): Opened multi_test_table,rrr,1356923506899.67925003b24f6408e7ee6ef2360a77f6. on server:asf001.sp2.ygridcore.net,45800,1356923500558 2012-12-31 03:11:47,717 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-1] handler.OpenRegionHandler(149): Opened multi_test_table,mmm,1356923506886.d0a07239a287e74e7706e4b9a0c9f491. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:47,745 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,ooo,1356923506891.524c6a4fb529fbb5b86e0865ac0131f5. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:47,867 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,sss,1356923506901.af5693d7dc46541210d7c26cf4e4c1a0. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:47,936 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-0] handler.OpenRegionHandler(149): Opened multi_test_table,hhh,1356923506873.12dff64cde2a448c9d5b7adecfabfaaa. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:47,957 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,ttt,1356923506904.c121cfbfb3e248f820d4729e4452ff14. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:48,012 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,vvv,1356923506908.797a80f1a86a9256a833e4cd48554185. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:48,076 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,www,1356923506911.79129a00e6718ae7ca478e3dde854524. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:48,185 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-1] handler.OpenRegionHandler(149): Opened multi_test_table,qqq,1356923506896.cf9a88d3961133afeaaeabdf5a9cffc3. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:48,411 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-0] handler.OpenRegionHandler(149): Opened multi_test_table,uuu,1356923506906.62d60488f81f0e0edce10369200b1543. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:48,556 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-2] handler.OpenRegionHandler(149): Opened multi_test_table,xxx,1356923506913.bf54cd9fae68060237f700e0c7acc6b4. on server:asf001.sp2.ygridcore.net,38198,1356923500609 2012-12-31 03:11:48,626 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,38198,1356923500609-1] handler.OpenRegionHandler(149): Opened multi_test_table,yyy,1356923506915.7b41bd006a2c832842a67b85f1837c68. on server:asf001.sp2.ygridcore.net,38198,1356923500609 These regions are created by @BeforeClass public static void beforeClass() throws Exception { ... UTIL.createMultiRegions(t, Bytes.toBytes(FAMILY)); ... } From the above, we could see server:asf001.sp2.ygridcore.net,38198,1356923500609 serve 20 regions, and asf001.sp2.ygridcore.net,45800,1356923500558 only serve 6 regions. It seems clear: for (JVMClusterUtil.RegionServerThread t: liveRSs) { int regions = ProtobufUtil.getOnlineRegions(t.getRegionServer()).size(); Assert.assertTrue( "Count of regions=" + regions, regions > 10); } I don't know why we assert regions more than 10 for each regionserver. From the failed logs, "java.lang.AssertionError: Count of regions=7", there is another region on asf001.sp2.ygridcore.net,45800,1356923500558 2012-12-31 03:11:44,306 DEBUG [RS_OPEN_REGION-asf001.sp2.ygridcore.net,45800,1356923500558-0] handler.OpenRegionHandler(149): Opened -ROOT-,,0.70236052 on server:asf001.sp2.ygridcore.net,45800,1356923500558 Yes, It's the ROOT region. Also, we could see the balance logs later 2012-12-31 03:11:58,883 INFO [pool-1-thread-1] master.HMaster(1325): balance hri=multi_test_table,mmm,1356923506886.d0a07239a287e74e7706e4b9a0c9f491., src=asf001.sp2.ygridcore.net,38198,1356923500609, dest=asf001.sp2.ygridcore.net,59241,1356923517635 2012-12-31 03:11:58,890 INFO [pool-1-thread-1] master.HMaster(1325): balance hri=multi_test_table,,1356923505778.5e876dba9be19501a1eb65bf3a169e52., src=asf001.sp2.ygridcore.net,38198,1356923500609, dest=asf001.sp2.ygridcore.net,59241,1356923517635 2012-12-31 03:11:58,949 INFO [pool-1-thread-1] master.HMaster(1325): balance hri=multi_test_table,bbb,1356923506859.7c3f09396e7314de6f5a757b010b6497., src=asf001.sp2.ygridcore.net,38198,1356923500609, dest=asf001.sp2.ygridcore.net,59241,1356923517635 2012-12-31 03:11:58,967 INFO [pool-1-thread-1] master.HMaster(1325): balance hri=multi_test_table,eee,1356923506866.6a1697e740f121d009c3085e0cccd18d., src=asf001.sp2.ygridcore.net,38198,1356923500609, dest=asf001.sp2.ygridcore.net,59241,1356923517635 So, I think the reason is unbalanced regions on the servers at before, And I don't think it's necessary that assert regions more than 10 for each regionserver. By the way, I find we will abort regionserver 0 in TestMultiParallel#testBatchWithPut, however we will also abort regionserver 0 TestMultiParallel#testFlushCommitsWithAbort(). It seems confused.
        Hide
        Ted Yu added a comment -

        @Chunhui:
        If you take a look at the following (produced by Hadoop QA after your patch was integrated), you would know why I thought there was something in core that resulted the test failure:
        https://builds.apache.org/job/PreCommit-HBASE-Build/3776//testReport/org.apache.hadoop.hbase.client/TestMultiParallel/testFlushCommitsNoAbort/

        Thanks

        Show
        Ted Yu added a comment - @Chunhui: If you take a look at the following (produced by Hadoop QA after your patch was integrated), you would know why I thought there was something in core that resulted the test failure: https://builds.apache.org/job/PreCommit-HBASE-Build/3776//testReport/org.apache.hadoop.hbase.client/TestMultiParallel/testFlushCommitsNoAbort/ Thanks
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #320 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/320/)
        HBASE-7299 TestMultiParallel fails intermittently in trunk builds (Chunhui) (Revision 1426965)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #320 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/320/ ) HBASE-7299 TestMultiParallel fails intermittently in trunk builds (Chunhui) (Revision 1426965) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3675 (See https://builds.apache.org/job/HBase-TRUNK/3675/)
        HBASE-7299 TestMultiParallel fails intermittently in trunk builds (Chunhui) (Revision 1426965)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3675 (See https://builds.apache.org/job/HBase-TRUNK/3675/ ) HBASE-7299 TestMultiParallel fails intermittently in trunk builds (Chunhui) (Revision 1426965) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
        Hide
        Ted Yu added a comment -

        hadoop4 environment has problem: https://builds.apache.org/job/PreCommit-HBASE-Build/3751/consoleFull

        The patch only touches TestMultiParallel which wouldn't have effect on other tests.

        Running org.apache.hadoop.hbase.client.TestHCM
        2012-12-30 09:01:55.167 java[734:1203] Unable to load realm info from SCDynamicStore
        Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.993 sec
        

        Integrated to trunk.

        Thanks for the patch, Chunhui.

        Thanks for the review, Stack.

        Show
        Ted Yu added a comment - hadoop4 environment has problem: https://builds.apache.org/job/PreCommit-HBASE-Build/3751/consoleFull The patch only touches TestMultiParallel which wouldn't have effect on other tests. Running org.apache.hadoop.hbase.client.TestHCM 2012-12-30 09:01:55.167 java[734:1203] Unable to load realm info from SCDynamicStore Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.993 sec Integrated to trunk. Thanks for the patch, Chunhui. Thanks for the review, Stack.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12562719/7299-v4.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
        org.apache.hadoop.hbase.regionserver.TestStoreFileBlockCacheSummary
        org.apache.hadoop.hbase.ipc.TestProtoBufRpc
        org.apache.hadoop.hbase.ipc.TestDelayedRpc
        org.apache.hadoop.hbase.TestClusterBootOrder
        org.apache.hadoop.hbase.TestDrainingServer
        org.apache.hadoop.hbase.TestZooKeeper

        -1 core zombie tests. There are 8 zombie test(s): at org.apache.hadoop.hbase.security.access.TestAccessController.testCheckPermissions(TestAccessController.java:1330)
        at org.apache.hadoop.hbase.master.TestOpenedRegionHandler.testOpenedRegionHandlerOnMasterRestart(TestOpenedRegionHandler.java:87)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12562719/7299-v4.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction org.apache.hadoop.hbase.regionserver.TestStoreFileBlockCacheSummary org.apache.hadoop.hbase.ipc.TestProtoBufRpc org.apache.hadoop.hbase.ipc.TestDelayedRpc org.apache.hadoop.hbase.TestClusterBootOrder org.apache.hadoop.hbase.TestDrainingServer org.apache.hadoop.hbase.TestZooKeeper -1 core zombie tests . There are 8 zombie test(s): at org.apache.hadoop.hbase.security.access.TestAccessController.testCheckPermissions(TestAccessController.java:1330) at org.apache.hadoop.hbase.master.TestOpenedRegionHandler.testOpenedRegionHandlerOnMasterRestart(TestOpenedRegionHandler.java:87) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3767//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12562719/7299-v4.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestHCM

        -1 core zombie tests. There are 2 zombie test(s):

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12562719/7299-v4.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestHCM -1 core zombie tests . There are 2 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3765//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Patch v4 corrects spelling in patch v3.

        Show
        Ted Yu added a comment - Patch v4 corrects spelling in patch v3.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12562657/HBASE-7299v3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.ipc.TestProtoBufRpc
        org.apache.hadoop.hbase.ipc.TestDelayedRpc
        org.apache.hadoop.hbase.TestClusterBootOrder
        org.apache.hadoop.hbase.TestDrainingServer
        org.apache.hadoop.hbase.TestZooKeeper

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12562657/HBASE-7299v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.ipc.TestProtoBufRpc org.apache.hadoop.hbase.ipc.TestDelayedRpc org.apache.hadoop.hbase.TestClusterBootOrder org.apache.hadoop.hbase.TestDrainingServer org.apache.hadoop.hbase.TestZooKeeper Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3751//console This message is automatically generated.
        Hide
        stack added a comment -

        I think it is these two outputs:

        2 warnings
        [WARNING] Javadoc Warnings
        [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:43: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
        [WARNING] import sun.misc.Unsafe;
        [WARNING] ^
        [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:1032: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
        [WARNING] static final Unsafe theUnsafe;
        [WARNING] ^
        

        Let me fix in new issue.

        Show
        stack added a comment - I think it is these two outputs: 2 warnings [WARNING] Javadoc Warnings [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:43: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release [WARNING] import sun.misc.Unsafe; [WARNING] ^ [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:1032: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release [WARNING] static final Unsafe theUnsafe; [WARNING] ^ Let me fix in new issue.
        Hide
        chunhui shen added a comment -

        I think it's because of no annotation for the method beforeClass() and method doTestFlushCommits(boolean doAbort)

        Show
        chunhui shen added a comment - I think it's because of no annotation for the method beforeClass() and method doTestFlushCommits(boolean doAbort)
        Hide
        stack added a comment -

        Are you responsible for the two new javadoc warnings Chunhui?

        -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

        Show
        stack added a comment - Are you responsible for the two new javadoc warnings Chunhui? -1 javadoc. The javadoc tool appears to have generated 2 warning messages.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12562645/HBASE-7299.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 core tests. The patch passed unit tests in .

        -1 core zombie tests. There are 2 zombie test(s):

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12562645/HBASE-7299.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 core tests . The patch passed unit tests in . -1 core zombie tests . There are 2 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3746//console This message is automatically generated.
        Hide
        chunhui shen added a comment -

        Adding annotation in patchV2

        Show
        chunhui shen added a comment - Adding annotation in patchV2
        Hide
        stack added a comment -

        Sounds good. Add the above comments to the patch I'd say. Thanks.

        Show
        stack added a comment - Sounds good. Add the above comments to the patch I'd say. Thanks.
        Hide
        chunhui shen added a comment -
        + UTIL.waitTableAvailable(Bytes.toBytes(TEST_TABLE), 15 * 1000);
        

        Yes, test will be failed if table is not available after 15 seconds, is 15 seconds eough?

        why we waiting for no regions being online before we'll abort?

        Not before we'll abort, waiting for no regions being online after we abort the server.
        It is because:
        We send the abort request, but the regionserver still serves regions for some time, so the next keys may be put to the abort server successfully. Also the thread may be live when we doing the assert for count of live servers, causing test failed

        If we waiting for no regions being online after we abort the server, we could ensure the master has re-assigned the regions on killed server after putting keys successfully, it means the server we abort is dead and detected by matser

        Show
        chunhui shen added a comment - + UTIL.waitTableAvailable(Bytes.toBytes(TEST_TABLE), 15 * 1000); Yes, test will be failed if table is not available after 15 seconds, is 15 seconds eough? why we waiting for no regions being online before we'll abort? Not before we'll abort, waiting for no regions being online after we abort the server. It is because: We send the abort request, but the regionserver still serves regions for some time, so the next keys may be put to the abort server successfully. Also the thread may be live when we doing the assert for count of live servers, causing test failed If we waiting for no regions being online after we abort the server, we could ensure the master has re-assigned the regions on killed server after putting keys successfully, it means the server we abort is dead and detected by matser
        Hide
        stack added a comment -

        chunhui shen Thanks for taking a look. Will the below fail the test if table is not online before the 15 seconds expires:

        + UTIL.waitTableAvailable(Bytes.toBytes(TEST_TABLE), 15 * 1000);

        In the below, why we waiting for no regions being online before we'll abort? Should say so in comment:

        + while (UTIL.getMiniHBaseCluster().getRegionServer(0)
        + .getNumberOfOnlineRegions() != 0)

        { + Thread.sleep(100); + }
        Show
        stack added a comment - chunhui shen Thanks for taking a look. Will the below fail the test if table is not online before the 15 seconds expires: + UTIL.waitTableAvailable(Bytes.toBytes(TEST_TABLE), 15 * 1000); In the below, why we waiting for no regions being online before we'll abort? Should say so in comment: + while (UTIL.getMiniHBaseCluster().getRegionServer(0) + .getNumberOfOnlineRegions() != 0) { + Thread.sleep(100); + }
        Hide
        chunhui shen added a comment -

        Making a patch for the case.

        Ted Yu

        Take a review?

        Show
        chunhui shen added a comment - Making a patch for the case. Ted Yu Take a review?
        Hide
        Ted Yu added a comment -

        What I tried to understand is why TestMultiParallel didn't fail so frequently previously (most recent change to TestMultiParallel.java was from HBASE-7215)

        Show
        Ted Yu added a comment - What I tried to understand is why TestMultiParallel didn't fail so frequently previously (most recent change to TestMultiParallel.java was from HBASE-7215 )
        Hide
        chunhui shen added a comment -

        I think it is a problem of the test case.

        public static void beforeClass() throws Exception {
            UTIL.startMiniCluster(slaves);
            HTable t = UTIL.createTable(Bytes.toBytes(TEST_TABLE), Bytes.toBytes(FAMILY));
            UTIL.createMultiRegions(t, Bytes.toBytes(FAMILY));
            t.close();
          }
        

        Here, we create multi regions for table TEST_TABLE, but it is asynchronous, so these regions may not onlined on the regionserver when we do the assert for count of regions.

        Another failed case is also the same reason,

         if (doAbort) {
              LOG.info("Aborted=" + UTIL.getMiniHBaseCluster().abortRegionServer(0));
        
              // try putting more keys after the abort. same key/qual... just validating
              // no exceptions thrown
              puts = constructPutRequests();
              for (Row put : puts) {
                table.put((Put) put);
              }
        
              table.flushCommits();
            }
        

        Abort server is also asynchronous, we will do checkopen() for put in HRegionserver in 0.94 version, but now not. Therefore, though we could put keys successfully, the abort server's thread may not exit, and then got

        java.lang.AssertionError: Server count=2, abort=true expected:<1> but was:<2>
        
        Show
        chunhui shen added a comment - I think it is a problem of the test case. public static void beforeClass() throws Exception { UTIL.startMiniCluster(slaves); HTable t = UTIL.createTable(Bytes.toBytes(TEST_TABLE), Bytes.toBytes(FAMILY)); UTIL.createMultiRegions(t, Bytes.toBytes(FAMILY)); t.close(); } Here, we create multi regions for table TEST_TABLE, but it is asynchronous, so these regions may not onlined on the regionserver when we do the assert for count of regions. Another failed case is also the same reason, if (doAbort) { LOG.info( "Aborted=" + UTIL.getMiniHBaseCluster().abortRegionServer(0)); // try putting more keys after the abort. same key/qual... just validating // no exceptions thrown puts = constructPutRequests(); for (Row put : puts) { table.put((Put) put); } table.flushCommits(); } Abort server is also asynchronous, we will do checkopen() for put in HRegionserver in 0.94 version, but now not. Therefore, though we could put keys successfully, the abort server's thread may not exit, and then got java.lang.AssertionError: Server count=2, abort= true expected:<1> but was:<2>
        Hide
        Ted Yu added a comment -

        Looking at Jenkins builds, this was the first build where the test started to fail:
        https://builds.apache.org/job/HBase-TRUNK/3582/

        Before build #3582, there were long string of build failures due to:

        java.lang.AssertionError: There are 14 test classes without category: [class org.apache.hadoop.hbase.thrift.TestMetricsThriftServerSourceFactory, class org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceFactory, class org.apache.hadoop.hbase.master.TestMetricsMasterSourceImpl, class org.apache.hadoop.hbase.metrics.TestBaseSourceImpl, class org.apache.hadoop.hbase.replication.regionserver.TestMetricsReplicationSourceFactory, class org.apache.hadoop.hbase.regionserver.wal.TestMetricsHLogSource, class org.apache.hadoop.hbase.rest.TestRESTMetricsSourceImpl, class org.apache.hadoop.hbase.regionserver.TestMetricsRegionSourceImpl, class org.apache.hadoop.hbase.regionserver.wal.TestMetricsWALSourceImpl, class org.apache.hadoop.hbase.thrift.TestThriftServerMetricsSourceFactoryImpl, class org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceImpl, class org.apache.hadoop.hbase.replication.regionserver.TestReplicationMetricsSourceImpl, class org.apache.hadoop.hbase.master.TestMetricsMasterSourceFactory, class org.apache.hadoop.hbase.rest.TestMetricsRESTSource]
        	at org.junit.Assert.fail(Assert.java:93)
        	at org.junit.Assert.assertTrue(Assert.java:43)
        	at org.apache.hadoop.hbase.TestCheckTestClasses.checkClasses(TestCheckTestClasses.java:58)
        

        So it is hard to determine when TestMultiParallel started to fail.

        Show
        Ted Yu added a comment - Looking at Jenkins builds, this was the first build where the test started to fail: https://builds.apache.org/job/HBase-TRUNK/3582/ Before build #3582, there were long string of build failures due to: java.lang.AssertionError: There are 14 test classes without category: [class org.apache.hadoop.hbase.thrift.TestMetricsThriftServerSourceFactory, class org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceFactory, class org.apache.hadoop.hbase.master.TestMetricsMasterSourceImpl, class org.apache.hadoop.hbase.metrics.TestBaseSourceImpl, class org.apache.hadoop.hbase.replication.regionserver.TestMetricsReplicationSourceFactory, class org.apache.hadoop.hbase.regionserver.wal.TestMetricsHLogSource, class org.apache.hadoop.hbase. rest .TestRESTMetricsSourceImpl, class org.apache.hadoop.hbase.regionserver.TestMetricsRegionSourceImpl, class org.apache.hadoop.hbase.regionserver.wal.TestMetricsWALSourceImpl, class org.apache.hadoop.hbase.thrift.TestThriftServerMetricsSourceFactoryImpl, class org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceImpl, class org.apache.hadoop.hbase.replication.regionserver.TestReplicationMetricsSourceImpl, class org.apache.hadoop.hbase.master.TestMetricsMasterSourceFactory, class org.apache.hadoop.hbase. rest .TestMetricsRESTSource] at org.junit.Assert.fail(Assert.java:93) at org.junit.Assert.assertTrue(Assert.java:43) at org.apache.hadoop.hbase.TestCheckTestClasses.checkClasses(TestCheckTestClasses.java:58) So it is hard to determine when TestMultiParallel started to fail.
        Hide
        Ted Yu added a comment -

        I looped TestMultiParallel 9 times in 0.94 branch and didn't see test failure.

        Looks like the failure is unique to trunk.

        Show
        Ted Yu added a comment - I looped TestMultiParallel 9 times in 0.94 branch and didn't see test failure. Looks like the failure is unique to trunk.
        Hide
        Ted Yu added a comment -

        Failed in HBase-TRUNK-on-Hadoop-2.0.0 #286 as well:

        Failed tests:   testFlushCommitsNoAbort(org.apache.hadoop.hbase.client.TestMultiParallel): Count of regions=8
        
        Show
        Ted Yu added a comment - Failed in HBase-TRUNK-on-Hadoop-2.0.0 #286 as well: Failed tests: testFlushCommitsNoAbort(org.apache.hadoop.hbase.client.TestMultiParallel): Count of regions=8

          People

          • Assignee:
            chunhui shen
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development