HBase
  1. HBase
  2. HBASE-7122

Proper warning message when opening a log file with no entries (idle cluster)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.94.2
    • Fix Version/s: 0.98.0, 0.94.8, 0.95.1
    • Component/s: Replication
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In case the cluster is idle and the log has rolled (offset to 0), replicationSource tries to open the log and gets an EOF exception. This gets printed after every 10 sec until an entry is inserted in it.

      2012-11-07 15:47:40,924 DEBUG regionserver.ReplicationSource (ReplicationSource.java:openReader(487)) - Opening log for replication c0315.hal.cloudera.com%2C40020%2C1352324202860.1352327804874 at 0
      2012-11-07 15:47:40,926 WARN  regionserver.ReplicationSource (ReplicationSource.java:openReader(543)) - 1 Got: 
      java.io.EOFException
      	at java.io.DataInputStream.readFully(DataInputStream.java:180)
      	at java.io.DataInputStream.readFully(DataInputStream.java:152)
      	at org.apache.hadoop.io.SequenceFile$Reader.init(SequenceFile.java:1508)
      	at org.apache.hadoop.io.SequenceFile$Reader.<init>(SequenceFile.java:1486)
      	at org.apache.hadoop.io.SequenceFile$Reader.<init>(SequenceFile.java:1475)
      	at org.apache.hadoop.io.SequenceFile$Reader.<init>(SequenceFile.java:1470)
      	at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader$WALReader.<init>(SequenceFileLogReader.java:55)
      	at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.init(SequenceFileLogReader.java:175)
      	at org.apache.hadoop.hbase.regionserver.wal.HLog.getReader(HLog.java:716)
      	at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.openReader(ReplicationSource.java:491)
      	at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:290)
      2012-11-07 15:47:40,927 WARN  regionserver.ReplicationSource (ReplicationSource.java:openReader(547)) - Waited too long for this file, considering dumping
      2012-11-07 15:47:40,927 DEBUG regionserver.ReplicationSource (ReplicationSource.java:sleepForRetries(562)) - Unable to open a reader, sleeping 1000 times 10
      
      

      We should reduce the log spewing in this case (or some informative message, based on the offset).

      1. HBase-7122.patch
        0.8 kB
        Himanshu Vashishtha
      2. HBASE-7122.v2.patch
        0.7 kB
        Gabriel Reid
      3. HBase-7122-94.patch
        0.8 kB
        Himanshu Vashishtha
      4. HBase-7122-95.patch
        0.8 kB
        Himanshu Vashishtha
      5. HBase-7122-95-v2.patch
        1 kB
        Himanshu Vashishtha
      6. HBase-7122-95-v3.patch
        1 kB
        Himanshu Vashishtha
      7. HBase-7122-95-v4.patch
        1 kB
        Himanshu Vashishtha
      8. HBase-7122-94-v2.patch
        1 kB
        Himanshu Vashishtha

        Issue Links

          Activity

          Hide
          Jean-Daniel Cryans added a comment -

          We could fold this in HBASE-6804.

          Show
          Jean-Daniel Cryans added a comment - We could fold this in HBASE-6804 .
          Hide
          Himanshu Vashishtha added a comment -

          Tested it on a cluster; it stops emitting exception and other behavior remains the same.

          Show
          Himanshu Vashishtha added a comment - Tested it on a cluster; it stops emitting exception and other behavior remains the same.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12552737/HBase-7122.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3279//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552737/HBase-7122.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3279//console This message is automatically generated.
          Hide
          stack added a comment -

          +1 on patch. Looking at HBASE-6804, I do not see this patch rolled in there. Is that so Himanshu? Can you make a trunk patch? Thanks boss.

          Show
          stack added a comment - +1 on patch. Looking at HBASE-6804 , I do not see this patch rolled in there. Is that so Himanshu? Can you make a trunk patch? Thanks boss.
          Hide
          Gabriel Reid added a comment -

          We've just started having some issues with this bug as well – trunk patch is attached.

          It's been tested against the replication unit tests, as well as a small-scale cluster test to ensure it does what it's supposed to.

          Show
          Gabriel Reid added a comment - We've just started having some issues with this bug as well – trunk patch is attached. It's been tested against the replication unit tests, as well as a small-scale cluster test to ensure it does what it's supposed to.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12566508/HBASE-7122.v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.wal.TestHLog

          -1 core zombie tests. There are 1 zombie test(s):

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566508/HBASE-7122.v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestHLog -1 core zombie tests . There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4180//console This message is automatically generated.
          Hide
          Himanshu Vashishtha added a comment -

          will upload a revised patch for 0.94 soon.

          Show
          Himanshu Vashishtha added a comment - will upload a revised patch for 0.94 soon.
          Hide
          Himanshu Vashishtha added a comment -

          0.94 patch.

          Show
          Himanshu Vashishtha added a comment - 0.94 patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12573657/HBase-7122-94.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4809//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12573657/HBase-7122-94.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4809//console This message is automatically generated.
          Hide
          Himanshu Vashishtha added a comment -

          trunk patch is still good to apply.

          Show
          Himanshu Vashishtha added a comment - trunk patch is still good to apply.
          Hide
          Lars Hofhansl added a comment -

          +1 on all branches.

          Show
          Lars Hofhansl added a comment - +1 on all branches.
          Hide
          Chris Trezzo added a comment -

          Patch looks good to me as well.

          Show
          Chris Trezzo added a comment - Patch looks good to me as well.
          Hide
          Jieshan Bean added a comment -

          Himanshu Vashishtha There's one possible problem in this patch. Suppose we have several logs in recovered queue and with 1 log is empty, this change will hang the ReplicationSource thread which will keep opening the empty log.

          Show
          Jieshan Bean added a comment - Himanshu Vashishtha There's one possible problem in this patch. Suppose we have several logs in recovered queue and with 1 log is empty, this change will hang the ReplicationSource thread which will keep opening the empty log.
          Hide
          stack added a comment -

          Himanshu Vashishtha What you think of Jieshan Bean comment above?

          Show
          stack added a comment - Himanshu Vashishtha What you think of Jieshan Bean comment above?
          Hide
          Himanshu Vashishtha added a comment -

          Yes, will upload a new patch.

          Show
          Himanshu Vashishtha added a comment - Yes, will upload a new patch.
          Hide
          Himanshu Vashishtha added a comment -

          added a check on whether the queue is recovered or not. Please review.

          Show
          Himanshu Vashishtha added a comment - added a check on whether the queue is recovered or not. Please review.
          Hide
          Jieshan Bean added a comment -

          I think add this check is not enough. There still has the chance of empty log(Not the writing one) in normal log list.
          So we need to check whether this log is the one in use.

          Show
          Jieshan Bean added a comment - I think add this check is not enough. There still has the chance of empty log(Not the writing one) in normal log list. So we need to check whether this log is the one in use.
          Hide
          Himanshu Vashishtha added a comment -

          I thought it over too.

          There still has the chance of empty log(Not the writing one) in normal log list.

          When do you see this happening? If there are no entries in a log, we usually don't roll. Even if we do roll, we insert some meta data which make its size 134 bytes.
          On an ideal cluster:

          hbase(main):009:0> hlog_roll 'localhost,60020,1365483729051'
          0 row(s) in 0.0210 seconds
          
          hbase(main):010:0> hlog_roll 'localhost,60020,1365483729051'
          0 row(s) in 0.0170 seconds
          
          hbase(main):011:0> hlog_roll 'localhost,60020,1365483729051'
          0 row(s) in 0.0160 seconds
          

          I see log files of size 134 bytes in the log directory.

          -rwxrwxrwx 1 himanshu himanshu 1008 2013-04-08 23:08 localhost%2C60020%2C1365483729051.1365483729440
          -rwxrwxrwx 1 himanshu himanshu  134 2013-04-08 23:08 localhost%2C60020%2C1365483729051.1365484108125
          -rwxrwxrwx 1 himanshu himanshu  134 2013-04-08 23:09 localhost%2C60020%2C1365483729051.1365484126213
          -rwxrwxrwx 1 himanshu himanshu    0 2013-04-08 23:09 localhost%2C60020%2C1365483729051.1365484193328
          
          

          The middle two ones are the ones which didn't see any mutations as such.

          Show
          Himanshu Vashishtha added a comment - I thought it over too. There still has the chance of empty log(Not the writing one) in normal log list. When do you see this happening? If there are no entries in a log, we usually don't roll. Even if we do roll, we insert some meta data which make its size 134 bytes. On an ideal cluster: hbase(main):009:0> hlog_roll 'localhost,60020,1365483729051' 0 row(s) in 0.0210 seconds hbase(main):010:0> hlog_roll 'localhost,60020,1365483729051' 0 row(s) in 0.0170 seconds hbase(main):011:0> hlog_roll 'localhost,60020,1365483729051' 0 row(s) in 0.0160 seconds I see log files of size 134 bytes in the log directory. -rwxrwxrwx 1 himanshu himanshu 1008 2013-04-08 23:08 localhost%2C60020%2C1365483729051.1365483729440 -rwxrwxrwx 1 himanshu himanshu 134 2013-04-08 23:08 localhost%2C60020%2C1365483729051.1365484108125 -rwxrwxrwx 1 himanshu himanshu 134 2013-04-08 23:09 localhost%2C60020%2C1365483729051.1365484126213 -rwxrwxrwx 1 himanshu himanshu 0 2013-04-08 23:09 localhost%2C60020%2C1365483729051.1365484193328 The middle two ones are the ones which didn't see any mutations as such.
          Hide
          Jieshan Bean added a comment -

          Yes, HLog is not empty if it closed succesfully. We may not get EOF.
          But if we get IOE during close, what will happen?

          Show
          Jieshan Bean added a comment - Yes, HLog is not empty if it closed succesfully. We may not get EOF. But if we get IOE during close, what will happen?
          Hide
          Himanshu Vashishtha added a comment -

          Thanks Jiashen.
          In case log rolling gets an exception, it aborts the regionserver after retrying some time (defined by error tolerance in HLog). If it aborts, the log is handled by a failover worker.
          Anyway, to handle your concern, I added a check to to ensure if it is not a current log, then proceed as usual rather than retrying the same log.
          Please review.

          Show
          Himanshu Vashishtha added a comment - Thanks Jiashen. In case log rolling gets an exception, it aborts the regionserver after retrying some time (defined by error tolerance in HLog). If it aborts, the log is handled by a failover worker. Anyway, to handle your concern, I added a check to to ensure if it is not a current log, then proceed as usual rather than retrying the same log. Please review.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12577844/HBase-7122-95-v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577844/HBase-7122-95-v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5224//console This message is automatically generated.
          Hide
          Jieshan Bean added a comment -

          +1 on patch v2.

          Show
          Jieshan Bean added a comment - +1 on patch v2.
          Hide
          Jieshan Bean added a comment -

          BTW, one minor comment. Please add curly brackets to the below code:

          +    if (this.repLogReader.getPosition() == 0 && !queueRecovered && queue.size() == 0)
          +      return true;
          
          Show
          Jieshan Bean added a comment - BTW, one minor comment . Please add curly brackets to the below code: + if ( this .repLogReader.getPosition() == 0 && !queueRecovered && queue.size() == 0) + return true ;
          Hide
          Himanshu Vashishtha added a comment -

          done the formatting.

          Show
          Himanshu Vashishtha added a comment - done the formatting.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12578161/HBase-7122-95-v3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12578161/HBase-7122-95-v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5260//console This message is automatically generated.
          Hide
          stack added a comment -

          Patch looks good. You might change this:

          +    if (this.repLogReader.getPosition() == 0 && !queueRecovered && queue.size() == 0) return true;
          +    return false;
          

          to this

            return this.repLogReader.getPosition() == 0 && !queueRecovered && queue.size() == 0;
          

          When we ask for position in the above, it is not a trip to the NN, right?

          Show
          stack added a comment - Patch looks good. You might change this: + if ( this .repLogReader.getPosition() == 0 && !queueRecovered && queue.size() == 0) return true ; + return false ; to this return this .repLogReader.getPosition() == 0 && !queueRecovered && queue.size() == 0; When we ask for position in the above, it is not a trip to the NN, right?
          Hide
          Chris Trezzo added a comment -

          Stack getPosition is not a round trip and is just the position that the ReplicationHLogReaderManager keeps locally.

          Looked over the patch again, and it looks good to me. Even though I missed the first problem (Nice catch Jieshan Bean)!

          Show
          Chris Trezzo added a comment - Stack getPosition is not a round trip and is just the position that the ReplicationHLogReaderManager keeps locally. Looked over the patch again, and it looks good to me. Even though I missed the first problem (Nice catch Jieshan Bean )!
          Hide
          Himanshu Vashishtha added a comment -

          Yes, as Chris said, this is not a NN call. Thanks for the reviews guys.

          Show
          Himanshu Vashishtha added a comment - Yes, as Chris said, this is not a NN call. Thanks for the reviews guys.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12580133/HBase-7122-95-v4.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12580133/HBase-7122-95-v4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5412//console This message is automatically generated.
          Hide
          stack added a comment -

          Committed trunk and 0.95. Thanks for the patch Himanshu (and reviews lads)

          Show
          stack added a comment - Committed trunk and 0.95. Thanks for the patch Himanshu (and reviews lads)
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #508 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/508/)
          HBASE-7122 Proper warning message when opening a log file with no entries (idle cluster) (Revision 1471255)

          Result = FAILURE
          stack :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #508 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/508/ ) HBASE-7122 Proper warning message when opening a log file with no entries (idle cluster) (Revision 1471255) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Hide
          Hudson added a comment -

          Integrated in hbase-0.95-on-hadoop2 #78 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/78/)
          HBASE-7122 Proper warning message when opening a log file with no entries (idle cluster) (Revision 1471256)

          Result = FAILURE
          stack :
          Files :

          • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Show
          Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #78 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/78/ ) HBASE-7122 Proper warning message when opening a log file with no entries (idle cluster) (Revision 1471256) Result = FAILURE stack : Files : /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #4077 (See https://builds.apache.org/job/HBase-TRUNK/4077/)
          HBASE-7122 Proper warning message when opening a log file with no entries (idle cluster) (Revision 1471255)

          Result = FAILURE
          stack :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #4077 (See https://builds.apache.org/job/HBase-TRUNK/4077/ ) HBASE-7122 Proper warning message when opening a log file with no entries (idle cluster) (Revision 1471255) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Hide
          Hudson added a comment -

          Integrated in hbase-0.95 #160 (See https://builds.apache.org/job/hbase-0.95/160/)
          HBASE-7122 Proper warning message when opening a log file with no entries (idle cluster) (Revision 1471256)

          Result = FAILURE
          stack :
          Files :

          • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Show
          Hudson added a comment - Integrated in hbase-0.95 #160 (See https://builds.apache.org/job/hbase-0.95/160/ ) HBASE-7122 Proper warning message when opening a log file with no entries (idle cluster) (Revision 1471256) Result = FAILURE stack : Files : /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Hide
          Lars Hofhansl added a comment -

          What happened to 0.94?

          Show
          Lars Hofhansl added a comment - What happened to 0.94?
          Hide
          Himanshu Vashishtha added a comment -

          Ok, will upload a 0.94 patch today

          Show
          Himanshu Vashishtha added a comment - Ok, will upload a 0.94 patch today
          Hide
          Lars Hofhansl added a comment -

          Looks good. Will commit to 0.94 tomorrow if I hear no objections.

          Show
          Lars Hofhansl added a comment - Looks good. Will commit to 0.94 tomorrow if I hear no objections.
          Hide
          Lars Hofhansl added a comment -

          Committed to 0.94 as well.

          Show
          Lars Hofhansl added a comment - Committed to 0.94 as well.
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #974 (See https://builds.apache.org/job/HBase-0.94/974/)
          HBASE-7122 Proper warning message when opening a log file with no entries (idle cluster) (Himanshu) (Revision 1479037)

          Result = SUCCESS
          larsh :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #974 (See https://builds.apache.org/job/HBase-0.94/974/ ) HBASE-7122 Proper warning message when opening a log file with no entries (idle cluster) (Himanshu) (Revision 1479037) Result = SUCCESS larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security #141 (See https://builds.apache.org/job/HBase-0.94-security/141/)
          HBASE-7122 Proper warning message when opening a log file with no entries (idle cluster) (Himanshu) (Revision 1479037)

          Result = FAILURE
          larsh :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security #141 (See https://builds.apache.org/job/HBase-0.94-security/141/ ) HBASE-7122 Proper warning message when opening a log file with no entries (idle cluster) (Himanshu) (Revision 1479037) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java

            People

            • Assignee:
              Himanshu Vashishtha
              Reporter:
              Himanshu Vashishtha
            • Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development