[HBASE-7026] Make metrics collection in StoreScanner.java more efficient

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Assignee: Karthik Ranganathan
• Reporter: Karthik Ranganathan
• Created: 22/Oct/12 20:51
• Updated: 14/Jun/22 21:18
• Resolved: 08/Apr/15 21:01

Description

Per the benchmarks I ran, the following block of code seems to be inefficient:
StoreScanner.java:
public synchronized boolean next(List<KeyValue> outResult, int limit,
String metric) throws IOException {
// ...
// update the counter
if (addedResultsSize > 0 && metric != null)

{ HRegion.incrNumericMetric(this.metricNamePrefix + metric, addedResultsSize); }

// ...

Removing this block increased throughput by 10%. We should move this to the outer layer.