Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: mapreduce
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We can remove o.a.h.h.mapreduce.hadoopbackport.* classes since we are going to drop support for hadoop 0.20.

      1. hbase-6706_v1.patch
        52 kB
        stack
      2. hbase-6706_v1.patch
        52 kB
        Enis Soztutar

        Activity

        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #164 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/164/)
        HBASE-6706 Remove TotalOrderPartitioner (Revision 1381881)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-hadoop-compat/src/test/java/org/apache/hadoop/hbase/HadoopShims.java
        • /hbase/trunk/hbase-hadoop1-compat/pom.xml
        • /hbase/trunk/hbase-hadoop1-compat/src/test/java/org/apache/hadoop/hbase/HadoopShimsImpl.java
        • /hbase/trunk/hbase-hadoop1-compat/src/test/resources
        • /hbase/trunk/hbase-hadoop1-compat/src/test/resources/META-INF
        • /hbase/trunk/hbase-hadoop1-compat/src/test/resources/META-INF/services
        • /hbase/trunk/hbase-hadoop1-compat/src/test/resources/META-INF/services/org.apache.hadoop.hbase.HadoopShims
        • /hbase/trunk/hbase-hadoop2-compat/pom.xml
        • /hbase/trunk/hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/HadoopShimsImpl.java
        • /hbase/trunk/hbase-hadoop2-compat/src/test/resources
        • /hbase/trunk/hbase-hadoop2-compat/src/test/resources/META-INF
        • /hbase/trunk/hbase-hadoop2-compat/src/test/resources/META-INF/services
        • /hbase/trunk/hbase-hadoop2-compat/src/test/resources/META-INF/services/org.apache.hadoop.hbase.HadoopShims
        • /hbase/trunk/hbase-server/pom.xml
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/hadoopbackport
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #164 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/164/ ) HBASE-6706 Remove TotalOrderPartitioner (Revision 1381881) Result = FAILURE stack : Files : /hbase/trunk/hbase-hadoop-compat/src/test/java/org/apache/hadoop/hbase/HadoopShims.java /hbase/trunk/hbase-hadoop1-compat/pom.xml /hbase/trunk/hbase-hadoop1-compat/src/test/java/org/apache/hadoop/hbase/HadoopShimsImpl.java /hbase/trunk/hbase-hadoop1-compat/src/test/resources /hbase/trunk/hbase-hadoop1-compat/src/test/resources/META-INF /hbase/trunk/hbase-hadoop1-compat/src/test/resources/META-INF/services /hbase/trunk/hbase-hadoop1-compat/src/test/resources/META-INF/services/org.apache.hadoop.hbase.HadoopShims /hbase/trunk/hbase-hadoop2-compat/pom.xml /hbase/trunk/hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/HadoopShimsImpl.java /hbase/trunk/hbase-hadoop2-compat/src/test/resources /hbase/trunk/hbase-hadoop2-compat/src/test/resources/META-INF /hbase/trunk/hbase-hadoop2-compat/src/test/resources/META-INF/services /hbase/trunk/hbase-hadoop2-compat/src/test/resources/META-INF/services/org.apache.hadoop.hbase.HadoopShims /hbase/trunk/hbase-server/pom.xml /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/hadoopbackport /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java /hbase/trunk/pom.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3313 (See https://builds.apache.org/job/HBase-TRUNK/3313/)
        HBASE-6706 Remove TotalOrderPartitioner (Revision 1381881)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-hadoop-compat/src/test/java/org/apache/hadoop/hbase/HadoopShims.java
        • /hbase/trunk/hbase-hadoop1-compat/pom.xml
        • /hbase/trunk/hbase-hadoop1-compat/src/test/java/org/apache/hadoop/hbase/HadoopShimsImpl.java
        • /hbase/trunk/hbase-hadoop1-compat/src/test/resources
        • /hbase/trunk/hbase-hadoop1-compat/src/test/resources/META-INF
        • /hbase/trunk/hbase-hadoop1-compat/src/test/resources/META-INF/services
        • /hbase/trunk/hbase-hadoop1-compat/src/test/resources/META-INF/services/org.apache.hadoop.hbase.HadoopShims
        • /hbase/trunk/hbase-hadoop2-compat/pom.xml
        • /hbase/trunk/hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/HadoopShimsImpl.java
        • /hbase/trunk/hbase-hadoop2-compat/src/test/resources
        • /hbase/trunk/hbase-hadoop2-compat/src/test/resources/META-INF
        • /hbase/trunk/hbase-hadoop2-compat/src/test/resources/META-INF/services
        • /hbase/trunk/hbase-hadoop2-compat/src/test/resources/META-INF/services/org.apache.hadoop.hbase.HadoopShims
        • /hbase/trunk/hbase-server/pom.xml
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/hadoopbackport
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3313 (See https://builds.apache.org/job/HBase-TRUNK/3313/ ) HBASE-6706 Remove TotalOrderPartitioner (Revision 1381881) Result = FAILURE stack : Files : /hbase/trunk/hbase-hadoop-compat/src/test/java/org/apache/hadoop/hbase/HadoopShims.java /hbase/trunk/hbase-hadoop1-compat/pom.xml /hbase/trunk/hbase-hadoop1-compat/src/test/java/org/apache/hadoop/hbase/HadoopShimsImpl.java /hbase/trunk/hbase-hadoop1-compat/src/test/resources /hbase/trunk/hbase-hadoop1-compat/src/test/resources/META-INF /hbase/trunk/hbase-hadoop1-compat/src/test/resources/META-INF/services /hbase/trunk/hbase-hadoop1-compat/src/test/resources/META-INF/services/org.apache.hadoop.hbase.HadoopShims /hbase/trunk/hbase-hadoop2-compat/pom.xml /hbase/trunk/hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/HadoopShimsImpl.java /hbase/trunk/hbase-hadoop2-compat/src/test/resources /hbase/trunk/hbase-hadoop2-compat/src/test/resources/META-INF /hbase/trunk/hbase-hadoop2-compat/src/test/resources/META-INF/services /hbase/trunk/hbase-hadoop2-compat/src/test/resources/META-INF/services/org.apache.hadoop.hbase.HadoopShims /hbase/trunk/hbase-server/pom.xml /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/hadoopbackport /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java /hbase/trunk/pom.xml
        Hide
        stack added a comment -

        Committed to trunk after running a the cited HFile test and the simple total order partitioner test. Thanks for nice cleanup Enis.

        Show
        stack added a comment - Committed to trunk after running a the cited HFile test and the simple total order partitioner test. Thanks for nice cleanup Enis.
        Hide
        stack added a comment -

        Reattach to see if that'll trigger hadoopqa

        Show
        stack added a comment - Reattach to see if that'll trigger hadoopqa
        Hide
        Enis Soztutar added a comment -
        Show
        Enis Soztutar added a comment - Created RB: https://reviews.apache.org/r/6916/
        Hide
        Enis Soztutar added a comment -

        Attaching a patch which does:

        • Introduce HadoopShims interface in hadoop-compat, and implementations for hadoop1 and hadoop2
        • Remove o.a.h.h.mapreduce.hadoopbackport package.

        The following tests passed for me:

        MAVEN_OPTS=-Xmx512m mvn test -Dtest=TestHFileOutputFormat -PlocalTests
        
        MAVEN_OPTS=-Xmx512m mvn test -Dhadoop.profile=2.0 -Dtest=TestHFileOutputFormat -PlocalTests
        
        MAVEN_OPTS=-Xmx512m mvn test -Dhadoop.profile=2.0 -Dtest=TestHFileOutputFormat -PlocalTests -Dhadoop.version=0.23.2
        
        Show
        Enis Soztutar added a comment - Attaching a patch which does: Introduce HadoopShims interface in hadoop-compat, and implementations for hadoop1 and hadoop2 Remove o.a.h.h.mapreduce.hadoopbackport package. The following tests passed for me: MAVEN_OPTS=-Xmx512m mvn test -Dtest=TestHFileOutputFormat -PlocalTests MAVEN_OPTS=-Xmx512m mvn test -Dhadoop.profile=2.0 -Dtest=TestHFileOutputFormat -PlocalTests MAVEN_OPTS=-Xmx512m mvn test -Dhadoop.profile=2.0 -Dtest=TestHFileOutputFormat -PlocalTests -Dhadoop.version=0.23.2
        Hide
        stack added a comment -

        Agreed. In trunk. Let me make it a blocker since it'd be kinda silly going out w/ them.

        Show
        stack added a comment - Agreed. In trunk. Let me make it a blocker since it'd be kinda silly going out w/ them.

          People

          • Assignee:
            Enis Soztutar
            Reporter:
            Enis Soztutar
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development