HBase
  1. HBase
  2. HBASE-6580

Deprecate HTablePool in favor of HConnection.getTable(...)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.94.6, 0.95.0
    • Fix Version/s: 0.98.0, 0.95.2, 0.94.11
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      This issue introduces a few new APIs:
      * HConnectionManager:
      {code}
          public static HConnection createConnection(Configuration conf)
          public static HConnection createConnection(Configuration conf, ExecutorService pool)
      {code}
      * HConnection:
      {code}
          public HTableInterface getTable(String tableName) throws IOException
          public HTableInterface getTable(byte[] tableName) throws IOException
          public HTableInterface getTable(String tableName, ExecutorService pool) throws IOException
          public HTableInterface getTable(byte[] tableName, ExecutorService pool) throws IOException
      {code}

      By default HConnectionImplementation will create an ExecutorService when needed. The ExecutorService can optionally passed be passed in.
      HTableInterfaces are retrieved from the HConnection. By default the HConnection's ExecutorService is used, but optionally that can be overridden for each HTable.
      Show
      This issue introduces a few new APIs: * HConnectionManager: {code}     public static HConnection createConnection(Configuration conf)     public static HConnection createConnection(Configuration conf, ExecutorService pool) {code} * HConnection: {code}     public HTableInterface getTable(String tableName) throws IOException     public HTableInterface getTable(byte[] tableName) throws IOException     public HTableInterface getTable(String tableName, ExecutorService pool) throws IOException     public HTableInterface getTable(byte[] tableName, ExecutorService pool) throws IOException {code} By default HConnectionImplementation will create an ExecutorService when needed. The ExecutorService can optionally passed be passed in. HTableInterfaces are retrieved from the HConnection. By default the HConnection's ExecutorService is used, but optionally that can be overridden for each HTable.

      Description

      Update:
      I now propose deprecating HTablePool and instead introduce a getTable method on HConnection and allow HConnection to manage the ThreadPool.

      Initial proposal:
      Here I propose a very simple TablePool.
      It could be called LightHTablePool (or something - if you have a better name).
      Internally it would maintain an HConnection and an Executor service and each invocation of getTable(...) would create a new HTable and close() would just close it.
      In testing I find this more light weight than HTablePool and easier to monitor in terms of resources used.

      It would hardly be more than a few dozen lines of code.

      1. 6580-trunk-v6.txt
        24 kB
        Lars Hofhansl
      2. 6580-0.94-v2.txt
        20 kB
        Lars Hofhansl
      3. 6580-0.94.txt
        20 kB
        Lars Hofhansl
      4. 6580-trunk-v5.txt
        24 kB
        Lars Hofhansl
      5. 6580-trunk-v4.txt
        21 kB
        Lars Hofhansl
      6. 6580-trunk-v3.txt
        22 kB
        Lars Hofhansl
      7. 6580-trunk-v2.txt
        20 kB
        Lars Hofhansl
      8. 6580-trunk.txt
        10 kB
        Lars Hofhansl
      9. HBASE-6580_v2.patch
        7 kB
        Adrian Muraru
      10. HBASE-6580_v1.patch
        10 kB
        Adrian Muraru

        Issue Links

          Activity

          Hide
          Andrew Purtell added a comment - - edited

          HConnectionPool ?

          Edit: NM, that's not right either.

          Show
          Andrew Purtell added a comment - - edited HConnectionPool ? Edit: NM, that's not right either.
          Hide
          Lars Hofhansl added a comment -

          SingleConnectionPool? SharedConnectionPool?
          Or just SharedConnection (because that is actually what it is)?

          Show
          Lars Hofhansl added a comment - SingleConnectionPool? SharedConnectionPool? Or just SharedConnection (because that is actually what it is)?
          Hide
          Lars Hofhansl added a comment -

          I can even see replacing the current HTablePool with this.
          It is simpler, should be faster, and definitely more lightweight.

          Show
          Lars Hofhansl added a comment - I can even see replacing the current HTablePool with this. It is simpler, should be faster, and definitely more lightweight.
          Hide
          Andrew Purtell added a comment -

          I can even see replacing the current HTablePool with this.

          I can see this. I believe we have a lot of users of the current HTablePool, so should be API compatible including constructors.

          Show
          Andrew Purtell added a comment - I can even see replacing the current HTablePool with this. I can see this. I believe we have a lot of users of the current HTablePool, so should be API compatible including constructors.
          Hide
          Lars Hofhansl added a comment -

          Hmmm... HTablePool currently optionally takes an HTableInterfaceFactory. With the model proposed here, I cannot support that, since HTable creation is precisely what I need to control.
          Maybe this is the right hint, though, and what I am looking for is:

          class SingleConnectionHTableFactory implement HTableInterfaceFactory {
          ...
          }
          

          Rather than a table pool.

          Show
          Lars Hofhansl added a comment - Hmmm... HTablePool currently optionally takes an HTableInterfaceFactory. With the model proposed here, I cannot support that, since HTable creation is precisely what I need to control. Maybe this is the right hint, though, and what I am looking for is: class SingleConnectionHTableFactory implement HTableInterfaceFactory { ... } Rather than a table pool.
          Hide
          Lars Hofhansl added a comment -

          I likely won't get time to on this.

          Show
          Lars Hofhansl added a comment - I likely won't get time to on this.
          Hide
          Adrian Muraru added a comment -

          This is something we need in production as well.
          Digging deeper I see the underlying HConnection is already shared in the current HTablePool impl. (i.e there is a single, private Configuration instance passed when HTablePool is initialised and used for all HTable instances built by pool).

          What is missing is a shared ExecutorService for all htable's so I called it SharedExecutorHTableFactory

          Patch attached (it's on hbase-trunk but I can easily port to 0.92 and 0.94)

          Show
          Adrian Muraru added a comment - This is something we need in production as well. Digging deeper I see the underlying HConnection is already shared in the current HTablePool impl. (i.e there is a single, private Configuration instance passed when HTablePool is initialised and used for all HTable instances built by pool). What is missing is a shared ExecutorService for all htable's so I called it SharedExecutorHTableFactory Patch attached (it's on hbase-trunk but I can easily port to 0.92 and 0.94)
          Hide
          Lars Hofhansl added a comment -

          That would work. Ideally I'd like to get HTablePool out of the mix. It's heavy weight and not needed (and in fact just adds overhead) if the both the connection and thread pool are shared between HTables.

          Show
          Lars Hofhansl added a comment - That would work. Ideally I'd like to get HTablePool out of the mix. It's heavy weight and not needed (and in fact just adds overhead) if the both the connection and thread pool are shared between HTables.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12554094/HBASE-6580_v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 99 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.TestCheckTestClasses

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12554094/HBASE-6580_v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 99 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestCheckTestClasses Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3360//console This message is automatically generated.
          Hide
          Adrian Muraru added a comment -

          Lars, I agree the HTablePool is overkill here for these lightweight HTable instances but we'd still need a kind of borrow/release pooling mech for them to avoid creating a new instance every time one is needed.

          Show
          Adrian Muraru added a comment - Lars, I agree the HTablePool is overkill here for these lightweight HTable instances but we'd still need a kind of borrow/release pooling mech for them to avoid creating a new instance every time one is needed.
          Hide
          Lars Hofhansl added a comment -

          Not really. After HBASE-4805 you'd create a single HConnection (via HConnectionManager.createConnection(...)) and then use this for each HTable created afterwards. HTable creation is very cheap when both HConnection and ExecutorService are passed... Cheaper indeed than then the HTablePool protocol.

          Maybe HConnection should just finally get a getTable(...) method.

          Show
          Lars Hofhansl added a comment - Not really. After HBASE-4805 you'd create a single HConnection (via HConnectionManager.createConnection(...)) and then use this for each HTable created afterwards. HTable creation is very cheap when both HConnection and ExecutorService are passed... Cheaper indeed than then the HTablePool protocol. Maybe HConnection should just finally get a getTable(...) method.
          Hide
          Gary Helmling added a comment -

          Maybe HConnection should just finally get a getTable(...) method.

          +1. Using HConnection to get an HTable seems more intuitive and more composable than our old monolithic HTable. Lightweight HTables that are easily GC'd would also be very nice. Agree that at that point we don't really need HTablePool.

          Show
          Gary Helmling added a comment - Maybe HConnection should just finally get a getTable(...) method. +1. Using HConnection to get an HTable seems more intuitive and more composable than our old monolithic HTable. Lightweight HTables that are easily GC'd would also be very nice. Agree that at that point we don't really need HTablePool.
          Hide
          Adrian Muraru added a comment -

          Added HConnection#getTable()

          Show
          Adrian Muraru added a comment - Added HConnection#getTable()
          Hide
          Adrian Muraru added a comment -

          Added HConnection#getTable()

          Show
          Adrian Muraru added a comment - Added HConnection#getTable()
          Hide
          Ted Yu added a comment -

          For HConnection.java, please add javadoc for tableName parameter.

          +    // thread executor shared by all HTableInterface instances created
          +    // by this connection
          

          nit: 'created by' -> 'created from'

          +       } catch (InterruptedException e) {
          +         this.hTableExecutor.shutdownNow();
          +       }
          

          Please restore interrupt status above.

          +     if (hTableExecutor == null) {
          +       // shared HTable thread executor not yet initialized
          +       synchronized (this) {
          +         if (hTableExecutor == null) {
          

          Why use double checked locking ? Connection would be used to create (at least) one table, right ?

          Show
          Ted Yu added a comment - For HConnection.java, please add javadoc for tableName parameter. + // thread executor shared by all HTableInterface instances created + // by this connection nit: 'created by' -> 'created from' + } catch (InterruptedException e) { + this .hTableExecutor.shutdownNow(); + } Please restore interrupt status above. + if (hTableExecutor == null ) { + // shared HTable thread executor not yet initialized + synchronized ( this ) { + if (hTableExecutor == null ) { Why use double checked locking ? Connection would be used to create (at least) one table, right ?
          Hide
          Lars Hofhansl added a comment -

          Couple of things:

          1. Should allow passing an ExecutorService to HConnectionManager.createConnection(...). In fact I would require that now, and have that as the only option to setup the ExecutorService.
          2. getTable must fail if this is a "managed", i.e. not created by createConnection (check the managed flag for that). Otherwise the HTable and the HConnection will get very confused.

          I love where this is going. I wanted to do this a while ago, but felt that we're not mentally ready for this

          Show
          Lars Hofhansl added a comment - Couple of things: Should allow passing an ExecutorService to HConnectionManager.createConnection(...). In fact I would require that now, and have that as the only option to setup the ExecutorService. getTable must fail if this is a "managed", i.e. not created by createConnection (check the managed flag for that). Otherwise the HTable and the HConnection will get very confused. I love where this is going. I wanted to do this a while ago, but felt that we're not mentally ready for this
          Hide
          Adrian Muraru added a comment -

          Ted Yu Thanks for having a look

          Why use double checked locking ? Connection would be used to create (at least) one table, right ?

          We want to have multiple HTable instances sharing the same HConnection (this) and the same ExecutorService so I ensure only one executor is ever instantiated

          Show
          Adrian Muraru added a comment - Ted Yu Thanks for having a look Why use double checked locking ? Connection would be used to create (at least) one table, right ? We want to have multiple HTable instances sharing the same HConnection (this) and the same ExecutorService so I ensure only one executor is ever instantiated
          Hide
          Adrian Muraru added a comment -

          Lars Hofhansl

          Should allow passing an ExecutorService to HConnectionManager.createConnection(...). In fact I would require that now, and have that as the only option to setup the ExecutorService.

          Managing the shared ExecutorService internally would be more usable for the user in my opinion, no need to create or shutdown - I look at this executor as an internal detail used to execute some table operations in parallel.

          getTable must fail if this is a "managed", i.e. not created by createConnection (check the managed flag for that). Otherwise the HTable and the HConnection will get very confused.

          Can you elaborate? Why is not advisable to use a "managed" connection when creating a HTable.
          I can do today :
          HTable t = new HTable(tableName, HConnectionManager.getConnection(conf), pool)
          and have an HTable using a "managed" connection

          Show
          Adrian Muraru added a comment - Lars Hofhansl Should allow passing an ExecutorService to HConnectionManager.createConnection(...). In fact I would require that now, and have that as the only option to setup the ExecutorService. Managing the shared ExecutorService internally would be more usable for the user in my opinion, no need to create or shutdown - I look at this executor as an internal detail used to execute some table operations in parallel. getTable must fail if this is a "managed", i.e. not created by createConnection (check the managed flag for that). Otherwise the HTable and the HConnection will get very confused. Can you elaborate? Why is not advisable to use a "managed" connection when creating a HTable. I can do today : HTable t = new HTable(tableName, HConnectionManager.getConnection(conf), pool) and have an HTable using a "managed" connection
          Hide
          Lars Hofhansl added a comment -

          You will never be able to size the ExecutorService correctly without knowing the app. This pool is used by all HTable instances using this Connection to parallelize their requests to the RegionServers.
          I'd rather have people think about it, rather than having a default that will likely not be right for their use case.
          Starting with single core thread is not right. There needs to be at least an option to pass in a custom ExecutorService.

          I can do today: HTable t = new HTable(tableName, HConnectionManager.getConnection(conf), pool)

          You can do that, and it might even work for a bit
          HConnectionManager.getConnection(...) is meant for cases where the connection is created (and potentially cached) on behalf of an HTable.
          I suppose that constructor should throw an exception is the connection is managed.
          This stuff is very confusing about our client.

          Like HTablePool, HConnectionManager.getConnection should just go away.

          Show
          Lars Hofhansl added a comment - You will never be able to size the ExecutorService correctly without knowing the app. This pool is used by all HTable instances using this Connection to parallelize their requests to the RegionServers. I'd rather have people think about it, rather than having a default that will likely not be right for their use case. Starting with single core thread is not right. There needs to be at least an option to pass in a custom ExecutorService. I can do today: HTable t = new HTable(tableName, HConnectionManager.getConnection(conf), pool) You can do that, and it might even work for a bit HConnectionManager.getConnection(...) is meant for cases where the connection is created (and potentially cached) on behalf of an HTable. I suppose that constructor should throw an exception is the connection is managed. This stuff is very confusing about our client. Like HTablePool, HConnectionManager.getConnection should just go away.
          Hide
          Lars Hofhansl added a comment -

          Also as part of this, I would like to propose to remove HTablePool for good.
          (You do not have to do this part Andrian, unless you like to , I'll happily do an addon patch.

          Show
          Lars Hofhansl added a comment - Also as part of this, I would like to propose to remove HTablePool for good. (You do not have to do this part Andrian, unless you like to , I'll happily do an addon patch.
          Hide
          Adrian Muraru added a comment -

          Lars, you're right, having a way to pass an already fine tuned executor is useful such cases. building one from configuration params might not be enough. Thinking of this, I'm more in favour of adding executor param to #getTable In order to Alloa mixt workloads to share the HConnection placement info

          ExecutorService lowPriority=....
          ExecutorService highPriority=....

          HC conn= HCM.createConnection()
          conn.getTable(table1, lowPriority)
          conn.getTable(table2, highPriority)

          +1 removing HTablePool
          +1 removing managed HConnections - is this doable? Do we use it elsewhere?
          +1 keep only lightweight HTable ctors

          Show
          Adrian Muraru added a comment - Lars, you're right, having a way to pass an already fine tuned executor is useful such cases. building one from configuration params might not be enough. Thinking of this, I'm more in favour of adding executor param to #getTable In order to Alloa mixt workloads to share the HConnection placement info ExecutorService lowPriority=.... ExecutorService highPriority=.... HC conn= HCM.createConnection() conn.getTable(table1, lowPriority) conn.getTable(table2, highPriority) +1 removing HTablePool +1 removing managed HConnections - is this doable? Do we use it elsewhere? +1 keep only lightweight HTable ctors
          Hide
          Ted Yu added a comment -

          w.r.t. removing HTablePool, is there discussion / notification on user mail list ?

          Show
          Ted Yu added a comment - w.r.t. removing HTablePool, is there discussion / notification on user mail list ?
          Hide
          stack added a comment -

          +1 on removing broke, misleading HTablePool in 0.96

          Show
          stack added a comment - +1 on removing broke, misleading HTablePool in 0.96
          Hide
          Adrian Muraru added a comment -

          renaming the issue title would be good as well; to reflect the changes planned : something like "Remove HTablePool and replace it with lightweight HTable" would grab the necessary attn I guess

          Show
          Adrian Muraru added a comment - renaming the issue title would be good as well; to reflect the changes planned : something like "Remove HTablePool and replace it with lightweight HTable" would grab the necessary attn I guess
          Hide
          Lars Hofhansl added a comment -

          Hmm... HConnection.getTable(byte[], ExecutorService) is not that much better than new HTable(byte[], HConnection, ExecutorService).

          Note that a single HTable can use many threads to parallelize update requests to multiple region servers.

          Let's do this?

          • optionally allow createConnection to be passed a ExecutorService, I think we can document that this service will be closed when the connection is closed. If none is passed create the executor as you do (but maybe with more core threads that do not time out?).
          • optionally allow getTable to override the ExecutorService.

          (For example: In our case we'll have an ExecutorService with something like 100 core threads, a wait queue of size 100, and max size of 200... For a total of 300 outstanding update requests across all HTable instances).

          Show
          Lars Hofhansl added a comment - Hmm... HConnection.getTable(byte[], ExecutorService) is not that much better than new HTable(byte[], HConnection, ExecutorService) . Note that a single HTable can use many threads to parallelize update requests to multiple region servers. Let's do this? optionally allow createConnection to be passed a ExecutorService, I think we can document that this service will be closed when the connection is closed. If none is passed create the executor as you do (but maybe with more core threads that do not time out?). optionally allow getTable to override the ExecutorService. (For example: In our case we'll have an ExecutorService with something like 100 core threads, a wait queue of size 100, and max size of 200... For a total of 300 outstanding update requests across all HTable instances).
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12555580/HBASE-6580_v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 107 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 23 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12555580/HBASE-6580_v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 107 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 23 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3520//console This message is automatically generated.
          Hide
          Lars Hofhansl added a comment -

          Seems Adrian lost interest. I'll try to finish this.

          Show
          Lars Hofhansl added a comment - Seems Adrian lost interest. I'll try to finish this.
          Hide
          stack added a comment -

          Lars Hofhansl We going to remove broke HTablePool for 0.96?

          Show
          stack added a comment - Lars Hofhansl We going to remove broke HTablePool for 0.96?
          Hide
          Lars Hofhansl added a comment -

          I want to. It is hard to create a method for method replacement, though.
          We could say HTablePool be gone in 0.96, or we could make a best effort replacement, that would let the majority of people recompile their existing code for 0.96 without changes.

          Show
          Lars Hofhansl added a comment - I want to. It is hard to create a method for method replacement, though. We could say HTablePool be gone in 0.96, or we could make a best effort replacement, that would let the majority of people recompile their existing code for 0.96 without changes.
          Hide
          stack added a comment -

          Lars Hofhansl Yeah, the latter suggestion would be the grown-up thing to do. Make new, critical issue?

          Show
          stack added a comment - Lars Hofhansl Yeah, the latter suggestion would be the grown-up thing to do. Make new, critical issue?
          Hide
          stack added a comment -

          Lars Hofhansl This one going to go in?

          Show
          stack added a comment - Lars Hofhansl This one going to go in?
          Hide
          Lars Hofhansl added a comment -

          Here's the proposed new API:

          • HConnectionManager:
                public static HConnection createConnection(Configuration conf)
                public static HConnection createConnection(Configuration conf, ExecutorService pool)
            
          • HConnection:
                public HTableInterface getTable(byte[] tableName) throws IOException {
                public HTableInterface getTable(byte[] tableName, ExecutorService pool) throws IOException {
                public HTableInterface getTable(String tableName) throws IOException {
            

          By default HConnectionImplementation will create an ExecutorService when needed. The ExecutorService can optionally passed be passed in.
          HTableInterfaces are retrieved from the HConnection. By default the HConnection's ExecutorService is used, but optionally that can be overridden for each HTable.

          Show
          Lars Hofhansl added a comment - Here's the proposed new API: HConnectionManager: public static HConnection createConnection(Configuration conf) public static HConnection createConnection(Configuration conf, ExecutorService pool) HConnection: public HTableInterface getTable( byte [] tableName) throws IOException { public HTableInterface getTable( byte [] tableName, ExecutorService pool) throws IOException { public HTableInterface getTable( String tableName) throws IOException { By default HConnectionImplementation will create an ExecutorService when needed. The ExecutorService can optionally passed be passed in. HTableInterfaces are retrieved from the HConnection. By default the HConnection's ExecutorService is used, but optionally that can be overridden for each HTable.
          Hide
          Lars Hofhansl added a comment -

          I'll like to get consensus here first. Then I'll post the new API to the dev list to get more feedback.

          Could use some help with the documentation in the Javadoc in HConnection and HConnectionManager.

          Show
          Lars Hofhansl added a comment - I'll like to get consensus here first. Then I'll post the new API to the dev list to get more feedback. Could use some help with the documentation in the Javadoc in HConnection and HConnectionManager.
          Hide
          stack added a comment -

          The difference between HCM#getConnection and HCM#createConnection is that the latter will ALWAYS create a "cluster connection"? That sounds good.

          (How hard to change HTable into an Interface?)

          API looks good to me.

          Show
          stack added a comment - The difference between HCM#getConnection and HCM#createConnection is that the latter will ALWAYS create a "cluster connection"? That sounds good. (How hard to change HTable into an Interface?) API looks good to me.
          Hide
          Lars Hofhansl added a comment -

          the difference between HCM#getConnection and HCM#createConnection is that the latter will ALWAYS create a "cluster connection"?

          Yep. It also indicates that the caller needs to manage the lifecycle (i.e. eventually close()'ing the connection).

          Should probably deprecate HCM#getConnection as well.

          (How hard to change HTable into an Interface?)

          HTable is the implementation of HTableInterface. The patch only exposes HTableInterface.
          Should we rename HTableInterface to HTable and HTable to HTableImplementation?

          Oh, I see. You saying HTable should not have any public constructors? Can deprecate those as well.

          Show
          Lars Hofhansl added a comment - the difference between HCM#getConnection and HCM#createConnection is that the latter will ALWAYS create a "cluster connection"? Yep. It also indicates that the caller needs to manage the lifecycle (i.e. eventually close()'ing the connection). Should probably deprecate HCM#getConnection as well. (How hard to change HTable into an Interface?) HTable is the implementation of HTableInterface. The patch only exposes HTableInterface. Should we rename HTableInterface to HTable and HTable to HTableImplementation? Oh, I see. You saying HTable should not have any public constructors? Can deprecate those as well.
          Hide
          Lars Hofhansl added a comment -

          Also, do this in 0.94? So we get the deprecation in?
          I'm fine with punting on this in 0.94 as it is really just convenience. The existing HTable constructors provide all this functionality (albeit in a more clumsy way).

          Show
          Lars Hofhansl added a comment - Also, do this in 0.94? So we get the deprecation in? I'm fine with punting on this in 0.94 as it is really just convenience. The existing HTable constructors provide all this functionality (albeit in a more clumsy way).
          Hide
          stack added a comment -

          Could do it in 0.94. Doing the deprecation this late in the game probably doesn't really count toward 0.96.

          Show
          stack added a comment - Could do it in 0.94. Doing the deprecation this late in the game probably doesn't really count toward 0.96.
          Hide
          Nicolas Liochon added a comment -

          +1 to deprecate it in 0.94 & 0.96, keeping it in 0.96, removing it in 0.98.

          Show
          Nicolas Liochon added a comment - +1 to deprecate it in 0.94 & 0.96, keeping it in 0.96, removing it in 0.98.
          Hide
          Lars Hofhansl added a comment -

          Cool. I'll remove all the old cruft in a separate trunk only jira: HTablePool, HCM#getConnection and all the related caching and cache key generation, the public constructors on HTable, etc.
          (We'll be spinning 0.96 from the 0.95 branch, right?)

          Show
          Lars Hofhansl added a comment - Cool. I'll remove all the old cruft in a separate trunk only jira: HTablePool, HCM#getConnection and all the related caching and cache key generation, the public constructors on HTable, etc. (We'll be spinning 0.96 from the 0.95 branch, right?)
          Hide
          Lars Hofhansl added a comment -

          Filed HBASE-9117 for this.

          Show
          Lars Hofhansl added a comment - Filed HBASE-9117 for this.
          Hide
          Gary Helmling added a comment -

          +1 on patch and deprecation plan as described by Nicolas Liochon. Looks like the patch has tabs in it though?

          Show
          Gary Helmling added a comment - +1 on patch and deprecation plan as described by Nicolas Liochon . Looks like the patch has tabs in it though?
          Hide
          Gary Helmling added a comment -

          Err, sorry, looking at the wrong patch.

          Show
          Gary Helmling added a comment - Err, sorry, looking at the wrong patch.
          Hide
          Gary Helmling added a comment -

          +1 on 6580-trunk.txt.

          Show
          Gary Helmling added a comment - +1 on 6580-trunk.txt.
          Hide
          stack added a comment -

          Yes. 0.96 is off 0.95 branch.

          Show
          stack added a comment - Yes. 0.96 is off 0.95 branch.
          Hide
          Lars Hofhansl added a comment -

          I'll work on some test changes to use the new APIs, and spend some time on the JavaDoc in HCM.
          Going to commit to all branches (including 0.94) early next week.

          Show
          Lars Hofhansl added a comment - I'll work on some test changes to use the new APIs, and spend some time on the JavaDoc in HCM. Going to commit to all branches (including 0.94) early next week.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12595554/6580-trunk.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 4 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestClientNoCluster

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12595554/6580-trunk.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 4 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestClientNoCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6592//console This message is automatically generated.
          Hide
          Lars Hofhansl added a comment -

          Updated patch. Previous version did not make the required constructor accessible.

          Also modified Javadoc some and added basic section to book.xml.
          (I expect the JavaDoc/book.xml updated further in trunk when all the connection caching nonsense is removed)

          Show
          Lars Hofhansl added a comment - Updated patch. Previous version did not make the required constructor accessible. Also modified Javadoc some and added basic section to book.xml. (I expect the JavaDoc/book.xml updated further in trunk when all the connection caching nonsense is removed)
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12595834/6580-trunk-v2.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 4 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestClientNoCluster

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12595834/6580-trunk-v2.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 4 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestClientNoCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6600//console This message is automatically generated.
          Hide
          Lars Hofhansl added a comment -

          Fixing TestClientNoCluster

          Show
          Lars Hofhansl added a comment - Fixing TestClientNoCluster
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12595845/6580-trunk-v3.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 4 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
          org.apache.hadoop.hbase.client.TestFromClientSide

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12595845/6580-trunk-v3.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 9 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 4 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor org.apache.hadoop.hbase.client.TestFromClientSide Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6603//console This message is automatically generated.
          Hide
          Lars Hofhansl added a comment -

          Meh... This one should pass all tests.

          Show
          Lars Hofhansl added a comment - Meh... This one should pass all tests.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12595855/6580-trunk-v4.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 4 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.zookeeper.lock.TestZKInterProcessReadWriteLock

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12595855/6580-trunk-v4.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 9 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 4 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.zookeeper.lock.TestZKInterProcessReadWriteLock Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6604//console This message is automatically generated.
          Hide
          Lars Hofhansl added a comment -

          TestZKInterProcessReadWriteLock passes locally.

          Show
          Lars Hofhansl added a comment - TestZKInterProcessReadWriteLock passes locally.
          Hide
          stack added a comment -

          HBASE-7980 TestZKInterProcessReadWriteLock is known flakey (I should just disable it since no one is looking at it).

          Patch lgtm on skim. Hurray HTablePool is deprecated!

          Show
          stack added a comment - HBASE-7980 TestZKInterProcessReadWriteLock is known flakey (I should just disable it since no one is looking at it). Patch lgtm on skim. Hurray HTablePool is deprecated!
          Hide
          Lars Hofhansl added a comment -

          Added getTable(String, ExecutorService) API. Added simple test to TestHCM to exercise new APIs.

          Should be getting close.

          Show
          Lars Hofhansl added a comment - Added getTable(String, ExecutorService) API. Added simple test to TestHCM to exercise new APIs. Should be getting close.
          Hide
          Lars Hofhansl added a comment -

          I might want to move this to 0.94.12, so that we can do proper review/testing on this (I would like to spin 0.94.11 today).

          Show
          Lars Hofhansl added a comment - I might want to move this to 0.94.12, so that we can do proper review/testing on this (I would like to spin 0.94.11 today).
          Hide
          Lars Hofhansl added a comment -

          Moving to 0.94.12. Preparing for 0.94.11

          Show
          Lars Hofhansl added a comment - Moving to 0.94.12. Preparing for 0.94.11
          Hide
          Lars Hofhansl added a comment -

          In the fact the 0.94 patch will be quite a bit different.

          Show
          Lars Hofhansl added a comment - In the fact the 0.94 patch will be quite a bit different.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12596185/6580-trunk-v5.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 4 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12596185/6580-trunk-v5.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 9 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 4 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6609//console This message is automatically generated.
          Hide
          Lars Hofhansl added a comment -

          0.94 patch. Compiles fine. Running full suite now.

          Show
          Lars Hofhansl added a comment - 0.94 patch. Compiles fine. Running full suite now.
          Hide
          Lars Hofhansl added a comment -

          0.94 test results:

          Tests run: 1377, Failures: 0, Errors: 0, Skipped: 13

          Please have a closer look. I am planning to commit this to all branches soon.
          (I'll also fix the javadoc warning before commit)

          Show
          Lars Hofhansl added a comment - 0.94 test results: Tests run: 1377, Failures: 0, Errors: 0, Skipped: 13 Please have a closer look. I am planning to commit this to all branches soon. (I'll also fix the javadoc warning before commit)
          Hide
          Ted Yu added a comment -

          +1
          nit, in several places:

          +   * be create for each using thread.
          

          'create' -> 'created'

          Show
          Ted Yu added a comment - +1 nit, in several places: + * be create for each using thread. 'create' -> 'created'
          Hide
          Lars Hofhansl added a comment -

          Fix spelling in 0.94 patch.

          Show
          Lars Hofhansl added a comment - Fix spelling in 0.94 patch.
          Hide
          Lars Hofhansl added a comment -

          Same for trunk, also fixes the JavaDoc warnings.

          Show
          Lars Hofhansl added a comment - Same for trunk, also fixes the JavaDoc warnings.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12596665/6580-trunk-v6.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12596665/6580-trunk-v6.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 9 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6638//console This message is automatically generated.
          Hide
          Lars Hofhansl added a comment -

          Going to commit today or tomorrow.

          Show
          Lars Hofhansl added a comment - Going to commit today or tomorrow.
          Hide
          Jean-Daniel Cryans added a comment -

          +1

          Show
          Jean-Daniel Cryans added a comment - +1
          Hide
          Elliott Clark added a comment -

          +1 I can't wait to update some code to use this

          Show
          Elliott Clark added a comment - +1 I can't wait to update some code to use this
          Hide
          Lars Hofhansl added a comment -

          Committed to 0.94, 0.95, and trunk.
          Die HTablePool! (soon)

          Show
          Lars Hofhansl added a comment - Committed to 0.94, 0.95, and trunk. Die HTablePool! (soon)
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.94 #1099 (See https://builds.apache.org/job/HBase-0.94/1099/)
          HBASE-6580 Deprecate HTablePool in favor of HConnection.getTable(...) (larsh: rev 1511545)

          • /hbase/branches/0.94/src/docbkx/book.xml
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHConnection.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.94 #1099 (See https://builds.apache.org/job/HBase-0.94/1099/ ) HBASE-6580 Deprecate HTablePool in favor of HConnection.getTable(...) (larsh: rev 1511545) /hbase/branches/0.94/src/docbkx/book.xml /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnection.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHConnection.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.94-security #248 (See https://builds.apache.org/job/HBase-0.94-security/248/)
          HBASE-6580 Deprecate HTablePool in favor of HConnection.getTable(...) (larsh: rev 1511545)

          • /hbase/branches/0.94/src/docbkx/book.xml
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHConnection.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #248 (See https://builds.apache.org/job/HBase-0.94-security/248/ ) HBASE-6580 Deprecate HTablePool in favor of HConnection.getTable(...) (larsh: rev 1511545) /hbase/branches/0.94/src/docbkx/book.xml /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnection.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestHConnection.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in hbase-0.95 #414 (See https://builds.apache.org/job/hbase-0.95/414/)
          HBASE-6580 Deprecate HTablePool in favor of HConnection.getTable(...) (larsh: rev 1511544)

          • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
          • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
          • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionWrapper.java
          • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
          • /hbase/branches/0.95/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java
          • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
          • /hbase/branches/0.95/src/main/docbkx/book.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in hbase-0.95 #414 (See https://builds.apache.org/job/hbase-0.95/414/ ) HBASE-6580 Deprecate HTablePool in favor of HConnection.getTable(...) (larsh: rev 1511544) /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnection.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionWrapper.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java /hbase/branches/0.95/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java /hbase/branches/0.95/src/main/docbkx/book.xml
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #4353 (See https://builds.apache.org/job/HBase-TRUNK/4353/)
          HBASE-6580 Deprecate HTablePool in favor of HConnection.getTable(...) (larsh: rev 1511543)

          • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
          • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
          • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionWrapper.java
          • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
          • /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
          • /hbase/trunk/src/main/docbkx/book.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4353 (See https://builds.apache.org/job/HBase-TRUNK/4353/ ) HBASE-6580 Deprecate HTablePool in favor of HConnection.getTable(...) (larsh: rev 1511543) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnection.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionWrapper.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java /hbase/trunk/src/main/docbkx/book.xml
          Hide
          Hudson added a comment -

          FAILURE: Integrated in hbase-0.95-on-hadoop2 #224 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/224/)
          HBASE-6580 Deprecate HTablePool in favor of HConnection.getTable(...) (larsh: rev 1511544)

          • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
          • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
          • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionWrapper.java
          • /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
          • /hbase/branches/0.95/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java
          • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
          • /hbase/branches/0.95/src/main/docbkx/book.xml
          Show
          Hudson added a comment - FAILURE: Integrated in hbase-0.95-on-hadoop2 #224 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/224/ ) HBASE-6580 Deprecate HTablePool in favor of HConnection.getTable(...) (larsh: rev 1511544) /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnection.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionWrapper.java /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java /hbase/branches/0.95/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java /hbase/branches/0.95/src/main/docbkx/book.xml
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #657 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/657/)
          HBASE-6580 Deprecate HTablePool in favor of HConnection.getTable(...) (larsh: rev 1511543)

          • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
          • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
          • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionWrapper.java
          • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
          • /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
          • /hbase/trunk/src/main/docbkx/book.xml
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #657 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/657/ ) HBASE-6580 Deprecate HTablePool in favor of HConnection.getTable(...) (larsh: rev 1511543) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnection.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionWrapper.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java /hbase/trunk/src/main/docbkx/book.xml

            People

            • Assignee:
              Lars Hofhansl
              Reporter:
              Lars Hofhansl
            • Votes:
              0 Vote for this issue
              Watchers:
              16 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development