[HBASE-6469] Failure on enable/disable table will cause table state in zk to be left as enabling/disabling until master is restarted

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Invalid
• Affects Version/s: 0.94.6
• Component/s: master
• Release Note: Introduces new 'force' option for enabling and disabling tables. Allows an advanced user to impose a change on table status, ie, such as after running hbck.
• Assignee: Unassigned
• Reporter: Enis Soztutar
• Created: 27/Jul/12 22:45
• Updated: 13/Jun/22 16:56
• Resolved: 15/Sep/14 20:07

Description

In Enable/DisableTableHandler code, if something goes wrong in handling, the table state in zk is left as ENABLING / DISABLING. After that we cannot force any more action from the API or CLI, and the only recovery path is restarting the master.

    if (done) {
      // Flip the table to enabled.
      this.assignmentManager.getZKTable().setEnabledTable(
        this.tableNameStr);
      LOG.info("Table '" + this.tableNameStr
      + "' was successfully enabled. Status: done=" + done);
    } else {
      LOG.warn("Table '" + this.tableNameStr
      + "' wasn't successfully enabled. Status: done=" + done);
    }

Here, if done is false, the table state is not changed. There is also no way to set skipTableStateCheck from cli / api.

We have run into this issue a couple of times before.

Issue Links

• is related to: HBASE-8233 Poke the ZKTable cache and let the system reload cached information
• relates to: HBASE-6484 Make AssignmentManger#enablingTables and disablintTables local variables