Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-6433

Improve HBaseServer#getRemoteAddress by utilizing HBaseServer.Connection.hostAddress

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.94.1, 0.95.0
    • None
    • None
    • Reviewed

    Description

      Currently, HBaseServer#getRemoteAddress would call getRemoteIp(), leading to call.connection.socket.getInetAddress().

      The host address is actually stored in HBaseServer.Connection.hostAddress field. We don't need to go through Socket to get this information.

      Without this patch it costs 4000ns, with this patch it costs 1600ns

      Attachments

        1. 6433-getRemoteAddress-trunk.txt
          0.7 kB
          Ted Yu
        2. HBASE-6433-90.patch
          0.9 kB
          Lijin Bin
        3. HBASE-6433-92.patch
          1 kB
          Lijin Bin
        4. HBASE-6433-94.patch
          2 kB
          Lijin Bin
        5. HBASE-6433-trunk.patch
          4 kB
          Lijin Bin

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. HADOOP-8773 Improve Server#getRemoteAddress by utilizing Server.Connection.hostAddress

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            People

              binlijin Lijin Bin
              binlijin Lijin Bin
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: