[HBASE-6433] Improve HBaseServer#getRemoteAddress by utilizing HBaseServer.Connection.hostAddress - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 0.94.1, 0.95.0
Component/s: None
Labels:
None

Hadoop Flags:

Reviewed

Description

Currently, HBaseServer#getRemoteAddress would call getRemoteIp(), leading to call.connection.socket.getInetAddress().

The host address is actually stored in HBaseServer.Connection.hostAddress field. We don't need to go through Socket to get this information.

Without this patch it costs 4000ns, with this patch it costs 1600ns

Attachments

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending

6433-getRemoteAddress-trunk.txt
20/Jul/12 15:09
0.7 kB
Ted Yu
HBASE-6433-trunk.patch
20/Jul/12 10:43
4 kB
Lijin Bin
HBASE-6433-94.patch
20/Jul/12 10:43
2 kB
Lijin Bin
HBASE-6433-90.patch
20/Jul/12 10:43
0.9 kB
Lijin Bin
HBASE-6433-92.patch
20/Jul/12 10:43
1 kB
Lijin Bin

Issue Links

is related to

HADOOP-8773 Improve Server#getRemoteAddress by utilizing Server.Connection.hostAddress

Open

Activity

People

Assignee:: Lijin Bin

Reporter:: Lijin Bin

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 20/Jul/12 10:24

Updated:: 02/May/13 02:30

Resolved:: 22/Jul/12 19:13