Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-6377

HBASE-5533 metrics miss all operations submitted via MultiAction

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.94.1, 0.95.2
    • Fix Version/s: 0.94.1, 0.95.0
    • Component/s: metrics, regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      The misleading "getRequestLatency", "deleteRequestLatency", and "putRequestLatency" histograms were removed from metrics because such requests often were not actually measured.

      Description

      A client application (LoadTestTool) calls put() on HTables. Internally to the HBase client those puts are batched into MultiActions. The total number of put operations shown in the RegionServer's put metrics histogram never increases from 0 even though millions of such operations are made. Needless to say the latency for those operations are not measured either. The value of HBASE-5533 metrics are suspect given the client will batch put and delete ops like this.

      I had a fix in progress but HBASE-6284 messed it up. Before, MultiAction processing in HRegionServer would distingush between puts and deletes and dispatch them separately. It was easy to account for the time for them. Now both puts and deletes are submitted in batch together as mutations.

        Attachments

        1. 6377-trunk-simple.patch
          7 kB
          Andrew Purtell
        2. 6377.patch
          10 kB
          Andrew Purtell
        3. 6377-0.94.patch
          20 kB
          Andrew Purtell
        4. 6377-0.94-remove-get-put-delete-histograms.patch
          5 kB
          Andrew Purtell
        5. 6377-trunk-remove-get-put-delete-histograms.patch
          3 kB
          Andrew Purtell
        There are no Sub-Tasks for this issue.

          Activity

            People

            • Assignee:
              apurtell Andrew Purtell
              Reporter:
              apurtell Andrew Purtell
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: