Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-6124

Backport HBASE-6033 to 0.90, 0.92 and 0.94

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.90.6, 0.92.1, 0.94.0
    • Fix Version/s: 0.90.7, 0.92.1, 0.94.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HBASE-6033 is pushed into 0.96. It's better to have it for previous version too.

      1. patch-0.94.txt
        20 kB
        Jimmy Xiang
      2. patch-0.92.txt
        20 kB
        Jimmy Xiang
      3. patch-0.90.txt
        20 kB
        Jimmy Xiang

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          Integrated in HBase-0.92-security #109 (See https://builds.apache.org/job/HBase-0.92-security/109/)
          HBASE-6124 Backport HBASE-6033 to 0.90, 0.92 and 0.94 (Revision 1344446)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/branches/0.92/CHANGES.txt
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
          • /hbase/branches/0.92/src/main/resources/hbase-webapps/master/table.jsp
          Show
          hudson Hudson added a comment - Integrated in HBase-0.92-security #109 (See https://builds.apache.org/job/HBase-0.92-security/109/ ) HBASE-6124 Backport HBASE-6033 to 0.90, 0.92 and 0.94 (Revision 1344446) Result = SUCCESS stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java /hbase/branches/0.92/src/main/resources/hbase-webapps/master/table.jsp
          Hide
          hudson Hudson added a comment -

          Integrated in HBase-0.94-security #33 (See https://builds.apache.org/job/HBase-0.94-security/33/)
          HBASE-6124 Backport HBASE-6033 to 0.90, 0.92 and 0.94 (Revision 1344445)

          Result = FAILURE
          stack :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
          • /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java
          Show
          hudson Hudson added a comment - Integrated in HBase-0.94-security #33 (See https://builds.apache.org/job/HBase-0.94-security/33/ ) HBASE-6124 Backport HBASE-6033 to 0.90, 0.92 and 0.94 (Revision 1344445) Result = FAILURE stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java
          Hide
          hudson Hudson added a comment -

          Integrated in HBase-0.92 #434 (See https://builds.apache.org/job/HBase-0.92/434/)
          HBASE-6124 Backport HBASE-6033 to 0.90, 0.92 and 0.94 (Revision 1344446)

          Result = FAILURE
          stack :
          Files :

          • /hbase/branches/0.92/CHANGES.txt
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
          • /hbase/branches/0.92/src/main/resources/hbase-webapps/master/table.jsp
          Show
          hudson Hudson added a comment - Integrated in HBase-0.92 #434 (See https://builds.apache.org/job/HBase-0.92/434/ ) HBASE-6124 Backport HBASE-6033 to 0.90, 0.92 and 0.94 (Revision 1344446) Result = FAILURE stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java /hbase/branches/0.92/src/main/resources/hbase-webapps/master/table.jsp
          Hide
          hudson Hudson added a comment -

          Integrated in HBase-0.94 #235 (See https://builds.apache.org/job/HBase-0.94/235/)
          HBASE-6124 Backport HBASE-6033 to 0.90, 0.92 and 0.94 (Revision 1344445)

          Result = FAILURE
          stack :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
          • /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java
          Show
          hudson Hudson added a comment - Integrated in HBase-0.94 #235 (See https://builds.apache.org/job/HBase-0.94/235/ ) HBASE-6124 Backport HBASE-6033 to 0.90, 0.92 and 0.94 (Revision 1344445) Result = FAILURE stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java /hbase/branches/0.94/src/main/resources/hbase-webapps/master/table.jsp /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java
          Hide
          stack stack added a comment -

          Committed to 0.90, 0.92 and 0.94. Thanks for the patch Jimmy.

          Show
          stack stack added a comment - Committed to 0.90, 0.92 and 0.94. Thanks for the patch Jimmy.
          Hide
          jxiang Jimmy Xiang added a comment -

          As in the current HBase releases, new feature is backward compatible, not forward compatible.
          In mixed deployment, it should not be used.

          Show
          jxiang Jimmy Xiang added a comment - As in the current HBase releases, new feature is backward compatible, not forward compatible. In mixed deployment, it should not be used.
          Hide
          zhihyu@ebaysf.com Ted Yu added a comment -

          In patch for 0.92:

          +          return CompactionState.valueOf(
          +            rs.getCompactionState(pair.getFirst().getRegionName()));
          

          what if user only updates jar on client side and the cluster doesn't support getCompactionState() ?

          Show
          zhihyu@ebaysf.com Ted Yu added a comment - In patch for 0.92: + return CompactionState.valueOf( + rs.getCompactionState(pair.getFirst().getRegionName())); what if user only updates jar on client side and the cluster doesn't support getCompactionState() ?
          Hide
          apurtell Andrew Purtell added a comment -

          +1 nice feature.

          Show
          apurtell Andrew Purtell added a comment - +1 nice feature.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12530074/patch-0.94.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2031//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530074/patch-0.94.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2031//console This message is automatically generated.
          Hide
          jxiang Jimmy Xiang added a comment -

          Patches for 0.92 and 0.94 are similar to the original one for 0.96, except that a new region interface call is added.

          Patch for 0.90 is different since the compaction logic is different.

          Show
          jxiang Jimmy Xiang added a comment - Patches for 0.92 and 0.94 are similar to the original one for 0.96, except that a new region interface call is added. Patch for 0.90 is different since the compaction logic is different.

            People

            • Assignee:
              jxiang Jimmy Xiang
              Reporter:
              jxiang Jimmy Xiang
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development