Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5945

Reduce buffer copies in IPC server response path

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.98.0, 0.96.1
    • Component/s: IPC/RPC
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The new PB code is sloppy with buffers and makes several needless copies. This increases GC time a lot. A few simple changes can cut this back down.

        Attachments

        1. without_patch.png
          384 kB
          stack
        2. with_patch.png
          386 kB
          stack
        3. hbase-5495.txt
          24 kB
          Todd Lipcon
        4. even-fewer-copies.txt
          17 kB
          Todd Lipcon
        5. buffer-copies.txt
          2 kB
          Todd Lipcon
        6. 5945v5.txt
          45 kB
          stack
        7. 5945v4.txt
          27 kB
          stack
        8. 5945v4.txt
          27 kB
          stack
        9. 5945v2.txt
          23 kB
          stack
        10. 5945-in-progress.patch
          101 kB
          Devaraj Das
        11. 5945-in-progress.2.patch
          144 kB
          Devaraj Das
        12. 5945-in-progress.2.1.patch
          136 kB
          Devaraj Das

          Issue Links

            Activity

              People

              • Assignee:
                stack stack
                Reporter:
                tlipcon Todd Lipcon
              • Votes:
                0 Vote for this issue
                Watchers:
                16 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: