Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.92.2, 0.94.1, 0.95.2
    • Fix Version/s: 0.94.4, 0.95.0
    • Component/s: build, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Clover is disabled right now. I would like to add a profile that enables clover reports. We can also backport this to 0.92, and 0.94, since we are also interested in test coverage for those branches.

      1. hbase-clover_v1.patch
        3 kB
        Enis Soztutar
      2. hbase-clover_v2.patch
        3 kB
        Enis Soztutar
      3. HBASE-5888-0.94.patch
        3 kB
        Andrey Klochkov
      4. HBASE-5888-0.94.patch
        3 kB
        Andrey Klochkov

        Activity

        Hide
        Enis Soztutar added a comment -

        Patch against trunk. I'll provide backwards patches once we are settled.

        Replicating the patch comment:

        Profile for running clover. You need to have a clover license under ~/.clover.license for $

        {clover.version}

        or you can provide the license with -Dmaven.clover.licenseLocation=/path/to/license. Committers can find
        the license under https://svn.apache.org/repos/private/committers/donated-licenses/clover/
        Note that clover 2.6.3 does not run with maven 3, so you have to use maven2. The report will be generated
        under target/site/clover/index.html when you run
        MAVEN_OPTS=-Xmx2048m mvn clean test -Pclover site

        Show
        Enis Soztutar added a comment - Patch against trunk. I'll provide backwards patches once we are settled. Replicating the patch comment: Profile for running clover. You need to have a clover license under ~/.clover.license for $ {clover.version} or you can provide the license with -Dmaven.clover.licenseLocation=/path/to/license. Committers can find the license under https://svn.apache.org/repos/private/committers/donated-licenses/clover/ Note that clover 2.6.3 does not run with maven 3, so you have to use maven2. The report will be generated under target/site/clover/index.html when you run MAVEN_OPTS=-Xmx2048m mvn clean test -Pclover site
        Hide
        Enis Soztutar added a comment -

        Updated the patch to ignore generated packages (thrift.generated, protobuf.generated), since they are skewing coverage results.

        I uploaded a sample report for 0.92 here:
        http://people.apache.org/~enis/hbase-clover/

        Show
        Enis Soztutar added a comment - Updated the patch to ignore generated packages (thrift.generated, protobuf.generated), since they are skewing coverage results. I uploaded a sample report for 0.92 here: http://people.apache.org/~enis/hbase-clover/
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525115/HBASE-5358_v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1695//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525115/HBASE-5358_v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1695//console This message is automatically generated.
        Hide
        Enis Soztutar added a comment -

        Uploaded wrong patch. This should be the one.

        Show
        Enis Soztutar added a comment - Uploaded wrong patch. This should be the one.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525118/hbase-clover_v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.replication.TestReplication
        org.apache.hadoop.hbase.client.TestShell

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1696//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1696//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1696//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525118/hbase-clover_v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.client.TestShell Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1696//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1696//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1696//console This message is automatically generated.
        Hide
        stack added a comment -

        Committed to trunk. Thanks for the patch Enis.

        Show
        stack added a comment - Committed to trunk. Thanks for the patch Enis.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2834 (See https://builds.apache.org/job/HBase-TRUNK/2834/)
        HBASE-5888 Clover profile in build (Revision 1332829)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2834 (See https://builds.apache.org/job/HBase-TRUNK/2834/ ) HBASE-5888 Clover profile in build (Revision 1332829) Result = FAILURE stack : Files : /hbase/trunk/pom.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #189 (See https://builds.apache.org/job/HBase-TRUNK-security/189/)
        HBASE-5888 Clover profile in build (Revision 1332829)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #189 (See https://builds.apache.org/job/HBase-TRUNK-security/189/ ) HBASE-5888 Clover profile in build (Revision 1332829) Result = SUCCESS stack : Files : /hbase/trunk/pom.xml
        Hide
        Andrey Klochkov added a comment -

        Attaching the patch updated for 0.94. Please put it in 0.94 also.

        Show
        Andrey Klochkov added a comment - Attaching the patch updated for 0.94. Please put it in 0.94 also.
        Hide
        Jesse Yates added a comment -

        Andrey Klochko what's the deal with this exclude:

        + <groupId>org.apache.maven.plugins</groupId>
        + <artifactId>maven-surefire-plugin</artifactId>
        + <configuration>
        + <excludes>
        + <exclude>**/Load.java</exclude>
        + </excludes>
        + </configuration>

        Otherwise, it looks good to me.

        Show
        Jesse Yates added a comment - Andrey Klochko what's the deal with this exclude: + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-surefire-plugin</artifactId> + <configuration> + <excludes> + <exclude>**/ Load .java</exclude> + </excludes> + </configuration> Otherwise, it looks good to me.
        Hide
        Andrey Klochkov added a comment -

        Alexander Jesse Thanks for the catch. We excluded load tests with this mask, but actually the mask should be more exact. Let me update the patch.

        Show
        Andrey Klochkov added a comment - Alexander Jesse Thanks for the catch. We excluded load tests with this mask, but actually the mask should be more exact. Let me update the patch.
        Hide
        Andrey Klochkov added a comment -

        Updated the patch for 0.94: removed load tests exclusion pattern which is not related to Clover profile per se.

        Show
        Andrey Klochkov added a comment - Updated the patch for 0.94: removed load tests exclusion pattern which is not related to Clover profile per se.
        Hide
        Jesse Yates added a comment -

        +1 on latest. I'll commit this evening, unless there is an objection.

        Show
        Jesse Yates added a comment - +1 on latest. I'll commit this evening, unless there is an objection.
        Hide
        stack added a comment -

        +1 Do I have to do anything on builds.apache.org to make this start running after it goes in?

        Show
        stack added a comment - +1 Do I have to do anything on builds.apache.org to make this start running after it goes in?
        Hide
        Jesse Yates added a comment -

        Committed to 0.94.4

        Show
        Jesse Yates added a comment - Committed to 0.94.4
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #611 (See https://builds.apache.org/job/HBase-0.94/611/)
        HBASE-5888: Clover profile in build (Andrey Klochkov) (Revision 1417231)

        Result = FAILURE
        jyates :
        Files :

        • /hbase/branches/0.94/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-0.94 #611 (See https://builds.apache.org/job/HBase-0.94/611/ ) HBASE-5888 : Clover profile in build (Andrey Klochkov) (Revision 1417231) Result = FAILURE jyates : Files : /hbase/branches/0.94/pom.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #86 (See https://builds.apache.org/job/HBase-0.94-security/86/)
        HBASE-5888: Clover profile in build (Andrey Klochkov) (Revision 1417231)

        Result = SUCCESS
        jyates :
        Files :

        • /hbase/branches/0.94/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #86 (See https://builds.apache.org/job/HBase-0.94-security/86/ ) HBASE-5888 : Clover profile in build (Andrey Klochkov) (Revision 1417231) Result = SUCCESS jyates : Files : /hbase/branches/0.94/pom.xml
        Hide
        Lars Hofhansl added a comment -

        Jesse Yates We should wait with closing issues until a release with the fix actually shipped.

        Show
        Lars Hofhansl added a comment - Jesse Yates We should wait with closing issues until a release with the fix actually shipped.
        Hide
        Jesse Yates added a comment -

        Lars Hofhansl good call- my bad.

        Show
        Jesse Yates added a comment - Lars Hofhansl good call- my bad.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/10/)
        HBASE-5888: Clover profile in build (Andrey Klochkov) (Revision 1417231)

        Result = FAILURE
        jyates :
        Files :

        • /hbase/branches/0.94/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/10/ ) HBASE-5888 : Clover profile in build (Andrey Klochkov) (Revision 1417231) Result = FAILURE jyates : Files : /hbase/branches/0.94/pom.xml

          People

          • Assignee:
            Enis Soztutar
            Reporter:
            Enis Soztutar
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development