HBase
  1. HBase
  2. HBASE-5443 Add PB-based calls to HRegionInterface
  3. HBASE-5785

Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion

    Details

    • Hadoop Flags:
      Reviewed
    • Tags:
      noob

      Description

      We need to add some unit tests for the probuf utilities to catch issues earlier.

        Activity

        Jimmy Xiang created issue -
        Jimmy Xiang made changes -
        Field Original Value New Value
        Component/s ipc [ 12312136 ]
        Component/s master [ 12312138 ]
        Component/s migration [ 12315703 ]
        Component/s regionserver [ 12312139 ]
        Hide
        stack added a comment -

        Marking critical and noob (in case anyone out there wants to help our man Jimmy out)

        Show
        stack added a comment - Marking critical and noob (in case anyone out there wants to help our man Jimmy out)
        stack made changes -
        Labels noob
        Tags noob
        Priority Major [ 3 ] Critical [ 2 ]
        Jimmy Xiang made changes -
        Attachment hbase-5785.patch [ 12524879 ]
        Hide
        Jimmy Xiang added a comment -

        I added some tests. I indeed found an issue. It is helpful.
        We can add more later on.

        Show
        Jimmy Xiang added a comment - I added some tests. I indeed found an issue. It is helpful. We can add more later on.
        Jimmy Xiang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12524879/hbase-5785.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.replication.TestReplication

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1669//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1669//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1669//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524879/hbase-5785.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1669//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1669//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1669//console This message is automatically generated.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4936/
        -----------------------------------------------------------

        Review request for hbase and Michael Stack.

        Summary
        -------

        I added some tests for that conversion methods. For those helper utilities, they are tested in other tests implicitly. We can add more later on if needed.

        This addresses bug HBASE-5785.
        https://issues.apache.org/jira/browse/HBASE-5785

        Diffs


        src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java 994cb76
        src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java 9b594aa
        src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java PRE-CREATION

        Diff: https://reviews.apache.org/r/4936/diff

        Testing
        -------

        The new tests are green.

        Thanks,

        Jimmy

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4936/ ----------------------------------------------------------- Review request for hbase and Michael Stack. Summary ------- I added some tests for that conversion methods. For those helper utilities, they are tested in other tests implicitly. We can add more later on if needed. This addresses bug HBASE-5785 . https://issues.apache.org/jira/browse/HBASE-5785 Diffs src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java 994cb76 src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java 9b594aa src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/4936/diff Testing ------- The new tests are green. Thanks, Jimmy
        Hide
        stack added a comment -

        Committed to trunk. Good one Jimmy. Thanks.

        Show
        stack added a comment - Committed to trunk. Good one Jimmy. Thanks.
        stack made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2834 (See https://builds.apache.org/job/HBase-TRUNK/2834/)
        HBASE-5785 Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion (Revision 1332824)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/protobuf
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2834 (See https://builds.apache.org/job/HBase-TRUNK/2834/ ) HBASE-5785 Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion (Revision 1332824) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/protobuf /hbase/trunk/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #189 (See https://builds.apache.org/job/HBase-TRUNK-security/189/)
        HBASE-5785 Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion (Revision 1332824)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/protobuf
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #189 (See https://builds.apache.org/job/HBase-TRUNK-security/189/ ) HBASE-5785 Adding unit tests for protbuf utils introduced for HRegionInterface pb conversion (Revision 1332824) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/protobuf /hbase/trunk/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
        stack made changes -
        Fix Version/s 0.95.0 [ 12324094 ]
        Fix Version/s 0.96.0 [ 12320040 ]
        stack made changes -
        Fix Version/s 0.98.0 [ 12323143 ]
        stack made changes -
        Fix Version/s 0.98.0 [ 12323143 ]
        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.
        stack made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Jimmy Xiang
            Reporter:
            Jimmy Xiang
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development