Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: None
    • Labels:
      None

      Description

      Need to import HADOOP-7384 into our version of Hadoop QA to allow test-patch to be more flexible about patch format

      1. HBASE-5743-2.patch
        3 kB
        Nicolas Spiegelberg
      2. HBASE-5743.patch
        2 kB
        Nicolas Spiegelberg

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          59m 33s 1 Nicolas Spiegelberg 06/Apr/12 22:41
          Resolved Resolved Closed Closed
          188d 7h 53m 1 Lars Hofhansl 12/Oct/12 06:35
          Gavin made changes -
          Link This issue depends upon HADOOP-7384 [ HADOOP-7384 ]
          Gavin made changes -
          Link This issue depends on HADOOP-7384 [ HADOOP-7384 ]
          Lars Hofhansl made changes -
          Fix Version/s 0.94.0 [ 12316419 ]
          stack made changes -
          Fix Version/s 0.95.0 [ 12324094 ]
          Fix Version/s 0.94.0 [ 12316419 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          Fix Version/s 0.89-fb [ 12320178 ]
          Lars Hofhansl made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #161 (See https://builds.apache.org/job/HBase-TRUNK-security/161/)
          HBASE-5743 Support GIT patches with Hadoop QA (Revision 1310600)

          Result = FAILURE
          nspiegelberg :
          Files :

          • /hbase/trunk/dev-support/smart-apply-patch.sh
          • /hbase/trunk/dev-support/test-patch.sh
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #161 (See https://builds.apache.org/job/HBase-TRUNK-security/161/ ) HBASE-5743 Support GIT patches with Hadoop QA (Revision 1310600) Result = FAILURE nspiegelberg : Files : /hbase/trunk/dev-support/smart-apply-patch.sh /hbase/trunk/dev-support/test-patch.sh
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2723 (See https://builds.apache.org/job/HBase-TRUNK/2723/)
          HBASE-5743 Support GIT patches with Hadoop QA (Revision 1310600)

          Result = SUCCESS
          nspiegelberg :
          Files :

          • /hbase/trunk/dev-support/smart-apply-patch.sh
          • /hbase/trunk/dev-support/test-patch.sh
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2723 (See https://builds.apache.org/job/HBase-TRUNK/2723/ ) HBASE-5743 Support GIT patches with Hadoop QA (Revision 1310600) Result = SUCCESS nspiegelberg : Files : /hbase/trunk/dev-support/smart-apply-patch.sh /hbase/trunk/dev-support/test-patch.sh
          Hide
          Todd Lipcon added a comment -

          +1, looks good to me. Make sure you get the +x flag for the new script on commit.

          Show
          Todd Lipcon added a comment - +1, looks good to me. Make sure you get the +x flag for the new script on commit.
          Nicolas Spiegelberg made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 0.94.0 [ 12316419 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          Fix Version/s 0.89-fb [ 12320178 ]
          Nicolas Spiegelberg made changes -
          Attachment HBASE-5743-2.patch [ 12521762 ]
          Hide
          Nicolas Spiegelberg added a comment -

          using smart-apply-patch file from hadoop trunk instead of the older version from HADOOP-7384. This runs 'patch' in dry-run mode to determine prefix level, which is a far more fault-tolerant way of solving the problem.

          Show
          Nicolas Spiegelberg added a comment - using smart-apply-patch file from hadoop trunk instead of the older version from HADOOP-7384 . This runs 'patch' in dry-run mode to determine prefix level, which is a far more fault-tolerant way of solving the problem.
          Nicolas Spiegelberg made changes -
          Attachment HBASE-5743.patch [ 12521733 ]
          Hide
          Nicolas Spiegelberg added a comment -

          Test plan:

          1. ./dev-support/smart-apply-patch.sh HBASE-5335-trunk-3.patch
          2. git show 5335-trunk | PATCH=echo dev-support/smart-apply-patch.sh -

          Show
          Nicolas Spiegelberg added a comment - Test plan: 1. ./dev-support/smart-apply-patch.sh HBASE-5335 -trunk-3.patch 2. git show 5335-trunk | PATCH=echo dev-support/smart-apply-patch.sh -
          Nicolas Spiegelberg made changes -
          Assignee Nicolas Spiegelberg [ nspiegelberg ]
          Nicolas Spiegelberg made changes -
          Field Original Value New Value
          Link This issue depends on HADOOP-7384 [ HADOOP-7384 ]
          Nicolas Spiegelberg created issue -

            People

            • Assignee:
              Nicolas Spiegelberg
              Reporter:
              Nicolas Spiegelberg
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development