Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Activity

      Hide
      ctrezzo Chris Trezzo added a comment -

      Currently, the replication RPCs for log shipping have been converted to Protobufs. In HBASE-5944, Stack mentioned that the znodes for replication still needed to be converted, but I don't see a patch for it.

      Some examples of the znode values:

      • The value of the replication status znode (TRUE or FALSE)
      • The cluster key for a peer cluster, containing the zk quorum, zk port and hbase base znode (zk1.host.com,zk2.host.com,zk3.host.com:2181:/hbase)
      • The peer state znode (ENABLED or DISABLED)
      • The HLog position (a long containing the position in the hlog)

      All of the replication values are relatively simple. Do we think it is worth converting them to protobufs?

      Show
      ctrezzo Chris Trezzo added a comment - Currently, the replication RPCs for log shipping have been converted to Protobufs. In HBASE-5944 , Stack mentioned that the znodes for replication still needed to be converted, but I don't see a patch for it. Some examples of the znode values: The value of the replication status znode (TRUE or FALSE) The cluster key for a peer cluster, containing the zk quorum, zk port and hbase base znode (zk1.host.com,zk2.host.com,zk3.host.com:2181:/hbase) The peer state znode (ENABLED or DISABLED) The HLog position (a long containing the position in the hlog) All of the replication values are relatively simple. Do we think it is worth converting them to protobufs?
      Hide
      tlipcon Todd Lipcon added a comment -

      I think it's still worth doing. Imagine if, in the future, we want to add a flag so that replication isn't just "TRUE or FALSE", but also "LAGGED", with a parameter for how long the lag should be? For the HLogs, maybe we need to extend it to allow multiple HLogs once we have the multi-WAL support.

      Show
      tlipcon Todd Lipcon added a comment - I think it's still worth doing. Imagine if, in the future, we want to add a flag so that replication isn't just "TRUE or FALSE", but also "LAGGED", with a parameter for how long the lag should be? For the HLogs, maybe we need to extend it to allow multiple HLogs once we have the multi-WAL support.
      Hide
      ctrezzo Chris Trezzo added a comment -

      Sounds good to me. I will work on a patch.

      Show
      ctrezzo Chris Trezzo added a comment - Sounds good to me. I will work on a patch.
      Hide
      stack stack added a comment -

      @Chris See HBASE-5965. Looks like I abandoned it on the last length. Looks like it needs some polish to get it over the finish line. If you are on for it, be my guest. Thanks.

      Show
      stack stack added a comment - @Chris See HBASE-5965 . Looks like I abandoned it on the last length. Looks like it needs some polish to get it over the finish line. If you are on for it, be my guest. Thanks.
      Hide
      ctrezzo Chris Trezzo added a comment -

      @stack Thanks! I didn't see HBASE-5965. I'll take a look.

      Show
      ctrezzo Chris Trezzo added a comment - @stack Thanks! I didn't see HBASE-5965 . I'll take a look.
      Hide
      stack stack added a comment -

      Closing as dup of HBASE-5965. I think finishing that off will take care of this issue. Hope thats ok w/ you Chris (I was going to try and finish up HBASE-5965...)

      Show
      stack stack added a comment - Closing as dup of HBASE-5965 . I think finishing that off will take care of this issue. Hope thats ok w/ you Chris (I was going to try and finish up HBASE-5965 ...)

        People

        • Assignee:
          ctrezzo Chris Trezzo
          Reporter:
          tlipcon Todd Lipcon
        • Votes:
          0 Vote for this issue
          Watchers:
          8 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development