Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5387

Reuse compression streams in HFileBlock.Writer

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.94.0
    • Fix Version/s: 0.94.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We need to to reuse compression streams in HFileBlock.Writer instead of allocating them every time. The motivation is that when using Java's built-in implementation of Gzip, we allocate a new GZIPOutputStream object and an associated native data structure every time we create a compression stream. The native data structure is only deallocated in the finalizer. This is one suspected cause of recent TestHFileBlock failures on Hadoop QA: https://builds.apache.org/job/HBase-TRUNK/2658/testReport/org.apache.hadoop.hbase.io.hfile/TestHFileBlock/testPreviousOffset_1_/.

        Attachments

        1. ASF.LICENSE.NOT.GRANTED--D1725.2.patch
          15 kB
          Phabricator
        2. ASF.LICENSE.NOT.GRANTED--D1725.1.patch
          27 kB
          Phabricator
        3. Fix-deflater-leak-2012-02-12_00_37_27.patch
          13 kB
          Mikhail Bautin
        4. 5387.txt
          12 kB
          Ted Yu
        5. ASF.LICENSE.NOT.GRANTED--D1719.5.patch
          12 kB
          Phabricator
        6. ASF.LICENSE.NOT.GRANTED--D1719.4.patch
          12 kB
          Phabricator
        7. ASF.LICENSE.NOT.GRANTED--D1719.3.patch
          16 kB
          Phabricator
        8. Fix-deflater-leak-2012-02-11_17_13_10.patch
          13 kB
          Mikhail Bautin
        9. ASF.LICENSE.NOT.GRANTED--D1719.2.patch
          12 kB
          Phabricator
        10. ASF.LICENSE.NOT.GRANTED--D1719.1.patch
          10 kB
          Phabricator
        11. Fix-deflater-leak-2012-02-10_18_48_45.patch
          12 kB
          Mikhail Bautin

          Activity

            People

            • Assignee:
              mikhail Mikhail Bautin
              Reporter:
              mikhail Mikhail Bautin
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: