[HBASE-5281] Should a failure in creating an unassigned node abort the master?

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 0.90.5
• Fix Version/s: 0.92.1, 0.94.0
• Component/s: master
• Assignee: Harsh J
• Reporter: Harsh J
• Created: 26/Jan/12 11:52
• Updated: 16/Nov/12 20:28
• Resolved: 01/Feb/12 03:42

Description

In AssignmentManager's CreateUnassignedAsyncCallback, we have the following condition:

if (rc != 0) {
        // Thisis resultcode.  If non-zero, need to resubmit.
        LOG.warn("rc != 0 for " + path + " -- retryable connectionloss -- " +
          "FIX see http://wiki.apache.org/hadoop/ZooKeeper/FAQ#A2");
        this.zkw.abort("Connectionloss writing unassigned at " + path +
          ", rc=" + rc, null);
        return;
}

While a similar structure inside ExistsUnassignedAsyncCallback (which the above is linked to), does not have such a force abort.

Do we really require the abort statement here, or can we make do without?

Issue Links

• is related to: HBASE-3065 Retry all 'retryable' zk operations; e.g. connection loss